From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754058Ab1LZJt7 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 26 Dec 2011 04:49:59 -0500
Received: from mail-ey0-f174.google.com ([209.85.215.174]:49781 "EHLO
	mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752647Ab1LZJtw convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 26 Dec 2011 04:49:52 -0500
MIME-Version: 1.0
In-Reply-To: <CANq1E4S+Sa1BERtR6aNH-ypRo+oJ1fRXkuVa+tREy5qVodv2pw@mail.gmail.com>
References: <87ty4ss0z4.fsf@prochyra.name>
	<CAHR064h7a=RQq=p1J+gKpC5_6ow8ChUFFkC39HwtmerHaMksjw@mail.gmail.com>
	<87ty4qdpna.fsf@prochyra.name>
	<20111224142028.GA32171@srcf.ucam.org>
	<CANq1E4S+Sa1BERtR6aNH-ypRo+oJ1fRXkuVa+tREy5qVodv2pw@mail.gmail.com>
Date: Mon, 26 Dec 2011 10:49:50 +0100
Message-ID: <CAHR064jyubYf5d_KekB8+wqmGXcm8v4Gg9jVt3W9Kx_Ljh++GA@mail.gmail.com>
Subject: Re: [PATCH] Platform: samsung-laptop: add DMI information for Samsung
 N150 Plus
From: Corentin Chary <corentin.chary@gmail.com>
To: David Herrmann <dh.herrmann@googlemail.com>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>,
        Andrzej Prochyra <andrzej@prochyra.name>,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Dec 24, 2011 at 3:28 PM, David Herrmann
<dh.herrmann@googlemail.com> wrote:
> On Sat, Dec 24, 2011 at 3:20 PM, Matthew Garrett <mjg59@srcf.ucam.org> wrote:
>> On Sat, Dec 24, 2011 at 02:12:57PM +0000, Andrzej Prochyra wrote:
>>> 'acpi_video0' not functional.  Brightness can be controlled through
>>> intel_backlight interface.  There are 21 brightness levels and the
>>> backlight can be turned off.
>>
>> If acpi_video0 doesn't work then we either need to work out why it's not
>> working or make it vanish completely, so this patch isn't the correct
>> approach.
>
> Just to make clear, intel_backlight isn't working properly either. If
> my laptop boots with backlight at 50% then intel_backlight will only
> work in the range 0%-50% on my machine. If I use the samsung module to
> set it to 100% then  intel_backlight works correctly in the range
> 0-100% until next reboot/suspend.
>
> So I'd recommend staying with the samsung module and disabling the
> acpi_backlight entirely. The samsung module is the only backlight
> control which works properly.

Can I take a look at the DSDT to see how it's broken ?
If it's really not functional, then it should be added to the
blacklist in video_detect.c

-- 
Corentin Chary
http://xf.iksaif.net