From: Todd Kjos <tkjos@google.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Kees Cook" <keescook@chromium.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
"Jarkko Sakkinen" <jarkko@kernel.org>,
"Wedson Almeida Filho" <wedsonaf@google.com>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Finn Behrens" <me@kloenk.de>,
"Sven Van Asbroeck" <thesven73@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Wayne Campbell" <wcampbell1995@gmail.com>,
"Arve Hjønnevåg" <arve@android.com>,
"Todd Kjos" <tkjos@android.com>,
"Martijn Coenen" <maco@android.com>,
"Joel Fernandes" <joel@joelfernandes.org>,
"Christian Brauner" <brauner@kernel.org>,
"Hridya Valsaraju" <hridya@google.com>,
"Suren Baghdasaryan" <surenb@google.com>
Subject: Re: [PATCH v6 23/23] [RFC] drivers: android: Binder IPC in Rust
Date: Mon, 9 May 2022 10:52:30 -0700 [thread overview]
Message-ID: <CAHRSSExk=cnJDUdxChf3H283rumV1M_SL4T9seSLEBVDxcrhzw@mail.gmail.com> (raw)
In-Reply-To: <YnYqHSVakm1EAo5a@kroah.com>
On Sat, May 7, 2022 at 1:13 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Sat, May 07, 2022 at 12:55:17AM -0700, Kees Cook wrote:
> > On Sat, May 07, 2022 at 07:24:21AM +0200, Miguel Ojeda wrote:
> > > From: Wedson Almeida Filho <wedsonaf@google.com>
> > >
> > > A port to Rust of the Android Binder IPC mechanism.
> > >
> > > This module is a work in progress and will be sent for review later
> > > on, as well as separately from the Rust support.
> >
> > Is any functionality missing for this driver compared to the C driver?
>
> There is no binderfs support, which would be a major regression if it
> were to be added.
>
> And odds are the new binder additions in the past few months are
> probably not included here either.
>
> There is a binder regression test in Android that can be run to test all
> of this to see what is missing. That should be a good test of
> compatibility.
There are a set of tests in the Android tree at
frameworks/libs/native/binder/tests, but just booting and having a
usable device with this version replacing the C version is pretty
impressive. Can you boot and run a real device with this?
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2022-05-09 17:52 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-07 5:23 [PATCH v6 00/23] Rust support Miguel Ojeda
2022-05-07 5:23 ` Miguel Ojeda
2022-05-07 5:23 ` Miguel Ojeda
2022-05-07 5:23 ` Miguel Ojeda
2022-05-07 5:23 ` [PATCH v6 01/23] kallsyms: avoid hardcoding the buffer size Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 02/23] kallsyms: support "big" kernel symbols Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 03/23] kallsyms: increase maximum kernel symbol length to 512 Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 04/23] kunit: take `kunit_assert` as `const` Miguel Ojeda
2022-05-12 19:01 ` Brendan Higgins
2022-05-07 5:24 ` [PATCH v6 05/23] rust: add C helpers Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 06/23] rust: add `compiler_builtins` crate Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 07/23] rust: import upstream `alloc` crate Miguel Ojeda
2022-05-07 9:23 ` Kees Cook
2022-05-07 9:33 ` Miguel Ojeda
2022-05-07 17:06 ` Kees Cook
2022-05-07 17:30 ` Linus Torvalds
2022-05-07 19:34 ` Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 08/23] rust: adapt `alloc` crate to the kernel Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 09/23] rust: add `build_error` crate Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 10/23] rust: add `macros` crate Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 11/23] rust: add `kernel` crate's `sync` module Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 12/23] rust: add `kernel` crate Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 13/23] rust: export generated symbols Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 14/23] vsprintf: add new `%pA` format specifier Miguel Ojeda
2022-05-07 8:19 ` Kees Cook
2022-05-07 9:35 ` Miguel Ojeda
2022-05-10 8:38 ` Petr Mladek
2022-05-10 10:45 ` Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 15/23] scripts: add `rustdoc_test_{builder,gen}.py` scripts Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 16/23] scripts: add `generate_rust_analyzer.py` scripts Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 17/23] scripts: decode_stacktrace: demangle Rust symbols Miguel Ojeda
2022-05-07 8:32 ` Kees Cook
2022-05-07 10:21 ` Miguel Ojeda
2022-05-07 17:09 ` Kees Cook
2022-05-07 5:24 ` [PATCH v6 18/23] docs: add Rust documentation Miguel Ojeda
2022-05-07 8:15 ` Kees Cook
2022-05-07 8:45 ` Miguel Ojeda
2022-05-09 4:02 ` Akira Yokosawa
2022-05-09 10:41 ` Miguel Ojeda
2022-05-09 14:56 ` Akira Yokosawa
2022-05-09 22:37 ` Jonathan Corbet
2022-05-10 11:57 ` Miguel Ojeda
2022-05-09 22:32 ` Jonathan Corbet
2022-05-10 3:14 ` Gaelan Steele
2022-05-10 5:53 ` Josh Triplett
2022-05-11 13:49 ` Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 19/23] Kbuild: add Rust support Miguel Ojeda
2022-05-07 5:24 ` Miguel Ojeda
2022-05-07 5:24 ` Miguel Ojeda
2022-05-07 5:24 ` Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 20/23] samples: add Rust examples Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 21/23] MAINTAINERS: Rust Miguel Ojeda
2022-05-07 8:06 ` Kees Cook
2022-05-07 5:24 ` [PATCH v6 22/23] [RFC] drivers: gpio: PrimeCell PL061 in Rust Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 23/23] [RFC] drivers: android: Binder IPC " Miguel Ojeda
2022-05-07 7:55 ` Kees Cook
2022-05-07 8:13 ` Greg Kroah-Hartman
2022-05-09 17:52 ` Todd Kjos [this message]
2022-05-07 8:06 ` [PATCH v6 00/23] Rust support Kees Cook
2022-05-07 8:06 ` Kees Cook
2022-05-07 8:06 ` Kees Cook
2022-05-07 8:06 ` Kees Cook
2022-05-08 18:06 ` Matthew Wilcox
2022-05-08 18:06 ` Matthew Wilcox
2022-05-08 18:06 ` Matthew Wilcox
2022-05-08 18:06 ` Matthew Wilcox
2022-05-09 9:39 ` Wei Liu
2022-05-09 9:39 ` Wei Liu
2022-05-09 9:39 ` Wei Liu
2022-05-09 9:39 ` Wei Liu
2022-05-07 9:29 ` David Gow
2022-05-07 9:29 ` David Gow
2022-05-07 9:29 ` David Gow
2022-05-07 9:29 ` David Gow
2022-05-07 15:03 ` Miguel Ojeda
2022-05-07 15:03 ` Miguel Ojeda
2022-05-07 15:03 ` Miguel Ojeda
2022-05-07 15:03 ` Miguel Ojeda
2022-05-10 4:44 ` David Gow
2022-05-10 4:44 ` David Gow
2022-05-10 4:44 ` David Gow
2022-05-10 4:44 ` David Gow
2022-05-10 11:36 ` Miguel Ojeda
2022-05-10 11:36 ` Miguel Ojeda
2022-05-10 11:36 ` Miguel Ojeda
2022-05-10 11:36 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHRSSExk=cnJDUdxChf3H283rumV1M_SL4T9seSLEBVDxcrhzw@mail.gmail.com' \
--to=tkjos@google.com \
--cc=alex.gaynor@gmail.com \
--cc=arve@android.com \
--cc=brauner@kernel.org \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=hridya@google.com \
--cc=jarkko@kernel.org \
--cc=joel@joelfernandes.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=me@kloenk.de \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=surenb@google.com \
--cc=thesven73@gmail.com \
--cc=tkjos@android.com \
--cc=torvalds@linux-foundation.org \
--cc=wcampbell1995@gmail.com \
--cc=wedsonaf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.