From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51F6AC47092 for ; Tue, 1 Jun 2021 10:52:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B294613B1 for ; Tue, 1 Jun 2021 10:52:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233650AbhFAKye (ORCPT ); Tue, 1 Jun 2021 06:54:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230282AbhFAKyc (ORCPT ); Tue, 1 Jun 2021 06:54:32 -0400 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AB25C061574 for ; Tue, 1 Jun 2021 03:52:50 -0700 (PDT) Received: by mail-pf1-x42b.google.com with SMTP id z26so7079101pfj.5 for ; Tue, 01 Jun 2021 03:52:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gCRowJKEF6abtOyiSLRhg1Y3idIlIdXjyYVD3tmG9YY=; b=kQ06QptlyaouHmPEZoKAx6vMrnJfCWjKQgzgmVeiLtojUjNkX+/CCe7yJbhmpWhet6 JSk4MB/c5YOt+3BLXcIy9HLf0+I3TjnIapaLK3tmJXxYUiHdLDCq3JhQ/2vMx2I4PYpg qBxz0/9Op8rZ2gREcRC+jL1HXkac8zWL7mer5VuI6LmU0uNv8BIvffW28fvMDM5oauom KYRghkfi/SGT53URu8216lBfFK0/jlmWvJfdGwirPO4hEWgWLRxZzxbd5AOXcJ8OF7LX o6iXo0THhRAyc5FPhv3BwPTKTaCyyTgbWiRxcLhynqAzUhq03ke2unKFRvuzRwSc2hRl dZAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gCRowJKEF6abtOyiSLRhg1Y3idIlIdXjyYVD3tmG9YY=; b=HOb2Xxj/d/js1oucrakicif3Zfb+3U8Q3X/W+MoGyFA//VTz6VbgtZHpmYH/UCwzOJ OEoOYQ35PjAPxu313kkGboWLtx/pWce1sfl9SDN4vO1grsNX78pFIc4f3uRZNt1FaVOJ flf7qjete3aEDQhScX/zh878FsdlDYzV8t7npQnk2j1mK38sXOtJgRF0915D5WtH2joQ EYbOQmPJuCWbXJjeUUnmwDjQBGRF9h0HCbiQnNHaeifHansXjoTNowbNhQsylor3m9D4 Tinzcf4nxk9ShOU/kJbyimJeisiy7sjR6RPCkoXqYXQz+yzb59CLM8ENKSEYKg25jJZZ Ju7Q== X-Gm-Message-State: AOAM531Rch1HhTr9eQ8du4i5O+MDTUjsXLFoqZYdwRmCinCBMiHKU8WC X0gH2e5g5WR2zyalsZvbEQe3eN615jZp6q/O2dBG8Q== X-Google-Smtp-Source: ABdhPJyY3Og9DuDfi3jlT2rFT/1OIbsdz5p57E5ro/YoqnayLxkjkO+KqnCp9w6rmNR0cRd+mbEfe4iFfC3fOgwxh/c= X-Received: by 2002:a05:6a00:c86:b029:2e9:3041:162f with SMTP id a6-20020a056a000c86b02902e93041162fmr21353488pfv.78.1622544769781; Tue, 01 Jun 2021 03:52:49 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Mina Almasry Date: Tue, 1 Jun 2021 03:52:38 -0700 Message-ID: Subject: Re: [PATCH] mm: hugetlb: checking for IS_ERR() instead of NULL To: Dan Carpenter Cc: Mike Kravetz , Andrew Morton , Stephen Rothwell , Linux-MM , open list , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 1, 2021 at 2:26 AM Dan Carpenter wrote: > > The alloc_migrate_huge_page() doesn't return error pointers, it returns > NULL. > > Fixes: ab45bc8b5910 ("mm, hugetlb: fix resv_huge_pages underflow on UFFDIO_COPY") > Signed-off-by: Dan Carpenter > --- > mm/hugetlb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Gah, my bad. Reviewed-by: Mina Almasry > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 69a4b551c157..3221c94b4749 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -5103,7 +5103,7 @@ int hugetlb_mcopy_atomic_pte(struct mm_struct *dst_mm, > */ > page = alloc_migrate_huge_page(h, gfp_mask, node, > nodemask); > - if (IS_ERR(page)) { > + if (!page) { > ret = -ENOMEM; > goto out; > } > -- > 2.30.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23FF2C4708F for ; Tue, 1 Jun 2021 10:52:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AD9536102A for ; Tue, 1 Jun 2021 10:52:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD9536102A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2BDFD6B00B6; Tue, 1 Jun 2021 06:52:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 246DA6B00B8; Tue, 1 Jun 2021 06:52:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09A386B00B9; Tue, 1 Jun 2021 06:52:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0065.hostedemail.com [216.40.44.65]) by kanga.kvack.org (Postfix) with ESMTP id C79FC6B00B6 for ; Tue, 1 Jun 2021 06:52:51 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 501385DD7 for ; Tue, 1 Jun 2021 10:52:51 +0000 (UTC) X-FDA: 78204842142.12.2333FE5 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by imf28.hostedemail.com (Postfix) with ESMTP id 7537920010A0 for ; Tue, 1 Jun 2021 10:52:39 +0000 (UTC) Received: by mail-pg1-f182.google.com with SMTP id j12so10380149pgh.7 for ; Tue, 01 Jun 2021 03:52:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gCRowJKEF6abtOyiSLRhg1Y3idIlIdXjyYVD3tmG9YY=; b=kQ06QptlyaouHmPEZoKAx6vMrnJfCWjKQgzgmVeiLtojUjNkX+/CCe7yJbhmpWhet6 JSk4MB/c5YOt+3BLXcIy9HLf0+I3TjnIapaLK3tmJXxYUiHdLDCq3JhQ/2vMx2I4PYpg qBxz0/9Op8rZ2gREcRC+jL1HXkac8zWL7mer5VuI6LmU0uNv8BIvffW28fvMDM5oauom KYRghkfi/SGT53URu8216lBfFK0/jlmWvJfdGwirPO4hEWgWLRxZzxbd5AOXcJ8OF7LX o6iXo0THhRAyc5FPhv3BwPTKTaCyyTgbWiRxcLhynqAzUhq03ke2unKFRvuzRwSc2hRl dZAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gCRowJKEF6abtOyiSLRhg1Y3idIlIdXjyYVD3tmG9YY=; b=oPrN9zqKFSFqYX4mKbG4D6hwOYNGo35ZkOMZA2R8dmyKfITGzyo6nLqkEogCZPyyWh W3jQg0zdZDTtkwDOgZeXCtqDTIVDxar8liKnpjeY+hGovR+W9ycZi/T7ltruehOkXQ/v DiMEIgIfEBDXGo/Uo2SMwKht8x/ACYo+HIT8D6yn9w38EJlh/np6BXPQXYUt9XmRP3Sn L5Sl9iICHrbxC6lXcZh8Un4nzASZVhF+HibYTIHzCXvo814h21urrLqL6EOGUQJXRmPw mib7rQNwe5o69nu/vdFhwOutu3WjQ0ML+T/Ah8OQeyl19l6vF9JWKaMovBUys7WpHJLb CIWQ== X-Gm-Message-State: AOAM530almKBjj45pQ84wSpZ22qAsrITxLI+QKWa79okDMewE8zXJCdR /yoT3mf2h0OC3sxevErauJMkZUIQiYIyEys/M0T1HQ== X-Google-Smtp-Source: ABdhPJyY3Og9DuDfi3jlT2rFT/1OIbsdz5p57E5ro/YoqnayLxkjkO+KqnCp9w6rmNR0cRd+mbEfe4iFfC3fOgwxh/c= X-Received: by 2002:a05:6a00:c86:b029:2e9:3041:162f with SMTP id a6-20020a056a000c86b02902e93041162fmr21353488pfv.78.1622544769781; Tue, 01 Jun 2021 03:52:49 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Mina Almasry Date: Tue, 1 Jun 2021 03:52:38 -0700 Message-ID: Subject: Re: [PATCH] mm: hugetlb: checking for IS_ERR() instead of NULL To: Dan Carpenter Cc: Mike Kravetz , Andrew Morton , Stephen Rothwell , Linux-MM , open list , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 7537920010A0 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=kQ06Qptl; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of almasrymina@google.com designates 209.85.215.182 as permitted sender) smtp.mailfrom=almasrymina@google.com X-Rspamd-Server: rspam03 X-Stat-Signature: fi4n4njtg8dchegyh449biri936fwnf9 X-HE-Tag: 1622544759-643416 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 1, 2021 at 2:26 AM Dan Carpenter wrote: > > The alloc_migrate_huge_page() doesn't return error pointers, it returns > NULL. > > Fixes: ab45bc8b5910 ("mm, hugetlb: fix resv_huge_pages underflow on UFFDIO_COPY") > Signed-off-by: Dan Carpenter > --- > mm/hugetlb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Gah, my bad. Reviewed-by: Mina Almasry > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 69a4b551c157..3221c94b4749 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -5103,7 +5103,7 @@ int hugetlb_mcopy_atomic_pte(struct mm_struct *dst_mm, > */ > page = alloc_migrate_huge_page(h, gfp_mask, node, > nodemask); > - if (IS_ERR(page)) { > + if (!page) { > ret = -ENOMEM; > goto out; > } > -- > 2.30.2 >