From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46988C07E9C for ; Mon, 12 Jul 2021 19:32:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 284576120A for ; Mon, 12 Jul 2021 19:32:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236453AbhGLTfp (ORCPT ); Mon, 12 Jul 2021 15:35:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234306AbhGLTfo (ORCPT ); Mon, 12 Jul 2021 15:35:44 -0400 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A3C7C0613DD for ; Mon, 12 Jul 2021 12:32:56 -0700 (PDT) Received: by mail-pf1-x42c.google.com with SMTP id a127so17364761pfa.10 for ; Mon, 12 Jul 2021 12:32:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=biBvoLhNGtX6R6KSS5eeNClmIVIiyb/IBsq6BVCuJzE=; b=R/P+hxOwSNm+AWShZrzPf5OTy01ZvqCcvpnhwFIOSmWQO9gUSGgZOgab3InxdjfuWT JLB8gUJFUhikwtz+J9F/7c0Kso/s4tCB9cp1kT5Ei+0rI1Yh+d12wJ5e7v0WBFCots3A AWa8BTmz1NyERVEHJz8DLBexKy6gt85lTBCGhoQKUH1FuSlmVbpNgQzGSDOqbX7zwhJh dqexlt8a9soXI1IHGoQ5oN8KjfsdcX8efymIhUgcnwjanuTiqTcRXUOKnuCr9GWo6eZk XqSqyhUd9IKnBmAIJtC31JQXYz0nBBwZy0wEg8urQPEJAgMHlpW2/0D/8Juw9UAckP7f dbWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=biBvoLhNGtX6R6KSS5eeNClmIVIiyb/IBsq6BVCuJzE=; b=aJxAzQwQUdWwnZo74BTS4Pe+0+le7JeRbJHskWHibdsXM24+i8NTVtD40BmfNjb28R K6JzkQ81/L2hkxIjYkJn6+j76BKoiXVqBJbfhKnvV9RlZpAseHKntgw3DRtW2mNlHYpV SnokRejC7HBTX5N7t0XQyjCk5vU83Qt01FF3f2otaveHnZ4n9L+E+nFuIzyD5iR/+pS9 qfXONj3twVpPWouhFoIp0sjH8mvfRmf1K87ilafBLSssKqp/HRdYrYw0tThwt4YXkxoB Ec4gItsAF6EFbSYWJX4hXTeCKaXs9zG8iavAST3XzwMApdNP+6+l+7jOR/OaGwmXz76J dYhg== X-Gm-Message-State: AOAM531DTFiarXO+HoD2U0KZfZV6E7P0VSFREeoj13OEYdxoSzJ5tDAL eERTw17Smi+XOg6WROJT/9EamflMl69t7OFiewpcZA== X-Google-Smtp-Source: ABdhPJydReQltwH7zpq2+GDfb8NFl3MD+iNG/25G17yQ9cx34L0AHJ4b1oCbjPdcknQgNR3JJ5oB7Z4IusWx7vqKE6I= X-Received: by 2002:a65:6659:: with SMTP id z25mr629389pgv.291.1626118375545; Mon, 12 Jul 2021 12:32:55 -0700 (PDT) MIME-Version: 1.0 References: <20210712153207.39302-1-willy@infradead.org> <9877bef9-b2e8-6a8c-4d68-7df7f3fb71eb@oracle.com> In-Reply-To: <9877bef9-b2e8-6a8c-4d68-7df7f3fb71eb@oracle.com> From: Mina Almasry Date: Mon, 12 Jul 2021 12:32:44 -0700 Message-ID: Subject: Re: [PATCH] mm: Make copy_huge_page() always available To: Mike Kravetz Cc: "Matthew Wilcox (Oracle)" , YueHaibing , Axel Rasmussen , Peter Xu , Andrew Morton , Linus Torvalds , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 12, 2021 at 10:52 AM Mike Kravetz wrote: > > On 7/12/21 8:32 AM, Matthew Wilcox (Oracle) wrote: > > Rewrite copy_huge_page() and move it into mm/util.c so it's always > > available. Fixes an exposure of uninitialised memory on configurations > > with HUGETLB and UFFD enabled and MIGRATION disabled. > > > > Fixes: 8cc5fcbb5be8 ("mm, hugetlb: fix racy resv_huge_pages underflow on UFFDIO_COPY") > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-By: Mina Almasry > > --- > > include/linux/migrate.h | 5 ----- > > include/linux/mm.h | 1 + > > mm/migrate.c | 48 ----------------------------------------- > > mm/util.c | 10 +++++++++ > > 4 files changed, 11 insertions(+), 53 deletions(-) > > Thanks Matthew, > > Reviewed-by: Mike Kravetz > -- > Mike Kravetz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B33BC07E99 for ; Mon, 12 Jul 2021 19:32:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CAF6861006 for ; Mon, 12 Jul 2021 19:32:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CAF6861006 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EC8456B0011; Mon, 12 Jul 2021 15:32:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E51586B0073; Mon, 12 Jul 2021 15:32:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCA726B0095; Mon, 12 Jul 2021 15:32:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0242.hostedemail.com [216.40.44.242]) by kanga.kvack.org (Postfix) with ESMTP id A11CF6B0011 for ; Mon, 12 Jul 2021 15:32:57 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B5CF2274AE for ; Mon, 12 Jul 2021 19:32:56 +0000 (UTC) X-FDA: 78354933552.12.DEB8443 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by imf19.hostedemail.com (Postfix) with ESMTP id 7E492B000199 for ; Mon, 12 Jul 2021 19:32:56 +0000 (UTC) Received: by mail-pg1-f177.google.com with SMTP id 37so19375734pgq.0 for ; Mon, 12 Jul 2021 12:32:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=biBvoLhNGtX6R6KSS5eeNClmIVIiyb/IBsq6BVCuJzE=; b=R/P+hxOwSNm+AWShZrzPf5OTy01ZvqCcvpnhwFIOSmWQO9gUSGgZOgab3InxdjfuWT JLB8gUJFUhikwtz+J9F/7c0Kso/s4tCB9cp1kT5Ei+0rI1Yh+d12wJ5e7v0WBFCots3A AWa8BTmz1NyERVEHJz8DLBexKy6gt85lTBCGhoQKUH1FuSlmVbpNgQzGSDOqbX7zwhJh dqexlt8a9soXI1IHGoQ5oN8KjfsdcX8efymIhUgcnwjanuTiqTcRXUOKnuCr9GWo6eZk XqSqyhUd9IKnBmAIJtC31JQXYz0nBBwZy0wEg8urQPEJAgMHlpW2/0D/8Juw9UAckP7f dbWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=biBvoLhNGtX6R6KSS5eeNClmIVIiyb/IBsq6BVCuJzE=; b=HG5rOK51fNi/YSQZImlcxukCllzymejbRD7vYjycgAMjd5HsV+wZQV4a9ee4AIJAEw 9Pd6CefS5frRCCvgvxzF/0voFnoBwfgju2Hpzbm/OaSqVysdSBeEVqKKfkKUGF8004kk aS8oCco1aS4ncz1uJok4oRGCdVgVDHvfEbaFsCBnlMd47lbP08w4p/aNTyjtHlZSk+nj nDShP54Lp/LKF2DU/hRgHA7ELoUTplPyP4BJkOyxsI0IjnYt0dtQGvR1cFfZLgfJQlAN gxAiUSoZ0ANNewJNvqSDbZeIUj9BF0H8ayZ5Wz9RyiYDzZMwdqiIOIkLgOs0sqZrCl+p 5Y3A== X-Gm-Message-State: AOAM533ul6jTiGoaHUzN+tfJ+VJlw+2QaDjwKf1ONlgfYlzwuA914Dxr iztrdMtLR+BRC5KOGTxM5LmpDwV+5jZoNInwwJR4pw== X-Google-Smtp-Source: ABdhPJydReQltwH7zpq2+GDfb8NFl3MD+iNG/25G17yQ9cx34L0AHJ4b1oCbjPdcknQgNR3JJ5oB7Z4IusWx7vqKE6I= X-Received: by 2002:a65:6659:: with SMTP id z25mr629389pgv.291.1626118375545; Mon, 12 Jul 2021 12:32:55 -0700 (PDT) MIME-Version: 1.0 References: <20210712153207.39302-1-willy@infradead.org> <9877bef9-b2e8-6a8c-4d68-7df7f3fb71eb@oracle.com> In-Reply-To: <9877bef9-b2e8-6a8c-4d68-7df7f3fb71eb@oracle.com> From: Mina Almasry Date: Mon, 12 Jul 2021 12:32:44 -0700 Message-ID: Subject: Re: [PATCH] mm: Make copy_huge_page() always available To: Mike Kravetz Cc: "Matthew Wilcox (Oracle)" , YueHaibing , Axel Rasmussen , Peter Xu , Andrew Morton , Linus Torvalds , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 7E492B000199 X-Stat-Signature: rq1k7ch7sbxhqife67dg9cwkiuouht56 Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b="R/P+hxOw"; spf=pass (imf19.hostedemail.com: domain of almasrymina@google.com designates 209.85.215.177 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1626118376-979881 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 12, 2021 at 10:52 AM Mike Kravetz wrote: > > On 7/12/21 8:32 AM, Matthew Wilcox (Oracle) wrote: > > Rewrite copy_huge_page() and move it into mm/util.c so it's always > > available. Fixes an exposure of uninitialised memory on configurations > > with HUGETLB and UFFD enabled and MIGRATION disabled. > > > > Fixes: 8cc5fcbb5be8 ("mm, hugetlb: fix racy resv_huge_pages underflow on UFFDIO_COPY") > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-By: Mina Almasry > > --- > > include/linux/migrate.h | 5 ----- > > include/linux/mm.h | 1 + > > mm/migrate.c | 48 ----------------------------------------- > > mm/util.c | 10 +++++++++ > > 4 files changed, 11 insertions(+), 53 deletions(-) > > Thanks Matthew, > > Reviewed-by: Mike Kravetz > -- > Mike Kravetz