From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 204A3C4338F for ; Mon, 26 Jul 2021 07:26:24 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4764D60560 for ; Mon, 26 Jul 2021 07:26:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4764D60560 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monstr.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 46809832C8; Mon, 26 Jul 2021 09:26:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=monstr.eu Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=monstr-eu.20150623.gappssmtp.com header.i=@monstr-eu.20150623.gappssmtp.com header.b="Z7st5kYA"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5C231832CE; Mon, 26 Jul 2021 09:26:19 +0200 (CEST) Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5C9F0832C0 for ; Mon, 26 Jul 2021 09:26:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=monstr.eu Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=monstr@monstr.eu Received: by mail-ej1-x632.google.com with SMTP id gn26so8868245ejc.3 for ; Mon, 26 Jul 2021 00:26:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=0pMZVXhYj6AOr7UwOypTLTVl8YS82i7EaxwwcoWTsRA=; b=Z7st5kYAZ2Fui42nPn0EEleO/h5EtYkdRqdaforP611KaB/eAAAzkpXq6msVTnN/ew ZCmLHLgxPNjIBJAG5rMnMWhBSXnBesYYmq8GYFwXQlcAw+aUNKVIpumsVZq761r3p1VE SrN8xjNc/C7DHHjiCIcDuPaM3q/C/2rsTPqagK397GkoRXu4vuNSR6/1QgRAfwjXTLji Qg8gm3MiCFOoq2g/DAU9zVMWGqRLh7+6PwqTrqTM4XzLkoAHuQjUr+mcocCZil5ZoOsb kWTdAxp6eroRaONlHHrHpHzT3sSqNgPBv5CgXRYY3MkSC8zvcfTZ9lJC36Ygz6Zpqcla 54zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=0pMZVXhYj6AOr7UwOypTLTVl8YS82i7EaxwwcoWTsRA=; b=WxP504N48+C7VlfdVbTZWhqoY6JUeBQFHvGPnWv26zjydwslB5LPBhUrBOf1g3xyvz MtWKCPiOCUfAEx8nGavWSZWsadK+AVAVnlzsF8H6O4jflbBO8rtMluncmjeV6DuhDqqa 5znBVj+Io8W5H+1JyxTZ1WOC8Wf0kEAn52p6rOIp4oye+tJqCWc0eKt9ieLJtvupG/Y/ EP3pxFdIy0iQIo/Bm5nKEiVYpdsEI4OiTz1+PISynj8ZiFj1E4w10CPz6/7Bsiph4K8x 83Rxn8vFpZTDNDSOW0ugLCwGBrgk4j1gy2zU4LCyPtGg7h8BL5XSL17UK0oG7xaXLAQA wltw== X-Gm-Message-State: AOAM532xoJHv3QYvvU0nwDzfO9NlVbyJ7BnwWXP1v2qLukm8T9owXtAt gIrHw98bRgFuqsxN1Xp1DbQp6XCCTlTjPFFl22rXmY3qiL7j4cB0 X-Google-Smtp-Source: ABdhPJwv2sPGiUONoQVLm3nzBh730SE/I7vKjrTNhHqaok5Wyg6O9spuORghksbWw58JBal1xagfruIoxtBE7RGKMAo= X-Received: by 2002:a17:906:7393:: with SMTP id f19mr5752048ejl.79.1627284374895; Mon, 26 Jul 2021 00:26:14 -0700 (PDT) MIME-Version: 1.0 References: <0aed2fd9419e22448bfc9d88466eb51b7d684c70.1626694258.git.michal.simek@xilinx.com> In-Reply-To: <0aed2fd9419e22448bfc9d88466eb51b7d684c70.1626694258.git.michal.simek@xilinx.com> From: Michal Simek Date: Mon, 26 Jul 2021 09:26:04 +0200 Message-ID: Subject: Re: [PATCH] arm64: zynqmp: Move USB3 PHY properties from DWC3 node to USB node To: U-Boot , git Cc: Manish Narani Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean po 19. 7. 2021 v 13:31 odes=C3=ADlatel Michal Simek napsal: > > From: Manish Narani > > Move the PHY properties from DWC3 node to USB node in ZynqMP DTs as here > the USB3 PHY used is PSGTR, which is connected to Xilinx USB core. This > PHY initialization should be handled from Xilinx USB core as the > prerequisite register configurations are done here only. > > Signed-off-by: Manish Narani > Signed-off-by: Michal Simek > --- > > arch/arm/dts/zynqmp-p-a2197-00-revA.dts | 4 ++-- > arch/arm/dts/zynqmp-sck-kv-g-revA.dts | 4 ++-- > arch/arm/dts/zynqmp-sck-kv-g-revB.dts | 4 ++-- > arch/arm/dts/zynqmp-zc1751-xm015-dc1.dts | 4 ++-- > arch/arm/dts/zynqmp-zc1751-xm017-dc3.dts | 8 ++++---- > arch/arm/dts/zynqmp-zcu100-revC.dts | 8 ++++---- > arch/arm/dts/zynqmp-zcu102-revA.dts | 4 ++-- > arch/arm/dts/zynqmp-zcu104-revA.dts | 4 ++-- > arch/arm/dts/zynqmp-zcu104-revC.dts | 4 ++-- > arch/arm/dts/zynqmp-zcu106-revA.dts | 4 ++-- > arch/arm/dts/zynqmp-zcu111-revA.dts | 4 ++-- > arch/arm/dts/zynqmp-zcu208-revA.dts | 4 ++-- > arch/arm/dts/zynqmp-zcu216-revA.dts | 4 ++-- > 13 files changed, 30 insertions(+), 30 deletions(-) > > diff --git a/arch/arm/dts/zynqmp-p-a2197-00-revA.dts b/arch/arm/dts/zynqm= p-p-a2197-00-revA.dts > index d50b335e674d..c893aaaafd8f 100644 > --- a/arch/arm/dts/zynqmp-p-a2197-00-revA.dts > +++ b/arch/arm/dts/zynqmp-p-a2197-00-revA.dts > @@ -545,6 +545,8 @@ > status =3D "okay"; > xlnx,usb-polarity =3D <0>; > xlnx,usb-reset-mode =3D <0>; > + phy-names =3D "usb3-phy"; > + phys =3D <&psgtr 1 PHY_TYPE_USB3 0 1>; > }; > > &dwc3_0 { > @@ -553,8 +555,6 @@ > snps,dis_u2_susphy_quirk; > snps,dis_u3_susphy_quirk; > maximum-speed =3D "super-speed"; > - phy-names =3D "usb3-phy"; > - phys =3D <&psgtr 1 PHY_TYPE_USB3 0 1>; > }; > > &usb1 { > diff --git a/arch/arm/dts/zynqmp-sck-kv-g-revA.dts b/arch/arm/dts/zynqmp-= sck-kv-g-revA.dts > index 59d5751e0634..4e8086c82f23 100644 > --- a/arch/arm/dts/zynqmp-sck-kv-g-revA.dts > +++ b/arch/arm/dts/zynqmp-sck-kv-g-revA.dts > @@ -125,6 +125,8 @@ > status =3D "okay"; > pinctrl-names =3D "default"; > pinctrl-0 =3D <&pinctrl_usb0_default>; > + phy-names =3D "usb3-phy"; > + phys =3D <&psgtr 2 PHY_TYPE_USB3 0 1>; > usbhub: usb5744 { /* u43 */ > compatible =3D "microchip,usb5744"; > reset-gpios =3D <&gpio 44 GPIO_ACTIVE_HIGH>; > @@ -135,8 +137,6 @@ > status =3D "okay"; > dr_mode =3D "host"; > snps,usb3_lpm_capable; > - phy-names =3D "usb3-phy"; > - phys =3D <&psgtr 2 PHY_TYPE_USB3 0 1>; > maximum-speed =3D "super-speed"; > }; > > diff --git a/arch/arm/dts/zynqmp-sck-kv-g-revB.dts b/arch/arm/dts/zynqmp-= sck-kv-g-revB.dts > index b5443afff982..048d5665c57b 100644 > --- a/arch/arm/dts/zynqmp-sck-kv-g-revB.dts > +++ b/arch/arm/dts/zynqmp-sck-kv-g-revB.dts > @@ -109,14 +109,14 @@ > status =3D "okay"; > pinctrl-names =3D "default"; > pinctrl-0 =3D <&pinctrl_usb0_default>; > + phy-names =3D "usb3-phy"; > + phys =3D <&psgtr 2 PHY_TYPE_USB3 0 1>; > }; > > &dwc3_0 { > status =3D "okay"; > dr_mode =3D "host"; > snps,usb3_lpm_capable; > - phy-names =3D "usb3-phy"; > - phys =3D <&psgtr 2 PHY_TYPE_USB3 0 1>; > maximum-speed =3D "super-speed"; > }; > > diff --git a/arch/arm/dts/zynqmp-zc1751-xm015-dc1.dts b/arch/arm/dts/zynq= mp-zc1751-xm015-dc1.dts > index b92a2ee3e60a..4a87bd6a6aaf 100644 > --- a/arch/arm/dts/zynqmp-zc1751-xm015-dc1.dts > +++ b/arch/arm/dts/zynqmp-zc1751-xm015-dc1.dts > @@ -424,14 +424,14 @@ > status =3D "okay"; > pinctrl-names =3D "default"; > pinctrl-0 =3D <&pinctrl_usb0_default>; > + phy-names =3D "usb3-phy"; > + phys =3D <&psgtr 2 PHY_TYPE_USB3 0 2>; > }; > > &dwc3_0 { > status =3D "okay"; > dr_mode =3D "host"; > snps,usb3_lpm_capable; > - phy-names =3D "usb3-phy"; > - phys =3D <&psgtr 2 PHY_TYPE_USB3 0 2>; > maximum-speed =3D "super-speed"; > }; > > diff --git a/arch/arm/dts/zynqmp-zc1751-xm017-dc3.dts b/arch/arm/dts/zynq= mp-zc1751-xm017-dc3.dts > index 344323ab7f93..13812470ae34 100644 > --- a/arch/arm/dts/zynqmp-zc1751-xm017-dc3.dts > +++ b/arch/arm/dts/zynqmp-zc1751-xm017-dc3.dts > @@ -221,27 +221,27 @@ > > &usb0 { > status =3D "okay"; > + phy-names =3D "usb3-phy"; > + phys =3D <&psgtr 0 PHY_TYPE_USB3 0 2>; > }; > > &dwc3_0 { > status =3D "okay"; > dr_mode =3D "host"; > snps,usb3_lpm_capable; > - phy-names =3D "usb3-phy"; > - phys =3D <&psgtr 0 PHY_TYPE_USB3 0 2>; > maximum-speed =3D "super-speed"; > }; > > /* ULPI SMSC USB3320 */ > &usb1 { > status =3D "okay"; > + phy-names =3D "usb3-phy"; > + phys =3D <&psgtr 3 PHY_TYPE_USB3 1 2>; > }; > > &dwc3_1 { > status =3D "okay"; > dr_mode =3D "host"; > snps,usb3_lpm_capable; > - phy-names =3D "usb3-phy"; > - phys =3D <&psgtr 3 PHY_TYPE_USB3 1 2>; > maximum-speed =3D "super-speed"; > }; > diff --git a/arch/arm/dts/zynqmp-zcu100-revC.dts b/arch/arm/dts/zynqmp-zc= u100-revC.dts > index 2d615774782f..ea630a43dc7f 100644 > --- a/arch/arm/dts/zynqmp-zcu100-revC.dts > +++ b/arch/arm/dts/zynqmp-zcu100-revC.dts > @@ -561,13 +561,13 @@ > status =3D "okay"; > pinctrl-names =3D "default"; > pinctrl-0 =3D <&pinctrl_usb0_default>; > + phy-names =3D "usb3-phy"; > + phys =3D <&psgtr 2 PHY_TYPE_USB3 0 0>; > }; > > &dwc3_0 { > status =3D "okay"; > dr_mode =3D "peripheral"; > - phy-names =3D "usb3-phy"; > - phys =3D <&psgtr 2 PHY_TYPE_USB3 0 0>; > maximum-speed =3D "super-speed"; > }; > > @@ -576,13 +576,13 @@ > status =3D "okay"; > pinctrl-names =3D "default"; > pinctrl-0 =3D <&pinctrl_usb1_default>; > + phy-names =3D "usb3-phy"; > + phys =3D <&psgtr 3 PHY_TYPE_USB3 1 0>; > }; > > &dwc3_1 { > status =3D "okay"; > dr_mode =3D "host"; > - phy-names =3D "usb3-phy"; > - phys =3D <&psgtr 3 PHY_TYPE_USB3 1 0>; > maximum-speed =3D "super-speed"; > }; > > diff --git a/arch/arm/dts/zynqmp-zcu102-revA.dts b/arch/arm/dts/zynqmp-zc= u102-revA.dts > index 1d4a9cdc69f0..175252d2def2 100644 > --- a/arch/arm/dts/zynqmp-zcu102-revA.dts > +++ b/arch/arm/dts/zynqmp-zcu102-revA.dts > @@ -1035,14 +1035,14 @@ > status =3D "okay"; > pinctrl-names =3D "default"; > pinctrl-0 =3D <&pinctrl_usb0_default>; > + phy-names =3D "usb3-phy"; > + phys =3D <&psgtr 2 PHY_TYPE_USB3 0 2>; > }; > > &dwc3_0 { > status =3D "okay"; > dr_mode =3D "host"; > snps,usb3_lpm_capable; > - phy-names =3D "usb3-phy"; > - phys =3D <&psgtr 2 PHY_TYPE_USB3 0 2>; > maximum-speed =3D "super-speed"; > }; > > diff --git a/arch/arm/dts/zynqmp-zcu104-revA.dts b/arch/arm/dts/zynqmp-zc= u104-revA.dts > index 7e5eca82fdaa..9cd30447eb3e 100644 > --- a/arch/arm/dts/zynqmp-zcu104-revA.dts > +++ b/arch/arm/dts/zynqmp-zcu104-revA.dts > @@ -502,14 +502,14 @@ > status =3D "okay"; > pinctrl-names =3D "default"; > pinctrl-0 =3D <&pinctrl_usb0_default>; > + phy-names =3D "usb3-phy"; > + phys =3D <&psgtr 2 PHY_TYPE_USB3 0 2>; > }; > > &dwc3_0 { > status =3D "okay"; > dr_mode =3D "host"; > snps,usb3_lpm_capable; > - phy-names =3D "usb3-phy"; > - phys =3D <&psgtr 2 PHY_TYPE_USB3 0 2>; > maximum-speed =3D "super-speed"; > }; > > diff --git a/arch/arm/dts/zynqmp-zcu104-revC.dts b/arch/arm/dts/zynqmp-zc= u104-revC.dts > index f4ebcbb318b4..45191569c101 100644 > --- a/arch/arm/dts/zynqmp-zcu104-revC.dts > +++ b/arch/arm/dts/zynqmp-zcu104-revC.dts > @@ -514,14 +514,14 @@ > status =3D "okay"; > pinctrl-names =3D "default"; > pinctrl-0 =3D <&pinctrl_usb0_default>; > + phy-names =3D "usb3-phy"; > + phys =3D <&psgtr 2 PHY_TYPE_USB3 0 2>; > }; > > &dwc3_0 { > status =3D "okay"; > dr_mode =3D "host"; > snps,usb3_lpm_capable; > - phy-names =3D "usb3-phy"; > - phys =3D <&psgtr 2 PHY_TYPE_USB3 0 2>; > maximum-speed =3D "super-speed"; > }; > > diff --git a/arch/arm/dts/zynqmp-zcu106-revA.dts b/arch/arm/dts/zynqmp-zc= u106-revA.dts > index ac6689c16730..50cc72eb9240 100644 > --- a/arch/arm/dts/zynqmp-zcu106-revA.dts > +++ b/arch/arm/dts/zynqmp-zcu106-revA.dts > @@ -1012,14 +1012,14 @@ > status =3D "okay"; > pinctrl-names =3D "default"; > pinctrl-0 =3D <&pinctrl_usb0_default>; > + phy-names =3D "usb3-phy"; > + phys =3D <&psgtr 2 PHY_TYPE_USB3 0 2>; > }; > > &dwc3_0 { > status =3D "okay"; > dr_mode =3D "host"; > snps,usb3_lpm_capable; > - phy-names =3D "usb3-phy"; > - phys =3D <&psgtr 2 PHY_TYPE_USB3 0 2>; > maximum-speed =3D "super-speed"; > }; > > diff --git a/arch/arm/dts/zynqmp-zcu111-revA.dts b/arch/arm/dts/zynqmp-zc= u111-revA.dts > index 8d57ca2b3bf3..2b15ce1ea847 100644 > --- a/arch/arm/dts/zynqmp-zcu111-revA.dts > +++ b/arch/arm/dts/zynqmp-zcu111-revA.dts > @@ -849,14 +849,14 @@ > status =3D "okay"; > pinctrl-names =3D "default"; > pinctrl-0 =3D <&pinctrl_usb0_default>; > + phy-names =3D "usb3-phy"; > + phys =3D <&psgtr 2 PHY_TYPE_USB3 0 2>; > }; > > &dwc3_0 { > status =3D "okay"; > dr_mode =3D "host"; > snps,usb3_lpm_capable; > - phy-names =3D "usb3-phy"; > - phys =3D <&psgtr 2 PHY_TYPE_USB3 0 2>; > maximum-speed =3D "super-speed"; > }; > > diff --git a/arch/arm/dts/zynqmp-zcu208-revA.dts b/arch/arm/dts/zynqmp-zc= u208-revA.dts > index d3e20ae85d7e..32a6e6fb55e2 100644 > --- a/arch/arm/dts/zynqmp-zcu208-revA.dts > +++ b/arch/arm/dts/zynqmp-zcu208-revA.dts > @@ -692,13 +692,13 @@ > /* ULPI SMSC USB3320 */ > &usb0 { > status =3D "okay"; > + phy-names =3D "usb3-phy"; > + phys =3D <&psgtr 2 PHY_TYPE_USB3 0 2>; > }; > > &dwc3_0 { > status =3D "okay"; > dr_mode =3D "host"; > snps,usb3_lpm_capable; > - phy-names =3D "usb3-phy"; > - phys =3D <&psgtr 2 PHY_TYPE_USB3 0 2>; > maximum-speed =3D "super-speed"; > }; > diff --git a/arch/arm/dts/zynqmp-zcu216-revA.dts b/arch/arm/dts/zynqmp-zc= u216-revA.dts > index ae7c18196894..1e347036d0a7 100644 > --- a/arch/arm/dts/zynqmp-zcu216-revA.dts > +++ b/arch/arm/dts/zynqmp-zcu216-revA.dts > @@ -696,13 +696,13 @@ > /* ULPI SMSC USB3320 */ > &usb0 { > status =3D "okay"; > + phy-names =3D "usb3-phy"; > + phys =3D <&psgtr 2 PHY_TYPE_USB3 0 2>; > }; > > &dwc3_0 { > status =3D "okay"; > dr_mode =3D "host"; > snps,usb3_lpm_capable; > - phy-names =3D "usb3-phy"; > - phys =3D <&psgtr 2 PHY_TYPE_USB3 0 2>; > maximum-speed =3D "super-speed"; > }; > -- > 2.32.0 > Applied. M --=20 Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs