From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 References: <20181029094245.7886-1-manivannan.sadhasivam@linaro.org> In-Reply-To: From: Michal Simek Date: Wed, 31 Oct 2018 16:46:48 +0100 Message-ID: Subject: Re: [PATCH v3 0/7] Standardize onboard LED support for 96Boards Content-Type: multipart/alternative; boundary="000000000000884fd40579883608" To: Linus Walleij Cc: Manivannan Sadhasivam , Rob Herring , Daniel Thompson , =?UTF-8?Q?Heiko_St=C3=BCbner?= , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, xuwei5@hisilicon.com, LKML , linux-rockchip@lists.infradead.org, nicolas.dechesne@linaro.org, koen.kooi@linaro.org, linux-arm , Pavel Machek , Andy Gross , Amit Kucheria , ezequiel@collabora.com, linux-leds@vger.kernel.org List-ID: --000000000000884fd40579883608 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, st 31. 10. 2018 v 14:39 odes=C3=ADlatel Linus Walleij napsal: > On Mon, Oct 29, 2018 at 10:43 AM Manivannan Sadhasivam > wrote: > > > This patchset standardizes the onboard LEDs on 96Boards by maintaining > > common labels and triggers as below: > > > > green:user1 default-trigger: heartbeat > > green:user2 default-trigger: mmc0/disk-activity (onboard-storage) > > green:user3 default-trigger: mmc1 (SD card) > > green:user4 default-trigger: none, panic-indicator > > yellow:wlan default-trigger: phy0tx > > blue:bt default-trigger: hci0-power > > > > This standardization is required to provide a common behaviour of LEDs > > across all mainline supported 96Boards and also making it easier to > > control it using an userspace library like MRAA. > > > > For Rock960 and Ficus boards, the LED support is added in this patchset= . > > Rest of the boards are converted to adopt the standard. > > > > Note: Since there is no UFS trigger available for now, user2 LED trigge= r > > is set to none on HiKey960. > > This series: > Reviewed-by: Linus Walleij > > It makes a lot of sense to try to unify the userspace ABI so we get > some kind of order here instead of trying to counteract it with > per-device kludges in userspace. It definately makes things better! > No doubt about it that this is good. If this is there from day 1 all will be good. I am just saying that we are all the time saying that we shouldn't break userspace. Right now if there is single application which uses existing names we are breaking it. Thanks, Michal --- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform --000000000000884fd40579883608 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

st 31. 10. 2018 v=C2=A014:39 odes=C3=ADlatel Linus Walleij <linus.walleij@linaro.org> napsal:<= br>
On Mon, Oct 29, 2018 at 10:43 AM Ma= nivannan Sadhasivam
<m= anivannan.sadhasivam@linaro.org> wrote:

> This patchset standardizes the onboard LEDs on 96Boards by maintaining=
> common labels and triggers as below:
>
> green:user1=C2=A0 default-trigger: heartbeat
> green:user2=C2=A0 default-trigger: mmc0/disk-activity (onboard-storage= )
> green:user3=C2=A0 default-trigger: mmc1 (SD card)
> green:user4=C2=A0 default-trigger: none, panic-indicator
> yellow:wlan=C2=A0 default-trigger: phy0tx
> blue:bt=C2=A0 =C2=A0 =C2=A0 default-trigger: hci0-power
>
> This standardization is required to provide a common behaviour of LEDs=
> across all mainline supported 96Boards and also making it easier to > control it using an userspace library like MRAA.
>
> For Rock960 and Ficus boards, the LED support is added in this patchse= t.
> Rest of the boards are converted to adopt the standard.
>
> Note: Since there is no UFS trigger available for now, user2 LED trigg= er
> is set to none on HiKey960.

This series:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

It makes a lot of sense to try to unify the userspace ABI so we get
some kind of order here instead of trying to counteract it with
per-device kludges in userspace. It definately makes things better!

No doubt about it that this is goo= d. If this is there from day 1 all will be good.
I am just sayin= g that we are all the time
saying that we shouldn't break use= rspace. Right now if there is single application
which uses exist= ing names we are breaking it.

Thanks,
Mi= chal



---
M= ichal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854=
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer = of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodi= an and responsible for u-boot arm zynq platform
--000000000000884fd40579883608--