From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94F6CC48BE5 for ; Wed, 23 Jun 2021 08:57:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F41F611CE for ; Wed, 23 Jun 2021 08:57:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230135AbhFWJAH (ORCPT ); Wed, 23 Jun 2021 05:00:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230157AbhFWJAG (ORCPT ); Wed, 23 Jun 2021 05:00:06 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CC21C06175F for ; Wed, 23 Jun 2021 01:57:48 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id my49so2825856ejc.7 for ; Wed, 23 Jun 2021 01:57:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Z6Z3rnoFwy3s+OnHi/sH1rvXTGduUYkOOkAbeaIPw4Q=; b=tdK9uAJWdmT+cTqTX4ozHwlgRi7wW7OUcIGpx+5Br2fodFNa+MnfUQZVAzgz1DMfXp n/6yy9sAzllko9mIwsv87gD1kCOH5+UvzuTO8Ov4YmQvbrKg9vhNxEnX9Bb3xpiNP2fH k9Oyze3A8ShMVN/bVHL82sBkwKgirt++Dw9dhx7H9AShjZynKsDqAx3QjkNyy+S3seYa O7aOzg7Mj0Cm2KxHYiHvi5dJSHR99JkBwPvAeetXr4PIjVliCzIaKYRVlGsyYaoAOytV AXOwIKzGUy2+Qw0GsQqKp2vE+Hbxv9yib/h1U+C6vqKY5DAWNhTnHvHGn5ed0S9mxQ6J iM2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Z6Z3rnoFwy3s+OnHi/sH1rvXTGduUYkOOkAbeaIPw4Q=; b=AHs5tXp39nKifgzidfKTYRlRBr4/SzolQpYVBg1OCLTG/Q0cuXEIU9I9hocX+aVHrz YGRGEkaOcktEOCYXcDU9VZKmeyErpxgLK9q/zPmXslfSH1aRsvJosBbQMNLkSD9Rsaki E47BM/c7m8sP5kavG/Wq7ss8XytPZnCL3bKRqMUdSjG5gcYIWftb8QkcIg8pESsOKwkp YSe0mrQDS4lDqP/DrrWMT+PL/OEuRuKgLsS3UIgVeiXVWjZdLmmF0H4OtFGuFsbkWJ6t smEr3jKk37IVSJvrkKijDjdAXbgbsnEmQPDzO31CU6cWcXZ1x/R4A8dIGjonnbSUKgKe xdjg== X-Gm-Message-State: AOAM533HXclQ8eu0L/STe04om+ZPWRclsgPSLhLQXONLCVOhq2hJ92oX x8V75Omjq5P0cZkBmD/8lzFmgIt1IMHj4YdIXYDP0A== X-Google-Smtp-Source: ABdhPJwy+pM9oZ1iyRoxUOJy65b7IRacVpAEIpAEHz2ud7J2MhpMBy54g7b0sAw4obchFDygfdWC6jUFii9npycxr4w= X-Received: by 2002:a17:906:ca4a:: with SMTP id jx10mr8892678ejb.200.1624438666647; Wed, 23 Jun 2021 01:57:46 -0700 (PDT) MIME-Version: 1.0 References: <20200902150643.14839-1-krzk@kernel.org> <20200902150643.14839-2-krzk@kernel.org> In-Reply-To: <20200902150643.14839-2-krzk@kernel.org> From: Michal Simek Date: Wed, 23 Jun 2021 10:57:35 +0200 Message-ID: Subject: Re: [PATCH 2/9] i2c: xiic: Simplify with dev_err_probe() To: Krzysztof Kozlowski , Wolfram Sang Cc: Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Sekhar Nori , Bartosz Golaszewski , Oleksij Rempel , Pengutronix Kernel Team , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , Heiko Stuebner , Pierre-Yves MORDRET , Maxime Coquelin , Alexandre Torgue , Peter Rosin , Wolfram Sang , linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm , LKML , linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org st 2. 9. 2020 v 17:10 odes=C3=ADlatel Krzysztof Kozlowski = napsal: > > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and the error value gets printed. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/i2c/busses/i2c-xiic.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.= c > index 90c1c362394d..a97438f35c5d 100644 > --- a/drivers/i2c/busses/i2c-xiic.c > +++ b/drivers/i2c/busses/i2c-xiic.c > @@ -787,11 +787,10 @@ static int xiic_i2c_probe(struct platform_device *p= dev) > init_waitqueue_head(&i2c->wait); > > i2c->clk =3D devm_clk_get(&pdev->dev, NULL); > - if (IS_ERR(i2c->clk)) { > - if (PTR_ERR(i2c->clk) !=3D -EPROBE_DEFER) > - dev_err(&pdev->dev, "input clock not found.\n"); > - return PTR_ERR(i2c->clk); > - } > + if (IS_ERR(i2c->clk)) > + return dev_err_probe(&pdev->dev, PTR_ERR(i2c->clk), > + "input clock not found.\n"); > + > ret =3D clk_prepare_enable(i2c->clk); > if (ret) { > dev_err(&pdev->dev, "Unable to enable clock.\n"); > -- > 2.17.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel I see that this didn't go through. Acked-by: Michal Simek Wolfram: Can you please apply? Thanks, Michal --=20 Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7323C4743C for ; Wed, 23 Jun 2021 08:57:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B778611AD for ; Wed, 23 Jun 2021 08:57:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B778611AD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monstr.eu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2et1LaocPL5DG0h7UqfAQIwjHkhbUS8nPOUFArvmWpc=; b=EUhwonEZvVa/JV hKRL7xA98DpantAaZI0zIudVX0XDvfn7VeAZCcqFp0xlzKXN+m5HXMW0JC0TsaPTS8ISsRSfjou9l rNT5GQQdHOhVcVdP+2XHU3hB/A/ekOp1luu7ng4exTa3frev2a1bZRAu4SvCi/IH4UICJK5faDgNn aR5Z7uTE0ZQxjRs52A4LXjIGN+zFdtNYTLz7OYKD5+vG8moyH9xwIf/bJVvEHYdJbA0/E5gyUc+A0 NLHJDzXD6egl6y/cIse/U/5SxnfL72fGcvVC6Rlm3bCeGFh5IC29S+UGRHRPxYHoBveBG661cU/WK otZ7o6J3Ts60V4U/9cSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvyhj-00A0og-M1; Wed, 23 Jun 2021 08:57:51 +0000 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvyhg-00A0mo-5l for linux-rockchip@lists.infradead.org; Wed, 23 Jun 2021 08:57:50 +0000 Received: by mail-ej1-x630.google.com with SMTP id nd37so2862263ejc.3 for ; Wed, 23 Jun 2021 01:57:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Z6Z3rnoFwy3s+OnHi/sH1rvXTGduUYkOOkAbeaIPw4Q=; b=tdK9uAJWdmT+cTqTX4ozHwlgRi7wW7OUcIGpx+5Br2fodFNa+MnfUQZVAzgz1DMfXp n/6yy9sAzllko9mIwsv87gD1kCOH5+UvzuTO8Ov4YmQvbrKg9vhNxEnX9Bb3xpiNP2fH k9Oyze3A8ShMVN/bVHL82sBkwKgirt++Dw9dhx7H9AShjZynKsDqAx3QjkNyy+S3seYa O7aOzg7Mj0Cm2KxHYiHvi5dJSHR99JkBwPvAeetXr4PIjVliCzIaKYRVlGsyYaoAOytV AXOwIKzGUy2+Qw0GsQqKp2vE+Hbxv9yib/h1U+C6vqKY5DAWNhTnHvHGn5ed0S9mxQ6J iM2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Z6Z3rnoFwy3s+OnHi/sH1rvXTGduUYkOOkAbeaIPw4Q=; b=gfa05KM3UXslv1G8TmGScNRkQ+M5qvDsOLX+62x0c8TsWZXj24IgPhbi0tr907rNRC cQ4G4Dft4s3PVRKFTNCkfR1AcP4x7CK0f6y9q1Df+ou0LbL3ZD5x/Hl8UyUy2rrUjbty GwpjpJmQiUnHWQRfmU1XiGKClyUyX/QxD2ON5CjkohN/pdIQcSN8pqm70eezUypn7htq 2yYpoj99lPtTVyxJ0dWu307p3muuMFv806IMy2siQhTeWvcqRfDFZnXojphpDDY09W9g hqcQmLOnTKQzdfeoqYTPtqGtdiWGWrchM22/BN+jRgCVEHBgYzHJtv0xKn1H/jGFYjtW aGWA== X-Gm-Message-State: AOAM5325JhN1Rbb4K+TccPI/HKcIKxFRU/6hCRpJa0gryi/T6MIUDvWG 0jqY1BynBDnqrJPARN0KrLkpHIXUnFxJ5t1JLVb31Q== X-Google-Smtp-Source: ABdhPJwy+pM9oZ1iyRoxUOJy65b7IRacVpAEIpAEHz2ud7J2MhpMBy54g7b0sAw4obchFDygfdWC6jUFii9npycxr4w= X-Received: by 2002:a17:906:ca4a:: with SMTP id jx10mr8892678ejb.200.1624438666647; Wed, 23 Jun 2021 01:57:46 -0700 (PDT) MIME-Version: 1.0 References: <20200902150643.14839-1-krzk@kernel.org> <20200902150643.14839-2-krzk@kernel.org> In-Reply-To: <20200902150643.14839-2-krzk@kernel.org> From: Michal Simek Date: Wed, 23 Jun 2021 10:57:35 +0200 Message-ID: Subject: Re: [PATCH 2/9] i2c: xiic: Simplify with dev_err_probe() To: Krzysztof Kozlowski , Wolfram Sang Cc: Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Sekhar Nori , Bartosz Golaszewski , Oleksij Rempel , Pengutronix Kernel Team , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , Heiko Stuebner , Pierre-Yves MORDRET , Maxime Coquelin , Alexandre Torgue , Peter Rosin , Wolfram Sang , linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm , LKML , linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210623_015748_313303_0B58E847 X-CRM114-Status: GOOD ( 18.02 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org c3QgMi4gOS4gMjAyMCB2IDE3OjEwIG9kZXPDrWxhdGVsIEtyenlzenRvZiBLb3psb3dza2kgPGty emtAa2VybmVsLm9yZz4gbmFwc2FsOgo+Cj4gQ29tbW9uIHBhdHRlcm4gb2YgaGFuZGxpbmcgZGVm ZXJyZWQgcHJvYmUgY2FuIGJlIHNpbXBsaWZpZWQgd2l0aAo+IGRldl9lcnJfcHJvYmUoKS4gIExl c3MgY29kZSBhbmQgdGhlIGVycm9yIHZhbHVlIGdldHMgcHJpbnRlZC4KPgo+IFNpZ25lZC1vZmYt Ynk6IEtyenlzenRvZiBLb3psb3dza2kgPGtyemtAa2VybmVsLm9yZz4KPiAtLS0KPiAgZHJpdmVy cy9pMmMvYnVzc2VzL2kyYy14aWljLmMgfCA5ICsrKystLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwg NCBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv aTJjL2J1c3Nlcy9pMmMteGlpYy5jIGIvZHJpdmVycy9pMmMvYnVzc2VzL2kyYy14aWljLmMKPiBp bmRleCA5MGMxYzM2MjM5NGQuLmE5NzQzOGYzNWM1ZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2ky Yy9idXNzZXMvaTJjLXhpaWMuYwo+ICsrKyBiL2RyaXZlcnMvaTJjL2J1c3Nlcy9pMmMteGlpYy5j Cj4gQEAgLTc4NywxMSArNzg3LDEwIEBAIHN0YXRpYyBpbnQgeGlpY19pMmNfcHJvYmUoc3RydWN0 IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgICAgICAgIGluaXRfd2FpdHF1ZXVlX2hlYWQoJmky Yy0+d2FpdCk7Cj4KPiAgICAgICAgIGkyYy0+Y2xrID0gZGV2bV9jbGtfZ2V0KCZwZGV2LT5kZXYs IE5VTEwpOwo+IC0gICAgICAgaWYgKElTX0VSUihpMmMtPmNsaykpIHsKPiAtICAgICAgICAgICAg ICAgaWYgKFBUUl9FUlIoaTJjLT5jbGspICE9IC1FUFJPQkVfREVGRVIpCj4gLSAgICAgICAgICAg ICAgICAgICAgICAgZGV2X2VycigmcGRldi0+ZGV2LCAiaW5wdXQgY2xvY2sgbm90IGZvdW5kLlxu Iik7Cj4gLSAgICAgICAgICAgICAgIHJldHVybiBQVFJfRVJSKGkyYy0+Y2xrKTsKPiAtICAgICAg IH0KPiArICAgICAgIGlmIChJU19FUlIoaTJjLT5jbGspKQo+ICsgICAgICAgICAgICAgICByZXR1 cm4gZGV2X2Vycl9wcm9iZSgmcGRldi0+ZGV2LCBQVFJfRVJSKGkyYy0+Y2xrKSwKPiArICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgImlucHV0IGNsb2NrIG5vdCBmb3VuZC5cbiIp Owo+ICsKPiAgICAgICAgIHJldCA9IGNsa19wcmVwYXJlX2VuYWJsZShpMmMtPmNsayk7Cj4gICAg ICAgICBpZiAocmV0KSB7Cj4gICAgICAgICAgICAgICAgIGRldl9lcnIoJnBkZXYtPmRldiwgIlVu YWJsZSB0byBlbmFibGUgY2xvY2suXG4iKTsKPiAtLQo+IDIuMTcuMQo+Cj4KPiBfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGxpbnV4LWFybS1rZXJuZWwg bWFpbGluZyBsaXN0Cj4gbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCj4gaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs CgpJIHNlZSB0aGF0IHRoaXMgZGlkbid0IGdvIHRocm91Z2guCkFja2VkLWJ5OiBNaWNoYWwgU2lt ZWsgPG1pY2hhbC5zaW1la0B4aWxpbnguY29tPgoKV29sZnJhbTogQ2FuIHlvdSBwbGVhc2UgYXBw bHk/CgpUaGFua3MsCk1pY2hhbAoKCi0tIApNaWNoYWwgU2ltZWssIEluZy4gKE0uRW5nKSwgT3Bl blBHUCAtPiBLZXlJRDogRkUzRDFGOTEKdzogd3d3Lm1vbnN0ci5ldSBwOiArNDItMC03MjE4NDI4 NTQKTWFpbnRhaW5lciBvZiBMaW51eCBrZXJuZWwgLSBYaWxpbnggTWljcm9ibGF6ZQpNYWludGFp bmVyIG9mIExpbnV4IGtlcm5lbCAtIFhpbGlueCBaeW5xIEFSTSBhbmQgWnlucU1QIEFSTTY0IFNv Q3MKVS1Cb290IGN1c3RvZGlhbiAtIFhpbGlueCBNaWNyb2JsYXplL1p5bnEvWnlucU1QL1ZlcnNh bCBTb0NzCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpM aW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFk Lm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJv Y2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 107D2C4743C for ; Wed, 23 Jun 2021 08:59:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF9E2611CE for ; Wed, 23 Jun 2021 08:59:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF9E2611CE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monstr.eu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BhCOYRF1sM4cXh44pXEY6PdXoQ9wYGqjOQKvb8AakdY=; b=tF43l0Q2azMzda 86o3Rw/X6bQb3lExJsOce6KwTVyl7gKX5DWIWkNTou9YFZ1N11vG8oEiyudiV/2/T4nAUPQgXUldn sZhdlsJhPPV1youtt3EG9MR7TkDnYsSaihWyGYxZmfar3480ME5EE/nm/Jywu15lPqJmZMQ0suYlo Cyhgu8pxY2XzqaBV1ZU0cyIfy/cduqBvI9/MMDRfvP2R+SK5A69sjBHsRgE38TRCk+otKElZhS0B2 hfJpcT978ezXZ/g0WQY/egmQriKTYHltAAY22v6sUmFxSJj+DCNnVTWPTzSIak4gNm3ZM6kIgPC2r 8BOfbEL2ELrQIlsGju+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvyhm-00A0pL-6b; Wed, 23 Jun 2021 08:57:54 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvyhg-00A0mn-64 for linux-arm-kernel@lists.infradead.org; Wed, 23 Jun 2021 08:57:51 +0000 Received: by mail-ej1-x633.google.com with SMTP id ot9so1823808ejb.8 for ; Wed, 23 Jun 2021 01:57:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Z6Z3rnoFwy3s+OnHi/sH1rvXTGduUYkOOkAbeaIPw4Q=; b=tdK9uAJWdmT+cTqTX4ozHwlgRi7wW7OUcIGpx+5Br2fodFNa+MnfUQZVAzgz1DMfXp n/6yy9sAzllko9mIwsv87gD1kCOH5+UvzuTO8Ov4YmQvbrKg9vhNxEnX9Bb3xpiNP2fH k9Oyze3A8ShMVN/bVHL82sBkwKgirt++Dw9dhx7H9AShjZynKsDqAx3QjkNyy+S3seYa O7aOzg7Mj0Cm2KxHYiHvi5dJSHR99JkBwPvAeetXr4PIjVliCzIaKYRVlGsyYaoAOytV AXOwIKzGUy2+Qw0GsQqKp2vE+Hbxv9yib/h1U+C6vqKY5DAWNhTnHvHGn5ed0S9mxQ6J iM2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Z6Z3rnoFwy3s+OnHi/sH1rvXTGduUYkOOkAbeaIPw4Q=; b=qqtD83yyAaJbBtFlbi+Z5/oc7lVO8vbapq/eH855PUPpE4FgT5U2iaguhOOp1yxB/p kPYUOsNjcKvDQIa5TLlUy95xqc+CkHXk2o/GNKVsIaLWErVa1C/GKBdI3kq3ykvTdvzL hJoCNkZVyYnCYVaSHFNnQqsLOgT9Cff7C2p6KptykQHRqGmxMslrSUQKOasXdRk5g0uJ lZ4p1/4f8C4m4nJZFMy4n6UtWvnIZIGIiiYh8Tdh1DqRH3XGRpT6XTBwrJIMSiu7CFK1 JC/8SLXfNADIegTXIzCS0e+MlepncsbZVMyL9Q54JRQmqvhKE7yn4lU5Vdytxz/YMyxq OFYw== X-Gm-Message-State: AOAM530qac9sKa57VFToggAVeRQRh0MoRABKGrUv6PCUDoJxXRiAKfSU RteB5AiuUmxOF2/tANAabj8uFZOBLkimUVkgZ29Syw== X-Google-Smtp-Source: ABdhPJwy+pM9oZ1iyRoxUOJy65b7IRacVpAEIpAEHz2ud7J2MhpMBy54g7b0sAw4obchFDygfdWC6jUFii9npycxr4w= X-Received: by 2002:a17:906:ca4a:: with SMTP id jx10mr8892678ejb.200.1624438666647; Wed, 23 Jun 2021 01:57:46 -0700 (PDT) MIME-Version: 1.0 References: <20200902150643.14839-1-krzk@kernel.org> <20200902150643.14839-2-krzk@kernel.org> In-Reply-To: <20200902150643.14839-2-krzk@kernel.org> From: Michal Simek Date: Wed, 23 Jun 2021 10:57:35 +0200 Message-ID: Subject: Re: [PATCH 2/9] i2c: xiic: Simplify with dev_err_probe() To: Krzysztof Kozlowski , Wolfram Sang Cc: Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Sekhar Nori , Bartosz Golaszewski , Oleksij Rempel , Pengutronix Kernel Team , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , Heiko Stuebner , Pierre-Yves MORDRET , Maxime Coquelin , Alexandre Torgue , Peter Rosin , Wolfram Sang , linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm , LKML , linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210623_015748_313934_72934AA5 X-CRM114-Status: GOOD ( 19.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org c3QgMi4gOS4gMjAyMCB2IDE3OjEwIG9kZXPDrWxhdGVsIEtyenlzenRvZiBLb3psb3dza2kgPGty emtAa2VybmVsLm9yZz4gbmFwc2FsOgo+Cj4gQ29tbW9uIHBhdHRlcm4gb2YgaGFuZGxpbmcgZGVm ZXJyZWQgcHJvYmUgY2FuIGJlIHNpbXBsaWZpZWQgd2l0aAo+IGRldl9lcnJfcHJvYmUoKS4gIExl c3MgY29kZSBhbmQgdGhlIGVycm9yIHZhbHVlIGdldHMgcHJpbnRlZC4KPgo+IFNpZ25lZC1vZmYt Ynk6IEtyenlzenRvZiBLb3psb3dza2kgPGtyemtAa2VybmVsLm9yZz4KPiAtLS0KPiAgZHJpdmVy cy9pMmMvYnVzc2VzL2kyYy14aWljLmMgfCA5ICsrKystLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwg NCBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv aTJjL2J1c3Nlcy9pMmMteGlpYy5jIGIvZHJpdmVycy9pMmMvYnVzc2VzL2kyYy14aWljLmMKPiBp bmRleCA5MGMxYzM2MjM5NGQuLmE5NzQzOGYzNWM1ZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2ky Yy9idXNzZXMvaTJjLXhpaWMuYwo+ICsrKyBiL2RyaXZlcnMvaTJjL2J1c3Nlcy9pMmMteGlpYy5j Cj4gQEAgLTc4NywxMSArNzg3LDEwIEBAIHN0YXRpYyBpbnQgeGlpY19pMmNfcHJvYmUoc3RydWN0 IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgICAgICAgIGluaXRfd2FpdHF1ZXVlX2hlYWQoJmky Yy0+d2FpdCk7Cj4KPiAgICAgICAgIGkyYy0+Y2xrID0gZGV2bV9jbGtfZ2V0KCZwZGV2LT5kZXYs IE5VTEwpOwo+IC0gICAgICAgaWYgKElTX0VSUihpMmMtPmNsaykpIHsKPiAtICAgICAgICAgICAg ICAgaWYgKFBUUl9FUlIoaTJjLT5jbGspICE9IC1FUFJPQkVfREVGRVIpCj4gLSAgICAgICAgICAg ICAgICAgICAgICAgZGV2X2VycigmcGRldi0+ZGV2LCAiaW5wdXQgY2xvY2sgbm90IGZvdW5kLlxu Iik7Cj4gLSAgICAgICAgICAgICAgIHJldHVybiBQVFJfRVJSKGkyYy0+Y2xrKTsKPiAtICAgICAg IH0KPiArICAgICAgIGlmIChJU19FUlIoaTJjLT5jbGspKQo+ICsgICAgICAgICAgICAgICByZXR1 cm4gZGV2X2Vycl9wcm9iZSgmcGRldi0+ZGV2LCBQVFJfRVJSKGkyYy0+Y2xrKSwKPiArICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgImlucHV0IGNsb2NrIG5vdCBmb3VuZC5cbiIp Owo+ICsKPiAgICAgICAgIHJldCA9IGNsa19wcmVwYXJlX2VuYWJsZShpMmMtPmNsayk7Cj4gICAg ICAgICBpZiAocmV0KSB7Cj4gICAgICAgICAgICAgICAgIGRldl9lcnIoJnBkZXYtPmRldiwgIlVu YWJsZSB0byBlbmFibGUgY2xvY2suXG4iKTsKPiAtLQo+IDIuMTcuMQo+Cj4KPiBfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGxpbnV4LWFybS1rZXJuZWwg bWFpbGluZyBsaXN0Cj4gbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCj4gaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs CgpJIHNlZSB0aGF0IHRoaXMgZGlkbid0IGdvIHRocm91Z2guCkFja2VkLWJ5OiBNaWNoYWwgU2lt ZWsgPG1pY2hhbC5zaW1la0B4aWxpbnguY29tPgoKV29sZnJhbTogQ2FuIHlvdSBwbGVhc2UgYXBw bHk/CgpUaGFua3MsCk1pY2hhbAoKCi0tIApNaWNoYWwgU2ltZWssIEluZy4gKE0uRW5nKSwgT3Bl blBHUCAtPiBLZXlJRDogRkUzRDFGOTEKdzogd3d3Lm1vbnN0ci5ldSBwOiArNDItMC03MjE4NDI4 NTQKTWFpbnRhaW5lciBvZiBMaW51eCBrZXJuZWwgLSBYaWxpbnggTWljcm9ibGF6ZQpNYWludGFp bmVyIG9mIExpbnV4IGtlcm5lbCAtIFhpbGlueCBaeW5xIEFSTSBhbmQgWnlucU1QIEFSTTY0IFNv Q3MKVS1Cb290IGN1c3RvZGlhbiAtIFhpbGlueCBNaWNyb2JsYXplL1p5bnEvWnlucU1QL1ZlcnNh bCBTb0NzCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg==