From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PULL_REQUEST, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6C16C433DF for ; Mon, 24 Aug 2020 06:51:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF2052067C for ; Mon, 24 Aug 2020 06:51:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="thY/ZBCP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726257AbgHXGvT (ORCPT ); Mon, 24 Aug 2020 02:51:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725730AbgHXGvS (ORCPT ); Mon, 24 Aug 2020 02:51:18 -0400 Received: from mail-oo1-xc42.google.com (mail-oo1-xc42.google.com [IPv6:2607:f8b0:4864:20::c42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9908C061573 for ; Sun, 23 Aug 2020 23:51:18 -0700 (PDT) Received: by mail-oo1-xc42.google.com with SMTP id k63so1684775oob.1 for ; Sun, 23 Aug 2020 23:51:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PpxiLXTGal/wt3ks6BO05b4YlWK5pFB0UQ1qa3viVm4=; b=thY/ZBCPhvnCSfiETySrPCkEtlwF3IA4JcEb7+CvArxtKe42Nm8ATYMoU3SM07dIca +viAwtfw7spoq+oQu/5KgngzQqddDvW9QMP4dPQBvVJSScCMU0RozcVFsExAVsFXv5pk MYrTbyfxr74tKSqd757P/hwmx6T3hvsfJe/iJ7+Q55FcLg1dauWTnrmyGixeRg88Sbf5 Chxw13aO/9h9HHUa7G6dsVn7i5WgUrDqLOoiF5+5bNtjhA+Rd/Uuxc5rdjtZozliNdDm cxDBROoFbxmOeHAslfKOm8hU4iKYea2PtepHME2LYEot8P+MlH8dQiYI6LrmxU2VQ0F1 cClw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PpxiLXTGal/wt3ks6BO05b4YlWK5pFB0UQ1qa3viVm4=; b=EcG9sqA9G9oqLx5LylZE3GAogT+MrXv7HfnlfOpvAgTL0dCVkpr+Ne2PrtzkED78dH eMSYXNvNCclEYMsLCqXsVXpM3kRTlR7IAA6tHowvQb6LBYQhFuywOEzbx6OsPYtmSelj bjeGNPj/NsYDfsJAqP4EjWInUuo2e5/8zO+VQhLQj/fFRzDBMKv2noV4PPnxgHI00Fju +JddgHVodNj9RzZGK9C2vorCBNvgKiLB6ukhlow3V62cQ/u6XW8009OY1VElF7HCXQTV XuGRDSerMASAVm+M6vDeWD7VxLzp9Ti33WDnPnv0w1MVOK725Or5YJF+s/HC/mVQDzf4 niaw== X-Gm-Message-State: AOAM531DD1Icz6m2pSrI8+7b2gG7OfkNM27O4R4a3ok6cqg1drUD2qIB pTdOSnSc5aqD/OMTEyUCKIw58CUqpXXQJdx4iXCAgw== X-Google-Smtp-Source: ABdhPJx+Pj9zYdHc0o9HEQP/cnQvVo4D2yJy70EETkyBnkGfnjDIhe/IXjscXff+atY7613QMCnz/jk5xwktqR01AhQ= X-Received: by 2002:a4a:e88c:: with SMTP id g12mr2812812ooe.49.1598251877951; Sun, 23 Aug 2020 23:51:17 -0700 (PDT) MIME-Version: 1.0 References: <20200526131259.GA97001@jade> <20200821184910.GB3407@lx2k> In-Reply-To: From: Jens Wiklander Date: Mon, 24 Aug 2020 08:51:06 +0200 Message-ID: Subject: Re: [GIT PULL] tee subsystem pin_user_pages for v5.8 To: Olof Johansson List-Id: Cc: John Hubbard , ARM-SoC Maintainers , SoC Team , Linux Kernel Mailing List , Linux ARM , "tee-dev @ lists . linaro . org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 21, 2020 at 11:19 PM Olof Johansson wrote: > > On Fri, Aug 21, 2020 at 12:58 PM John Hubbard wrote: > > > > On 8/21/20 11:49 AM, Olof Johansson wrote: > > > On Tue, May 26, 2020 at 03:12:59PM +0200, Jens Wiklander wrote: > > >> Hello arm-soc maintainers, > > >> > > >> Please pull this small patch converting the tee subsystem to use > > >> pin_user_pages() instead of get_user_pages(). > > >> > > >> Thanks, > > >> Jens > > >> > > >> The following changes since commit ae83d0b416db002fe95601e7f97f64b59514d936: > > >> > > >> Linux 5.7-rc2 (2020-04-19 14:35:30 -0700) > > >> > > >> are available in the Git repository at: > > >> > > >> git://git.linaro.org:/people/jens.wiklander/linux-tee.git tags/tee-pin-user-pages-for-5.8 > > >> > > >> for you to fetch changes up to 37f6b4d5f47b600ec4ab6682c005a44a1bfca530: > > >> > > >> tee: convert get_user_pages() --> pin_user_pages() (2020-05-26 10:42:41 +0200) > > > > > > Hi, I noticed this never got merged, but I don't see any follow-up here that > > > retracts it. Is it still pending merge such that I should queue it for v5.10? > > > > > > > I think so. I had marked it in my notes as "accepted, and the maintainer will > > eventually merge it", and I left it at that. It's still desirable. > > > > Looks like it conflicts with some of the later work. Jens, given the > timelines here it's probably easiest all around if you rebase/respin > and send a fresh pull request. I could fix it up but you'd still need > to review that so the amount of work is probably less if you do it > directly. Agree, I'll send a fresh pull request once we have this rebased. The conflict is with the recently added call to get_kernel_pages() when kernel memory is shared. The conflict isn't trivial, I guess we need to handle the different types of pages differently when releasing them. John, would you mind rebasing and posting the patch again? Thanks, Jens From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PULL_REQUEST, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86518C433E1 for ; Mon, 24 Aug 2020 06:52:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C20A2067C for ; Mon, 24 Aug 2020 06:52:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mmm3HA6A"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="thY/ZBCP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C20A2067C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VHis74lHw933ml2Il3fVX3+lYZXqZ7tPoH7NPUhQOqw=; b=mmm3HA6APzGGR9ix6zmla0ySF NJ+kHB+L/F5G+rWwpsZ9TuH0xp0HXzoQbyQcOQjcus9S6F/L2vIp/uXZaM06vpRqLCkIQ8VWMUya1 cVEccNHJSMQdWCNPhgF7E1UWgbLcBK0o89sL2TwosdliBTFtUsCnb/x+aQIcnCI+sbhM3TWfBpzjp wNuT6ZASmW9siKVrB4V2mEg2wfHQbvn7ntIhsBAMmTZaTQw1w6aN+v7lltueFJpF0O/q14LHlou+x CtW0+4j3iQ0UN/Vfq6JULf72GwCoGTIc7PbSxo5rstnWHAk+5XAqk88BkPwC/WJB+ORfpw+incThZ Ho0oWQk6g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kA6KC-0000ko-GY; Mon, 24 Aug 2020 06:51:24 +0000 Received: from mail-oo1-xc43.google.com ([2607:f8b0:4864:20::c43]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kA6K9-0000k1-Sk for linux-arm-kernel@lists.infradead.org; Mon, 24 Aug 2020 06:51:22 +0000 Received: by mail-oo1-xc43.google.com with SMTP id u28so1682865ooe.12 for ; Sun, 23 Aug 2020 23:51:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PpxiLXTGal/wt3ks6BO05b4YlWK5pFB0UQ1qa3viVm4=; b=thY/ZBCPhvnCSfiETySrPCkEtlwF3IA4JcEb7+CvArxtKe42Nm8ATYMoU3SM07dIca +viAwtfw7spoq+oQu/5KgngzQqddDvW9QMP4dPQBvVJSScCMU0RozcVFsExAVsFXv5pk MYrTbyfxr74tKSqd757P/hwmx6T3hvsfJe/iJ7+Q55FcLg1dauWTnrmyGixeRg88Sbf5 Chxw13aO/9h9HHUa7G6dsVn7i5WgUrDqLOoiF5+5bNtjhA+Rd/Uuxc5rdjtZozliNdDm cxDBROoFbxmOeHAslfKOm8hU4iKYea2PtepHME2LYEot8P+MlH8dQiYI6LrmxU2VQ0F1 cClw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PpxiLXTGal/wt3ks6BO05b4YlWK5pFB0UQ1qa3viVm4=; b=HjWiTM182WdskbKEyZiC225QkbF6J2c/t79gsliCKT7ZwKkvtPYj4uyuDCrTkOlGBH rkNUwbTB4Z4J40jNbBN+oYoGBxmyDnYYnlF17eXZKauIk+X2whW94UAYhWq07j1iifdV 9Azx6jyQat5EDPAF9LlK0bFkT6gwqUjaLFiJt2ptDkWPH/D5CJjJ5o6ZvxitEo1rwBoY VweFyjVI95w1WTadHxvHH7/XMsf2+W5h9GI8OzEiPk1ko6cYzcYJR2JPSrPZk92pvBzI zxL3alETk1kRa3011NE6QjeyZ7W8V5iHWeZtefPvSYEBQqA7k/GrIfzV8wtqffnqItqS qJGw== X-Gm-Message-State: AOAM532jQ/tq7x2Pi9AEJIcm5zT47WX2XdzdCSB0JlxHDaHcF3vry/WK 2KRL3GBFdnpj7M++UhKGlY4mrzciV5Un3oV4nNNElw== X-Google-Smtp-Source: ABdhPJx+Pj9zYdHc0o9HEQP/cnQvVo4D2yJy70EETkyBnkGfnjDIhe/IXjscXff+atY7613QMCnz/jk5xwktqR01AhQ= X-Received: by 2002:a4a:e88c:: with SMTP id g12mr2812812ooe.49.1598251877951; Sun, 23 Aug 2020 23:51:17 -0700 (PDT) MIME-Version: 1.0 References: <20200526131259.GA97001@jade> <20200821184910.GB3407@lx2k> In-Reply-To: From: Jens Wiklander Date: Mon, 24 Aug 2020 08:51:06 +0200 Message-ID: Subject: Re: [GIT PULL] tee subsystem pin_user_pages for v5.8 To: Olof Johansson X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200824_025121_989841_1662A873 X-CRM114-Status: GOOD ( 24.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , List-Id: Cc: John Hubbard , Linux Kernel Mailing List , "tee-dev @ lists . linaro . org" , SoC Team , ARM-SoC Maintainers , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 21, 2020 at 11:19 PM Olof Johansson wrote: > > On Fri, Aug 21, 2020 at 12:58 PM John Hubbard wrote: > > > > On 8/21/20 11:49 AM, Olof Johansson wrote: > > > On Tue, May 26, 2020 at 03:12:59PM +0200, Jens Wiklander wrote: > > >> Hello arm-soc maintainers, > > >> > > >> Please pull this small patch converting the tee subsystem to use > > >> pin_user_pages() instead of get_user_pages(). > > >> > > >> Thanks, > > >> Jens > > >> > > >> The following changes since commit ae83d0b416db002fe95601e7f97f64b59514d936: > > >> > > >> Linux 5.7-rc2 (2020-04-19 14:35:30 -0700) > > >> > > >> are available in the Git repository at: > > >> > > >> git://git.linaro.org:/people/jens.wiklander/linux-tee.git tags/tee-pin-user-pages-for-5.8 > > >> > > >> for you to fetch changes up to 37f6b4d5f47b600ec4ab6682c005a44a1bfca530: > > >> > > >> tee: convert get_user_pages() --> pin_user_pages() (2020-05-26 10:42:41 +0200) > > > > > > Hi, I noticed this never got merged, but I don't see any follow-up here that > > > retracts it. Is it still pending merge such that I should queue it for v5.10? > > > > > > > I think so. I had marked it in my notes as "accepted, and the maintainer will > > eventually merge it", and I left it at that. It's still desirable. > > > > Looks like it conflicts with some of the later work. Jens, given the > timelines here it's probably easiest all around if you rebase/respin > and send a fresh pull request. I could fix it up but you'd still need > to review that so the amount of work is probably less if you do it > directly. Agree, I'll send a fresh pull request once we have this rebased. The conflict is with the recently added call to get_kernel_pages() when kernel memory is shared. The conflict isn't trivial, I guess we need to handle the different types of pages differently when releasing them. John, would you mind rebasing and posting the patch again? Thanks, Jens _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel