All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Wiklander <jens.wiklander@linaro.org>
To: Tyler Hicks <tyhicks@linux.microsoft.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	OP-TEE TrustedFirmware <op-tee@lists.trustedfirmware.org>,
	Sumit Garg <sumit.garg@linaro.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Sakkinen <jarkko.sakkinen@linux.intel.com>,
	Sasha Levin <sashal@kernel.org>,
	Thirupathaiah Annapureddy <thiruan@microsoft.com>,
	Vikas Gupta <vikas.gupta@broadcom.com>,
	"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH 6/7] firmware: tee_bnxt: use tee_shm_alloc_kernel_buf()
Date: Thu, 10 Jun 2021 11:08:16 +0200	[thread overview]
Message-ID: <CAHUa44Erb6bVFEU=xDoRj4KHn1rMFaEPZfS0H24zR+XgGAoLUQ@mail.gmail.com> (raw)
In-Reply-To: <20210609145811.GJ4910@sequoia>

On Wed, Jun 9, 2021 at 4:58 PM Tyler Hicks <tyhicks@linux.microsoft.com> wrote:
>
> On 2021-06-09 12:23:23, Jens Wiklander wrote:
> > Uses the new simplified tee_shm_alloc_kernel_buf() function instead of
> > the old deprecated tee_shm_alloc() function which required specific
> > TEE_SHM-flags.
> >
> > Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
>
> Since this series is essentially a rewrite of the shm allocation logic,
> it is worth pointing out that the rewrite still uses contiguous
> allocations (from alloc_pages()). The tee_bnxt_fw driver is performing
> an order-10 allocation which is the max, by default. I've only tested
> tee_bnxt_fw when it was built-in to the kernel and tee_bnxt_fw_probe()
> was called early in boot but I suspect that it might not succeed when
> built as a module and loaded later after memory is segmented. I think
> this driver would benefit from being able to request a non-contiguous
> allocation.
>
> Is this rewrite a good time to offer drivers a way to perform a
> non-contiguous allocation?

Good idea, I'll look into that. I'll add it as a separate patch if it works OK.

Cheers,
Jens

WARNING: multiple messages have this Message-ID (diff)
From: Jens Wiklander <jens.wiklander@linaro.org>
To: Tyler Hicks <tyhicks@linux.microsoft.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	 Linux ARM <linux-arm-kernel@lists.infradead.org>,
	 OP-TEE TrustedFirmware <op-tee@lists.trustedfirmware.org>,
	Sumit Garg <sumit.garg@linaro.org>,
	 Herbert Xu <herbert@gondor.apana.org.au>,
	Sakkinen <jarkko.sakkinen@linux.intel.com>,
	 Sasha Levin <sashal@kernel.org>,
	Thirupathaiah Annapureddy <thiruan@microsoft.com>,
	 Vikas Gupta <vikas.gupta@broadcom.com>,
	"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH 6/7] firmware: tee_bnxt: use tee_shm_alloc_kernel_buf()
Date: Thu, 10 Jun 2021 11:08:16 +0200	[thread overview]
Message-ID: <CAHUa44Erb6bVFEU=xDoRj4KHn1rMFaEPZfS0H24zR+XgGAoLUQ@mail.gmail.com> (raw)
In-Reply-To: <20210609145811.GJ4910@sequoia>

On Wed, Jun 9, 2021 at 4:58 PM Tyler Hicks <tyhicks@linux.microsoft.com> wrote:
>
> On 2021-06-09 12:23:23, Jens Wiklander wrote:
> > Uses the new simplified tee_shm_alloc_kernel_buf() function instead of
> > the old deprecated tee_shm_alloc() function which required specific
> > TEE_SHM-flags.
> >
> > Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
>
> Since this series is essentially a rewrite of the shm allocation logic,
> it is worth pointing out that the rewrite still uses contiguous
> allocations (from alloc_pages()). The tee_bnxt_fw driver is performing
> an order-10 allocation which is the max, by default. I've only tested
> tee_bnxt_fw when it was built-in to the kernel and tee_bnxt_fw_probe()
> was called early in boot but I suspect that it might not succeed when
> built as a module and loaded later after memory is segmented. I think
> this driver would benefit from being able to request a non-contiguous
> allocation.
>
> Is this rewrite a good time to offer drivers a way to perform a
> non-contiguous allocation?

Good idea, I'll look into that. I'll add it as a separate patch if it works OK.

Cheers,
Jens

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-06-10  9:09 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-09 10:23 [PATCH 0/7] tee: shared memory updates Jens Wiklander
2021-06-09 10:23 ` Jens Wiklander
2021-06-09 10:23 ` [PATCH 1/7] tee: remove unused tee_shm_pool_alloc_res_mem() Jens Wiklander
2021-06-09 10:23   ` Jens Wiklander
2021-06-09 14:03   ` Tyler Hicks
2021-06-09 14:03     ` Tyler Hicks
2021-06-09 10:23 ` [PATCH 2/7] tee: simplify shm pool handling Jens Wiklander
2021-06-09 10:23   ` Jens Wiklander
2021-06-09 14:50   ` Tyler Hicks
2021-06-09 14:50     ` Tyler Hicks
2021-06-10  9:01     ` Jens Wiklander
2021-06-10  9:01       ` Jens Wiklander
2021-06-09 10:23 ` [PATCH 3/7] tee: add tee_shm_alloc_kernel_buf() Jens Wiklander
2021-06-09 10:23   ` Jens Wiklander
2021-06-09 14:51   ` Tyler Hicks
2021-06-09 14:51     ` Tyler Hicks
2021-06-09 10:23 ` [PATCH 4/7] hwrng: optee-rng: use tee_shm_alloc_kernel_buf() Jens Wiklander
2021-06-09 10:23   ` Jens Wiklander
2021-06-09 14:51   ` Tyler Hicks
2021-06-09 14:51     ` Tyler Hicks
2021-06-09 10:23 ` [PATCH 5/7] tpm_ftpm_tee: " Jens Wiklander
2021-06-09 10:23   ` Jens Wiklander
2021-06-09 14:53   ` Tyler Hicks
2021-06-09 14:53     ` Tyler Hicks
2021-06-09 10:23 ` [PATCH 6/7] firmware: tee_bnxt: " Jens Wiklander
2021-06-09 10:23   ` Jens Wiklander
2021-06-09 14:58   ` Tyler Hicks
2021-06-09 14:58     ` Tyler Hicks
2021-06-10  9:08     ` Jens Wiklander [this message]
2021-06-10  9:08       ` Jens Wiklander
2021-06-09 10:23 ` [PATCH 7/7] tee: replace tee_shm_alloc() Jens Wiklander
2021-06-09 10:23   ` Jens Wiklander
2021-06-09 15:32   ` Tyler Hicks
2021-06-09 15:32     ` Tyler Hicks
2021-06-09 15:38     ` Tyler Hicks
2021-06-09 15:38       ` Tyler Hicks
2021-06-11  7:42     ` Jens Wiklander
2021-06-11  7:42       ` Jens Wiklander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHUa44Erb6bVFEU=xDoRj4KHn1rMFaEPZfS0H24zR+XgGAoLUQ@mail.gmail.com' \
    --to=jens.wiklander@linaro.org \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=op-tee@lists.trustedfirmware.org \
    --cc=sashal@kernel.org \
    --cc=sumit.garg@linaro.org \
    --cc=thiruan@microsoft.com \
    --cc=tyhicks@linux.microsoft.com \
    --cc=vikas.gupta@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.