From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC86FC433E0 for ; Fri, 19 Mar 2021 07:57:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 80BCA64EEC for ; Fri, 19 Mar 2021 07:57:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234023AbhCSH5Y (ORCPT ); Fri, 19 Mar 2021 03:57:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234267AbhCSH46 (ORCPT ); Fri, 19 Mar 2021 03:56:58 -0400 Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D127C06174A for ; Fri, 19 Mar 2021 00:56:58 -0700 (PDT) Received: by mail-ot1-x32c.google.com with SMTP id 31-20020a9d00220000b02901b64b9b50b1so7693462ota.9 for ; Fri, 19 Mar 2021 00:56:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wKLDlhxIRmQDfaYHrkzF6lP07Hoq0etlvj8YZ+tMFUY=; b=t9AFpqhrO7yibnxTuuF+1EaucOklRGoqoNi7aLr0dcqaIZ1U5xcwcprdas6SQDFJai HpryM94huCuIp/QGnmzNcotYmO2p0o/wsK7Gfb2mDtd28yrpgO56I/HUsyBKGQ2lwIfT SF9HV1G3aQnyGhpWIapGROwcXqIfayKM9viiLSel+mrccgYzu9kEhS3/vimKJiZ1AWJH 4/BApaSvim0LD7IrH80un2OfTgYGJqQF9+QVzOGi7kgC1ahheJDQBvBq0aBSDw8XIJ9/ CXuzHasC41ADGVeGy2w7fA5K+eTCx+mq1lYBbbVbFQFX+D3dncCS9ANCERYzJjyi6Ono +yfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wKLDlhxIRmQDfaYHrkzF6lP07Hoq0etlvj8YZ+tMFUY=; b=q6O91REDeatzssxTVuyCYsKu2RXYiizqgNDE2eUGLRBvmZpsvZ7JiPcgR2h60WWBTj cPNb/SCg+vknf6jsT9QFlKCHR2+X2t2aoTbSOdDiyvNemy+zYeInr18n57JYjBurVarb HUFUKTRba+5aWMYZX9K27i6YAZU4hP7bDpkrN3+cvzhHK79SZLOcL4Jnd4wwAuTwmRuu If9qvtYMHkPLcEw05brKtyShElSXPY4TXTRN15Kq1eHtkrcQcpZJ3MtIZFBWyv172Czo NsRKusTLdF82nNAQI8cUJmI2VjP7sgi6IebAi5PdhM45woMvMxQJ7AD/qMFyZHGXyXbG NAwg== X-Gm-Message-State: AOAM531opmuWqyhh2NxKMetz3lbAEK4e17BwowXKxRTKC/aFhBtXJJmB LQYuZEjQs3LWU6y1dffxiWJZSgTzlJC4sCEb0XkYdQ== X-Google-Smtp-Source: ABdhPJzeCdl1/RBLyUCwTe6EyBOOE3ePCeoQEaUMRUr1SSxHvuhC9Ilw+F4ytyNulEB3u0lsp7idrYwaWv3PWHg1C10= X-Received: by 2002:a05:6830:1352:: with SMTP id r18mr57884otq.283.1616140617798; Fri, 19 Mar 2021 00:56:57 -0700 (PDT) MIME-Version: 1.0 References: <20210212154614.38604-1-sudeep.holla@arm.com> <20210316143429.tdyyulkml4ypdixy@bogus> In-Reply-To: From: Jens Wiklander Date: Fri, 19 Mar 2021 08:56:47 +0100 Message-ID: Subject: Re: [PATCH v4 0/7] firmware: Add initial support for Arm FF-A To: Sudeep Holla Cc: Linux ARM , Devicetree List , Trilok Soni , arve@android.com, Andrew Walbran , David Hartley , Achin Gupta , Arunachalam Ganapathy , Marc Bonnici Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Mar 18, 2021 at 3:09 PM Jens Wiklander wrote: > > Hi Sudeep, > > On Tue, Mar 16, 2021 at 3:34 PM Sudeep Holla wrote: > > > > Hi Jens, > > > > On Fri, Feb 12, 2021 at 03:46:07PM +0000, Sudeep Holla wrote: > > > Hi all, > > > > > > This is very basic implementation for in-kernel support for Arm FF-A > > > specification. > > > > > > Arm Firmware Framework for Armv8-A specification[1] describes a software > > > architecture that provides mechanism to utilise the virtualization > > > extension to isolate software images and describes interfaces that > > > standardize communication between the various software images. This > > > includes communication between images in the Secure and Normal world. > > > > > > The main idea here is to create FFA device to establish any communication > > > with a secure partition. This is currently tested with OPTEE(with changes > > > to OPTEE driver adding FFA as transport) > > > > > > > Since you reviewed the last version, it would be helpful if you provide > > Reviewed-by or Tested-by if you happy with this version. I would like to > > get this initial version merged for v5.13 > > I've tested this in a few of my setups and everything looks over all > fine, so please apply: > Tested-by: Jens Wiklander > > I'm also double checking the details of the patches for some further > feedback. Stay tuned. I'm done reviewing this patchset. I had a comment about a TODO in "arm64: smccc: Add support for SMCCCv1.2 input/output registers", I suppose it isn't very urgent with a 32-bit implementation. Cheers, Jens From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64C23C433E0 for ; Fri, 19 Mar 2021 07:58:58 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D30BB64EEC for ; Fri, 19 Mar 2021 07:58:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D30BB64EEC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WhdwEOOPPyPWqeVRTbJbR+NV56MMH+cosliTewE+uus=; b=PyphHXwyk2y2Ro9YSiYFozgV4 GHPLCMcpZC4GuEE5zxNe9+YzBEncnMGq/NyKF0XACmnfffOLaP+OnOrB7RddEyglnEYRU2e8GBpCV 58OMM88V1kw2cPLyC/SetBmHvIRzbtK9xVXmiGJU/oqc44+38XyLUsLwN471TLLkauodRACfOOseP nvgREVTCaLqr5T7a2yL8AJ8nJAR/XS5qEJH6HMXmb9Wo0B5XGDlNVR14iHAInAc//d2Ct2ipFlzCd yaRgQlHMkeDRgwq9+sW3r8APLN7wN+sVspwxpRN9dKYlIvfSqvN2WD0Tx/jHNWkP+HMbVgu1D9o41 1Frz3SfPw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lNA0H-006pdK-0X; Fri, 19 Mar 2021 07:57:05 +0000 Received: from mail-ot1-x331.google.com ([2607:f8b0:4864:20::331]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lNA0B-006pcT-3r for linux-arm-kernel@lists.infradead.org; Fri, 19 Mar 2021 07:57:01 +0000 Received: by mail-ot1-x331.google.com with SMTP id g8-20020a9d6c480000b02901b65ca2432cso7717892otq.3 for ; Fri, 19 Mar 2021 00:56:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wKLDlhxIRmQDfaYHrkzF6lP07Hoq0etlvj8YZ+tMFUY=; b=t9AFpqhrO7yibnxTuuF+1EaucOklRGoqoNi7aLr0dcqaIZ1U5xcwcprdas6SQDFJai HpryM94huCuIp/QGnmzNcotYmO2p0o/wsK7Gfb2mDtd28yrpgO56I/HUsyBKGQ2lwIfT SF9HV1G3aQnyGhpWIapGROwcXqIfayKM9viiLSel+mrccgYzu9kEhS3/vimKJiZ1AWJH 4/BApaSvim0LD7IrH80un2OfTgYGJqQF9+QVzOGi7kgC1ahheJDQBvBq0aBSDw8XIJ9/ CXuzHasC41ADGVeGy2w7fA5K+eTCx+mq1lYBbbVbFQFX+D3dncCS9ANCERYzJjyi6Ono +yfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wKLDlhxIRmQDfaYHrkzF6lP07Hoq0etlvj8YZ+tMFUY=; b=ElS2hWAhz6VcUI3ToSO8g6wbML0ISrG7WMW5Npp7yLQemIyz5Yoq4MMpMQVDcJuOMk /IA2HhMfseL7uLDXAN3FwbxnLKDzO8R1517qCn+TuwYfJfdUhG/AUckAMLxJtKXIaflK DvuDxfD65UrtKPuM3Ny+2A9ki9jpt/5B5XeW57BlFcUj/mSKNAIm5Fibu5wgAkDDQJs+ 1lP94VJ9GQqq14zhZaQwWvZWuXuAahcK0EUl2PzGlBpst5uG5Pxk9iRQbB8iSJ4Y53L1 qqyVO4KviJoVG9FO8qs0yvz1HpqPgJ9eG/t4aWXhcjYUda2Yz6z+mVZl3wtO1iMTfuEW M9vg== X-Gm-Message-State: AOAM533ybB75sshyWtr3DtpsalYnZF0Af1OEKZ9xWDd2yhMdm1ZzBXsn hArbACrqrwQcUHLpGXTf1xShglyKD7/iILvIC8DKYg== X-Google-Smtp-Source: ABdhPJzeCdl1/RBLyUCwTe6EyBOOE3ePCeoQEaUMRUr1SSxHvuhC9Ilw+F4ytyNulEB3u0lsp7idrYwaWv3PWHg1C10= X-Received: by 2002:a05:6830:1352:: with SMTP id r18mr57884otq.283.1616140617798; Fri, 19 Mar 2021 00:56:57 -0700 (PDT) MIME-Version: 1.0 References: <20210212154614.38604-1-sudeep.holla@arm.com> <20210316143429.tdyyulkml4ypdixy@bogus> In-Reply-To: From: Jens Wiklander Date: Fri, 19 Mar 2021 08:56:47 +0100 Message-ID: Subject: Re: [PATCH v4 0/7] firmware: Add initial support for Arm FF-A To: Sudeep Holla Cc: Linux ARM , Devicetree List , Trilok Soni , arve@android.com, Andrew Walbran , David Hartley , Achin Gupta , Arunachalam Ganapathy , Marc Bonnici X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210319_075659_350491_BD40013C X-CRM114-Status: GOOD ( 23.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 18, 2021 at 3:09 PM Jens Wiklander wrote: > > Hi Sudeep, > > On Tue, Mar 16, 2021 at 3:34 PM Sudeep Holla wrote: > > > > Hi Jens, > > > > On Fri, Feb 12, 2021 at 03:46:07PM +0000, Sudeep Holla wrote: > > > Hi all, > > > > > > This is very basic implementation for in-kernel support for Arm FF-A > > > specification. > > > > > > Arm Firmware Framework for Armv8-A specification[1] describes a software > > > architecture that provides mechanism to utilise the virtualization > > > extension to isolate software images and describes interfaces that > > > standardize communication between the various software images. This > > > includes communication between images in the Secure and Normal world. > > > > > > The main idea here is to create FFA device to establish any communication > > > with a secure partition. This is currently tested with OPTEE(with changes > > > to OPTEE driver adding FFA as transport) > > > > > > > Since you reviewed the last version, it would be helpful if you provide > > Reviewed-by or Tested-by if you happy with this version. I would like to > > get this initial version merged for v5.13 > > I've tested this in a few of my setups and everything looks over all > fine, so please apply: > Tested-by: Jens Wiklander > > I'm also double checking the details of the patches for some further > feedback. Stay tuned. I'm done reviewing this patchset. I had a comment about a TODO in "arm64: smccc: Add support for SMCCCv1.2 input/output registers", I suppose it isn't very urgent with a 32-bit implementation. Cheers, Jens _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel