All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Wiklander <jens.wiklander@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 05/20] mmc: rpmb: add mmc_rpmb_route_frames()
Date: Tue, 25 Sep 2018 08:14:10 +0200	[thread overview]
Message-ID: <CAHUa44FP9edxdXjx-HWxVK4neeHTYmd7cnE2iGLPd74=0NP-yw@mail.gmail.com> (raw)
In-Reply-To: <CAPnjgZ1SkETpF+iFYr61bf4vwyzE7k7m=EuQN7-v0PEPB7kjbg@mail.gmail.com>

Hi Simon,

On Fri, Sep 14, 2018 at 12:53 PM, Simon Glass <sjg@chromium.org> wrote:
> Hi Jens,
>
> On 3 September 2018 at 16:46, Jens Wiklander <jens.wiklander@linaro.org> wrote:
>> Adds mmc_rpmb_route_frames() to route RPMB data frames from/to an
>> external entity.
>>
>> Tested-by: Igor Opaniuk <igor.opaniuk@linaro.org>
>> Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
>> ---
>>  drivers/mmc/rpmb.c | 160 +++++++++++++++++++++++++++++++++++++++++++++
>>  include/mmc.h      |   2 +
>>  2 files changed, 162 insertions(+)
>>
>
> [..]
>
>> diff --git a/include/mmc.h b/include/mmc.h
>> index df4255b828a7..d6e02af4edea 100644
>> --- a/include/mmc.h
>> +++ b/include/mmc.h
>> @@ -748,6 +748,8 @@ int mmc_rpmb_read(struct mmc *mmc, void *addr, unsigned short blk,
>>                   unsigned short cnt, unsigned char *key);
>>  int mmc_rpmb_write(struct mmc *mmc, void *addr, unsigned short blk,
>>                    unsigned short cnt, unsigned char *key);
>> +int mmc_rpmb_route_frames(struct mmc *mmc, void *req, unsigned long reqlen,
>> +                         void *rsp, unsigned long rsplen);
>
> Please can you add a full comment to this function? All header-file
> functions should be commented.

I'll fix.

Thanks,
Jens

  reply	other threads:[~2018-09-25  6:14 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-03 14:46 [U-Boot] [PATCH v3 00/20] AVB using OP-TEE Jens Wiklander
2018-09-03 14:46 ` [U-Boot] [PATCH v3 01/20] dm: fdt: scan for devices under /firmware too Jens Wiklander
2018-09-03 14:46 ` [U-Boot] [PATCH v3 02/20] cmd: avb read_rb: print rb_idx in hexadecimal Jens Wiklander
2018-09-03 14:46 ` [U-Boot] [PATCH v3 03/20] cmd: avb: print error message if command fails Jens Wiklander
2018-09-03 14:46 ` [U-Boot] [PATCH v3 04/20] avb_verify: bugfix avb_ops_free() skipping free Jens Wiklander
2018-09-14 10:53   ` Simon Glass
2018-09-03 14:46 ` [U-Boot] [PATCH v3 05/20] mmc: rpmb: add mmc_rpmb_route_frames() Jens Wiklander
2018-09-14 10:53   ` Simon Glass
2018-09-25  6:14     ` Jens Wiklander [this message]
2018-09-03 14:46 ` [U-Boot] [PATCH v3 06/20] Add UCLASS_TEE for Trusted Execution Environment Jens Wiklander
2018-09-03 14:46 ` [U-Boot] [PATCH v3 07/20] dt/bindings: add bindings for optee Jens Wiklander
2018-09-14 10:53   ` Simon Glass
2018-09-03 14:46 ` [U-Boot] [PATCH v3 08/20] tee: add OP-TEE driver Jens Wiklander
2018-09-03 14:47 ` [U-Boot] [PATCH v3 09/20] Documentation: tee uclass and op-tee driver Jens Wiklander
2018-09-03 14:47 ` [U-Boot] [PATCH v3 10/20] arm: dt: hikey: Add optee node Jens Wiklander
2018-09-03 14:47 ` [U-Boot] [PATCH v3 11/20] optee: support routing of rpmb data frames to mmc Jens Wiklander
2018-09-03 14:47 ` [U-Boot] [PATCH v3 12/20] tee: optee: support AVB trusted application Jens Wiklander
2018-09-03 14:47 ` [U-Boot] [PATCH v3 13/20] sandbox: dt: add sandbox_tee node Jens Wiklander
2018-09-03 14:47 ` [U-Boot] [PATCH v3 14/20] sandbox: imply CONFIG_TEE (TEE uclass) Jens Wiklander
2018-09-14 10:53   ` Simon Glass
2018-09-03 14:47 ` [U-Boot] [PATCH v3 15/20] tee: add sandbox driver Jens Wiklander
2018-09-14 10:53   ` Simon Glass
2018-09-25  7:33     ` Jens Wiklander
2018-10-02 11:22       ` Simon Glass
2018-09-03 14:47 ` [U-Boot] [PATCH v3 16/20] test: tee: test TEE uclass Jens Wiklander
2018-09-03 14:47 ` [U-Boot] [PATCH v3 17/20] avb_verify: support using OP-TEE TA AVB Jens Wiklander
2018-09-14 10:54   ` Simon Glass
2018-09-25  7:34     ` Jens Wiklander
2018-09-03 14:47 ` [U-Boot] [PATCH v3 18/20] test_avb: Update pymark.buildconfigspec information for the AVB tests Jens Wiklander
2018-09-14 10:54   ` Simon Glass
2018-09-03 14:47 ` [U-Boot] [PATCH v3 19/20] avb_verify: support sandbox configuration Jens Wiklander
2018-09-14 10:54   ` Simon Glass
2018-09-25 10:50     ` Jens Wiklander
2018-09-03 14:47 ` [U-Boot] [PATCH v3 20/20] Kconfig: sandbox: enable cmd_avb and dependencies Jens Wiklander
2018-09-14 10:54   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHUa44FP9edxdXjx-HWxVK4neeHTYmd7cnE2iGLPd74=0NP-yw@mail.gmail.com' \
    --to=jens.wiklander@linaro.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.