From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 694E7C433FE for ; Mon, 4 Oct 2021 10:11:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B3F061207 for ; Mon, 4 Oct 2021 10:11:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3B3F061207 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6QkRpKz8+JksLLnWF5kV8WTHwZ0AS5ylJTYFxwHmbrw=; b=pjywnFGoRIkOUv fqc/FMlwmvUzBqDySWx29rlfEWaJqnDYYf7t80hnW/uj8L2TvOPtz8ZkE37La5lrfsz9cBXaxlm1T yzwNIHxKBNqs5K3A25Xg/k6KfmhTM2OwWCgrz/ErwyGGZJaQ0wqo/TkifsgLlnIWEAfEdvDGxjbRS /HDoVESaHKgNbPxx2shq6510SBy4FVJlHfTym3R4hgyqcqSK9N5HLsjAWX1XaOGrr3gM7YDRukhUC yCcS1/igKMT0NiiPuDE69GliSNti0qvsMATqOIj7gmqc1P6stlpZuRBKXAngSXDWnl4fNz6Uj7EXw 1r4032yANs0+02nPI1WQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXKuj-005vhI-Vh; Mon, 04 Oct 2021 10:09:42 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXKuP-005vZY-W6 for linux-arm-kernel@lists.infradead.org; Mon, 04 Oct 2021 10:09:23 +0000 Received: by mail-wm1-x32d.google.com with SMTP id g198-20020a1c20cf000000b0030d60cd7fd6so4289902wmg.0 for ; Mon, 04 Oct 2021 03:09:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WgWO25RuuH3Vbr9vSiJmkGBry7OTZxSlBZtiGjoSf2s=; b=m73QNvRi5fVmfTEw3PydE9rDVCfbCpBn/l0m/Fcp3qC5jsuCymMdYFxTtK23/2azGu JTYPoH6Ownh88y8YLUnSSNgkWb5wKQ6fboHFmPBczv9xA08BXVI/L5hQJhJ3JsOtdyNe jBUEZcnaehiXJx3JYi20z0+12FgH/xMPx0rpyAtpOWCY4jrOh4Ar4kD1VCgL+1iCYs5p yWxibD+YYuLSzV9HSJm6ChWdLFquVSFNDct7B1s+ucIe7RMrs1ZrcDv5UWH7NBzAr/VB J2rlswW0D+ohiROpqg5k1VRHfFJ8jm0j78Rd22KosE1CpvpB2lRcDVC0mbFQukqqgUkS rPnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WgWO25RuuH3Vbr9vSiJmkGBry7OTZxSlBZtiGjoSf2s=; b=0GQ9QWXZc6CXSBBoQ3SE7FTJjcudDug4rBLDrqseZ/1YqkQRZh/IPMby8MkyDb23BB ENokh3W/He+5fhyR4VZo56CSuOd/gviVXlxh1aCAXMSEgIeO5CxuOWVmD+TR/Ar4F14r 8d93PcBYTXfukw17sQIibW5hpgwBLYsvl7kZpqfVZ+Ce+d03kjrZc7FSFlcctNjbL6ZL f8v5d7AUvYgKTk2ggHSoeNDNxZ6M8K6tUM5QMjZjR4OflNDjl+HlcwNIfCLUsJAk3HAX KjoWBqy/mWJfVt+HtJOTNeUd67qrgA8+1jPAHWLzc8Lg7TtlZ4AEkdrc4sejz3q3MTu8 Ijdg== X-Gm-Message-State: AOAM5332fzqARQ1VYZzIApDdRLcniZ0C4ja0vLaTwZTft0pKg6BtJGia MFrwJo7I0h7N+jmPAnozSS8BY75EbnQioNnkBjZFfd9XYRCnrw== X-Google-Smtp-Source: ABdhPJzV1482v6zKDNTS3dyv/8N10EevRBdRQSn3iZHLGcjZWwmU3/WuunqK4rMy2+RtKOQ1GKsnANFyG6MF/AoUza4= X-Received: by 2002:a7b:c751:: with SMTP id w17mr5632863wmk.113.1633342160696; Mon, 04 Oct 2021 03:09:20 -0700 (PDT) MIME-Version: 1.0 References: <20210924092859.3057562-1-sudeep.holla@arm.com> In-Reply-To: <20210924092859.3057562-1-sudeep.holla@arm.com> From: Jens Wiklander Date: Mon, 4 Oct 2021 12:09:10 +0200 Message-ID: Subject: Re: [PATCH 1/2] firmware: arm_ffa: Add missing remove callback to ffa_bus_type To: Sudeep Holla Cc: Linux ARM , Arunachalam Ganapathy , Marc Bonnici X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211004_030922_060132_60031C80 X-CRM114-Status: GOOD ( 17.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 24, 2021 at 11:29 AM Sudeep Holla wrote: > > Currently the arm_ffa firmware driver can be built as module and hence > all the users of FFA driver. If any driver on the ffa bus is removed or > unregistered, the remove callback on all the device bound to the driver > being removed should be callback. For that to happen, we must register > a remove callback on the ffa_bus which is currently missing. This results > in the probe getting called again without the previous remove callback > on a device which may result in kernel crash. > > Fix the issue by registering the remove callback on the FFA bus. > > Fixes: e781858488b9 ("firmware: arm_ffa: Add initial FFA bus support for device enumeration") > Reported-by: Jens Wiklander > Signed-off-by: Sudeep Holla > --- > drivers/firmware/arm_ffa/bus.c | 8 ++++++++ > 1 file changed, 8 insertions(+) Tested-by: Jens Wiklander _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel