From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0D16C48BD1 for ; Fri, 11 Jun 2021 09:10:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C094F6136D for ; Fri, 11 Jun 2021 09:10:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231338AbhFKJME (ORCPT ); Fri, 11 Jun 2021 05:12:04 -0400 Received: from mail-wm1-f52.google.com ([209.85.128.52]:42690 "EHLO mail-wm1-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231145AbhFKJMD (ORCPT ); Fri, 11 Jun 2021 05:12:03 -0400 Received: by mail-wm1-f52.google.com with SMTP id l7-20020a05600c1d07b02901b0e2ebd6deso8054259wms.1 for ; Fri, 11 Jun 2021 02:09:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1Egx3T+r+MdqwKDRFu2oj7ToUZ/M+AjkRGEvdLGmyR0=; b=rZfaoDUnOmmtnXLuSumOibA5QNMCiMlQ80NgjHRY0Shk27yj3NfbvwJfg6HLwrNGsQ MZmn0iJ7rTMWg6Zrazz6eZVpBFfKISTNYlJzDhje0d9DxqZMuvip9tgAuSdRIX7TCij2 5+NFIjRh/OASeCDEbuMnbPDQBVf+sQyGH8KFEjTdVnAEZjtt8l08imL6UU11G/iJECnY WPbH7Vk4DSMomRmti8r2X5RsYK/g6H9o7ZrWDkSh050129aUcCZ3LSQ63V2UbWWQ4upG Vkl5PcUwYvhDULREMhlevbgGM5pmAI0YHHXYaK6AENNYo7Un8Q99OH1B3q8sI0SVh4Tw +Wdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1Egx3T+r+MdqwKDRFu2oj7ToUZ/M+AjkRGEvdLGmyR0=; b=n8I4gWQOOKdSa/SM2z4a23wg9AETBDE3LJPCGWnCoYUCqUN3ii82MsPej/2HX2M5NR igq+mJbDDOqQKmJvo201PWh5HQLCIxRbFbxYyb2vSZh5VZi2g0AW19wifRpBoO+54rja QQIzO9ifgQFwoG1bPfxBAB1sCfwgCTxevlhJ2nO092ytEpZ/JmaXIPg1MR/i1I6u4aGv iFfIuCtPjYrHWRLmxmpUwFmfO2wb6OTM6YlEDhnDR9EQQFqIJ2MAZlUmetHv6thaZX67 r+vEukBFTGD1Z+YUdWkwh6cIfVsSmDABP5P/obAUQFLog1fuUQz7Sd50m2Jh0VaVoKKk PVBA== X-Gm-Message-State: AOAM532vM27hGhy7Nq8eojHvk8Ac+YZp2q9cja0f3fpL7tg64a0ye9hB XdlYF6VIdmmnEx057xu8pi2qPiAVQjwhAoYjz8u46w== X-Google-Smtp-Source: ABdhPJxm4IyPJvEMYQF+cuZdjXmewYzeznnDW42omLFdC7jhbt58zwV/AAUm8apWJ3kgHgKNnR7FZoCanj7gvHCZmnU= X-Received: by 2002:a1c:41c5:: with SMTP id o188mr19063241wma.60.1623402539314; Fri, 11 Jun 2021 02:08:59 -0700 (PDT) MIME-Version: 1.0 References: <20210610210913.536081-1-tyhicks@linux.microsoft.com> <20210610210913.536081-3-tyhicks@linux.microsoft.com> In-Reply-To: <20210610210913.536081-3-tyhicks@linux.microsoft.com> From: Jens Wiklander Date: Fri, 11 Jun 2021 11:08:48 +0200 Message-ID: Subject: Re: [PATCH v4 2/8] optee: Refuse to load the driver under the kdump kernel To: Tyler Hicks Cc: Allen Pais , Sumit Garg , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Vikas Gupta , Thirupathaiah Annapureddy , Pavel Tatashin , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , OP-TEE TrustedFirmware , linux-integrity , bcm-kernel-feedback-list@broadcom.com, linux-mips@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 10, 2021 at 11:09 PM Tyler Hicks wrote: > > Fix a hung task issue, seen when booting the kdump kernel, that is > caused by all of the secure world threads being in a permanent suspended > state: > > INFO: task swapper/0:1 blocked for more than 120 seconds. > Not tainted 5.4.83 #1 > "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. > swapper/0 D 0 1 0 0x00000028 > Call trace: > __switch_to+0xc8/0x118 > __schedule+0x2e0/0x700 > schedule+0x38/0xb8 > schedule_timeout+0x258/0x388 > wait_for_completion+0x16c/0x4b8 > optee_cq_wait_for_completion+0x28/0xa8 > optee_disable_shm_cache+0xb8/0xf8 > optee_probe+0x560/0x61c > platform_drv_probe+0x58/0xa8 > really_probe+0xe0/0x338 > driver_probe_device+0x5c/0xf0 > device_driver_attach+0x74/0x80 > __driver_attach+0x64/0xe0 > bus_for_each_dev+0x84/0xd8 > driver_attach+0x30/0x40 > bus_add_driver+0x188/0x1e8 > driver_register+0x64/0x110 > __platform_driver_register+0x54/0x60 > optee_driver_init+0x20/0x28 > do_one_initcall+0x54/0x24c > kernel_init_freeable+0x1e8/0x2c0 > kernel_init+0x18/0x118 > ret_from_fork+0x10/0x18 > > The invoke_fn hook returned OPTEE_SMC_RETURN_ETHREAD_LIMIT, indicating > that the secure world threads were all in a suspended state at the time > of the kernel crash. This intermittently prevented the kdump kernel from > booting, resulting in a failure to collect the kernel dump. > > Make kernel dump collection more reliable on systems utilizing OP-TEE by > refusing to load the driver under the kdump kernel. > > Signed-off-by: Tyler Hicks > --- > drivers/tee/optee/core.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) Looks good Reviewed-by: Jens Wiklander