From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9825C4332F for ; Wed, 9 Nov 2022 18:54:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230253AbiKISyA (ORCPT ); Wed, 9 Nov 2022 13:54:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231664AbiKISxd (ORCPT ); Wed, 9 Nov 2022 13:53:33 -0500 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03AF8D69 for ; Wed, 9 Nov 2022 10:53:22 -0800 (PST) Received: by mail-wm1-x329.google.com with SMTP id h133-20020a1c218b000000b003cf4d389c41so1907887wmh.3 for ; Wed, 09 Nov 2022 10:53:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=kdPqoyAycB6pgUJuMzMPu8rx+xZgOcOan+fWmuoVt8A=; b=AT43cV5BI+6lOtWe0fLdN0byEHao02SLceBCCuNbrsxSssZWdgMdHV8XbgvlzfqJ8s j9ZmOm+3/vuslwAjMlVzki06YltbNwu8aOogTCaXpoNbXnzFpcL/dX4qsn06wlw/tQm5 KShnH1VRFvNjylcK31wwpwBYeq+Ax8def+OSMXPjECSFQ93Q2ZQe6onSL5wyAhEbYQa1 RxpNA+XN0al7dJ0yBIKLF4sLGPOC2n988MyUA+XLdJyMW9ffz6ERxW1f3G+co2ozjJa0 lMS6pj+H3YI1lqDrjp+8pWotGpefCP1orFMn9qFvhYV9Mr9cmI7LGWp6jtF3WOL4tt6X 6hyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kdPqoyAycB6pgUJuMzMPu8rx+xZgOcOan+fWmuoVt8A=; b=V4PWzvuXIiqynRbw1f6+yVoEIhqr+N1GpzMvDwbrGFANd4U6KHQDfLDraNVZuZgDI4 JC501KE8ysRBwzvEdEhl02KIUj8UnvbTmUcakFdixe00AlmB1oUrLs9WcC8DT6JhNMce VFl4iB7gOZ8nTGYemd40QdUH5YXJ41+C3nkbtYIMUKHXR2xeGC+o4kI7W2BGnwriS3iD PNS74OBs+fDNphhHB1+GkY0L8Mwa+kBcI7+2TsKSM6S+tMROLgYhR+pPiGD0d8wfgVal cV9SCAAxC6Mc3PNfoh8yCWqSJG3v2oinvfGfJ3oyCIC7A2qXki2Z/8TC6SyWWaV2eqB3 Pjzw== X-Gm-Message-State: ANoB5plevWKxAJ+j4aV9wl6X2ukEfG6RWQsrxCzxj8ZeZ4rP7V7qDUQ5 RsX2iGlmm6hM4qXNVgcMH7n9VQ95hywqsuANToVTEQ== X-Google-Smtp-Source: AA0mqf434Gt0mmlTBVl9f0K312YzqHufnNREe5hC1WhXil1S+ZC/776mJtyhLZGis6/nxbafTGi34A+JlFz9vGQdHm4= X-Received: by 2002:a7b:ce09:0:b0:3cf:ba0d:6553 with SMTP id m9-20020a7bce09000000b003cfba0d6553mr6407971wmc.112.1668020001136; Wed, 09 Nov 2022 10:53:21 -0800 (PST) MIME-Version: 1.0 References: <20221105045704.2315186-1-vipinsh@google.com> <20221105045704.2315186-5-vipinsh@google.com> <874jv8p7c5.fsf@ovpn-194-83.brq.redhat.com> In-Reply-To: <874jv8p7c5.fsf@ovpn-194-83.brq.redhat.com> From: Vipin Sharma Date: Wed, 9 Nov 2022 10:52:45 -0800 Message-ID: Subject: Re: [PATCH 4/6] KVM: selftests: Make Hyper-V guest OS ID common To: Vitaly Kuznetsov , seanjc@google.com, pbonzini@redhat.com Cc: dmatlack@google.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 9, 2022 at 5:48 AM Vitaly Kuznetsov wrote: > > Vipin Sharma writes: > > > Make guest OS ID calculation common to all hyperv tests and similar to > > hv_generate_guest_id(). > > A similar (but without hv_linux_guest_id()) patch is present in my > Hyper-V TLB flush update: > > https://lore.kernel.org/kvm/20221101145426.251680-32-vkuznets@redhat.com/ > After getting feedback from David, I decided to remove LINUX_VERSION_CODE in v2. Our patches are functionally identical now. @Sean, Paolo, Vitaly Should I be rebasing my v2 on top of TLB flush patch series and remove patch 4 and 5 from my series? I am not sure how these situations are handled. @Vitaly Are you planning to send v14? If yes, then for v13 Patch 31 (KVM: selftests: Move HYPERV_LINUX_OS_ID definition to a common header) will you keep it same or will you modify it to add HYPERV_LINUX_OS_ID in hyperv_clock.c and hyperv_svm_test.c? If not, then I can add a patch in my series to change those two files if I end up rebasing on top of your series.