From: Nick Crews <ncrews@chromium.org>
To: Sebastian Reichel <sre@kernel.org>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Benson Leung <bleung@chromium.org>,
linux-pm@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
Duncan Laurie <dlaurie@chromium.org>,
Oleh Lamzin <lamzin@google.com>,
Bartosz Fabianowski <bartfab@google.com>,
Daniel Erat <derat@google.com>, Dmitry Torokhov <dtor@google.com>,
Simon Glass <sjg@chromium.org>,
jchwong@chromium.org
Subject: Re: [PATCH v4 1/2] power_supply: Add more charge types and CHARGE_CONTROL_* properties
Date: Thu, 18 Apr 2019 10:45:58 -0600 [thread overview]
Message-ID: <CAHX4x85pmo5j1wWLrsNz+nioy-oTwb4NDJcrUKssvdofCmxKug@mail.gmail.com> (raw)
In-Reply-To: <20190417214022.7jk3usygcpnls3pr@earth.universe>
On Wed, Apr 17, 2019 at 3:40 PM Sebastian Reichel <sre@kernel.org> wrote:
>
> Hi,
>
> The changes itself look all good to me, but this does multiple
> things in a single patch, so please split it into multiple commits.
Thanks Sebastian!
I split this into 3 commits:
-add more charge_type's
-add more CHARGE_CONTROL_* properties
-Add missing documentation for other CHARGE_CONTROL_* properties
and just re-sent them.
>
> -- Sebastian
>
prev parent reply other threads:[~2019-04-18 16:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 0:43 [PATCH v4 1/2] power_supply: Add more charge types and CHARGE_CONTROL_* properties Nick Crews
2019-04-17 0:43 ` [PATCH v4 2/2] power_supply: platform/chrome: wilco_ec: Add charging config driver Nick Crews
2019-04-19 23:05 ` kbuild test robot
2019-04-19 23:05 ` kbuild test robot
2019-04-17 21:40 ` [PATCH v4 1/2] power_supply: Add more charge types and CHARGE_CONTROL_* properties Sebastian Reichel
2019-04-18 16:43 ` [PATCH v5 1/3] power_supply: Add Standard, Adaptive, and Custom charge types Nick Crews
2019-04-18 16:43 ` [PATCH v5 2/3] power_supply: Add CHARGE_CONTROL_{START_THRESHOLD,END_THRESHOLD} properties Nick Crews
2019-04-23 13:56 ` Enric Balletbo i Serra
2019-04-18 16:43 ` [PATCH v5 3/3] power_supply: Add missing documentation for CHARGE_CONTROL_* properties Nick Crews
2019-04-23 13:56 ` Enric Balletbo i Serra
2019-04-23 13:55 ` [PATCH v5 1/3] power_supply: Add Standard, Adaptive, and Custom charge types Enric Balletbo i Serra
[not found] ` <CAHX4x87APA8eSD0pCwkBFcR_JxRQsxsH-Ur7186BnHBF=PZf+A@mail.gmail.com>
2019-05-01 23:27 ` Sebastian Reichel
2019-04-18 16:45 ` Nick Crews [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHX4x85pmo5j1wWLrsNz+nioy-oTwb4NDJcrUKssvdofCmxKug@mail.gmail.com \
--to=ncrews@chromium.org \
--cc=bartfab@google.com \
--cc=bleung@chromium.org \
--cc=derat@google.com \
--cc=dlaurie@chromium.org \
--cc=dtor@google.com \
--cc=enric.balletbo@collabora.com \
--cc=jchwong@chromium.org \
--cc=lamzin@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sjg@chromium.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.