From: Samuel Martin <s.martin49@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] Patch for toolchainfile.cmake absolut path references
Date: Sun, 2 Feb 2014 12:14:35 +0100 [thread overview]
Message-ID: <CAHXCMM+3EFDcnL-K5FzuDw1Xs-eThD_yJ4rEP1L7HopmqhMpug@mail.gmail.com> (raw)
In-Reply-To: <52ECDB01.5070306@googlemail.com>
Hi Uwe,
On Sat, Feb 1, 2014 at 12:31 PM, Uwe Strempel <u.strempel@googlemail.com>wrote:
> Hi,
> I've build a patch for BUG #6818
>
> FIrst, thanks for your contribution, but please consider a patch using git,
and send it to the mailing list using 'git send-email' (see
http://www.buildroot.org/downloads/manual/manual.html#_contributing_to_buildroot
),
this is the way Buildroot community works.
Anyway, I looked at the patch.
> On build process of buildroot the toolchainfile.cmake is created, but
> with wrong absolut path.
> When shareing the toolchain or move the folder you get problems this
> path settings.
>
> A workarround for cmake files is
> - get the path of the toolchainfile.cmake and set the the variables.
>
>
I found the part touching the package/Makefile.in a bit confusing.
The idea of what has to be done in the toolchainfile.cmake is good, though
I think you miss some $-escaping...
Regards,
--
Samuel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140202/dfb329ae/attachment.html>
next prev parent reply other threads:[~2014-02-02 11:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-01 11:31 [Buildroot] Patch for toolchainfile.cmake absolut path references Uwe Strempel
2014-02-02 11:14 ` Samuel Martin [this message]
2014-02-02 12:13 ` Uwe Strempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHXCMM+3EFDcnL-K5FzuDw1Xs-eThD_yJ4rEP1L7HopmqhMpug@mail.gmail.com \
--to=s.martin49@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.