From: Samuel Martin <s.martin49@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] package/nginx-naxsi: add missing pcre dependency
Date: Tue, 13 Sep 2016 19:52:03 +0200 [thread overview]
Message-ID: <CAHXCMM+Oph-xL14FSwaYELpbi5b+DJA0u-f5ghFcEiGv24MOow@mail.gmail.com> (raw)
In-Reply-To: <c4abd31c-7224-7d6f-a3b0-cb1ce295caa9@mind.be>
On Tue, Sep 13, 2016 at 7:30 PM, Arnout Vandecappelle <arnout@mind.be> wrote:
>
>
> On 13-09-16 09:57, Samuel Martin wrote:
>> On Tue, Sep 13, 2016 at 8:40 AM, Arnout Vandecappelle <arnout@mind.be> wrote:
>>>
>>>
>>> On 12-09-16 21:23, Samuel Martin wrote:
>>>> Fixes:
>>>> http://autobuild.buildroot.net/results/9c7/9c7bad6831b09251af81e2bbfc595a241df87c70/
>>>>
>>>> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
>>>> ---
>>>> package/nginx-naxsi/Config.in | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/package/nginx-naxsi/Config.in b/package/nginx-naxsi/Config.in
>>>> index 2f7c2da..6c175eb 100644
>>>> --- a/package/nginx-naxsi/Config.in
>>>> +++ b/package/nginx-naxsi/Config.in
>>>> @@ -1,5 +1,6 @@
>>>> config BR2_PACKAGE_NGINX_NAXSI
>>>> bool "nginx-naxsi"
>>>> + select BR2_PACKAGE_PCRE
>>>> help
>>>> NAXSI means Nginx Anti XSS & SQL Injection.
>>>
>>> I may be missing something, but shouldn't there be a _DEPENDENCIES += in .mk?
>>
>> Nope, this is not needed.
>> naxsi is a nginx' module, built by nginx.mk, which already has an
>> automatic dependency on pcre when selected.
>
> I don't think we should rely on transitive dependencies. naxsi.h #include's
> pcre.h, so there should be an explicit dependency in the .mk file.
Fair enough, I'll post the follow-up shortly.
--
Samuel
next prev parent reply other threads:[~2016-09-13 17:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 19:23 [Buildroot] [PATCH 1/3] package/urg: fix build Samuel Martin
2016-09-12 19:23 ` [Buildroot] [PATCH 2/3] package/urg: fix build with gcc-6 Samuel Martin
2016-09-12 20:41 ` Thomas Petazzoni
2016-09-13 4:19 ` Samuel Martin
2016-09-13 6:38 ` Arnout Vandecappelle
2016-10-15 10:24 ` Thomas Petazzoni
2016-09-12 19:23 ` [Buildroot] [PATCH 3/3] package/nginx-naxsi: add missing pcre dependency Samuel Martin
2016-09-12 20:39 ` Thomas Petazzoni
2016-09-13 6:40 ` Arnout Vandecappelle
2016-09-13 7:57 ` Samuel Martin
2016-09-13 17:30 ` Arnout Vandecappelle
2016-09-13 17:52 ` Samuel Martin [this message]
2016-09-14 11:45 ` Thomas Petazzoni
2016-09-12 20:41 ` [Buildroot] [PATCH 1/3] package/urg: fix build Thomas Petazzoni
2016-09-14 9:47 ` Thomas Petazzoni
2016-09-15 4:37 ` Samuel Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHXCMM+Oph-xL14FSwaYELpbi5b+DJA0u-f5ghFcEiGv24MOow@mail.gmail.com \
--to=s.martin49@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.