From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Martin Date: Tue, 13 Sep 2016 19:52:03 +0200 Subject: [Buildroot] [PATCH 3/3] package/nginx-naxsi: add missing pcre dependency In-Reply-To: References: <20160912192324.23682-1-s.martin49@gmail.com> <20160912192324.23682-3-s.martin49@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On Tue, Sep 13, 2016 at 7:30 PM, Arnout Vandecappelle wrote: > > > On 13-09-16 09:57, Samuel Martin wrote: >> On Tue, Sep 13, 2016 at 8:40 AM, Arnout Vandecappelle wrote: >>> >>> >>> On 12-09-16 21:23, Samuel Martin wrote: >>>> Fixes: >>>> http://autobuild.buildroot.net/results/9c7/9c7bad6831b09251af81e2bbfc595a241df87c70/ >>>> >>>> Signed-off-by: Samuel Martin >>>> --- >>>> package/nginx-naxsi/Config.in | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/package/nginx-naxsi/Config.in b/package/nginx-naxsi/Config.in >>>> index 2f7c2da..6c175eb 100644 >>>> --- a/package/nginx-naxsi/Config.in >>>> +++ b/package/nginx-naxsi/Config.in >>>> @@ -1,5 +1,6 @@ >>>> config BR2_PACKAGE_NGINX_NAXSI >>>> bool "nginx-naxsi" >>>> + select BR2_PACKAGE_PCRE >>>> help >>>> NAXSI means Nginx Anti XSS & SQL Injection. >>> >>> I may be missing something, but shouldn't there be a _DEPENDENCIES += in .mk? >> >> Nope, this is not needed. >> naxsi is a nginx' module, built by nginx.mk, which already has an >> automatic dependency on pcre when selected. > > I don't think we should rely on transitive dependencies. naxsi.h #include's > pcre.h, so there should be an explicit dependency in the .mk file. Fair enough, I'll post the follow-up shortly. -- Samuel