From: Samuel Martin <s.martin49@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/7 v3] support/download: make hash file optional
Date: Mon, 23 Mar 2015 13:50:34 +0100 [thread overview]
Message-ID: <CAHXCMM+o9Sb2gW-62AU44tJ6E6hi_QXny9jXHmDv-tza+QpwMw@mail.gmail.com> (raw)
In-Reply-To: <5f50190fe62d33438bfe4c68ab566698c63d5102.1427037564.git.yann.morin.1998@free.fr>
On Sun, Mar 22, 2015 at 4:21 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> Currently, specifying a hash file for our download wrapper is mandatory.
>
> However, when we download a git, svn, bzr, hg or cvs tree, there's by
> design no hash to check the download against.
>
> Since we're going to have hash checking mandatory when a hash file
> exists, this would break those downloads from a repository.
>
> So, make specifying a hash file optional when calling our download
> wrapper and bail out early from the check-hash script if no hash file is
> specified.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Reviewed-by: Samuel Martin <s.martin49@gmail.com>
Regards,
--
Samuel
next prev parent reply other threads:[~2015-03-23 12:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-22 15:21 [Buildroot] [PATCH 0/7 v3] support/download: be more aggressive on missing hashes (branch yem/dl-hash-2) Yann E. MORIN
2015-03-22 15:21 ` [Buildroot] [PATCH 1/7 v3] support/download: make hash file optional Yann E. MORIN
2015-03-23 12:50 ` Samuel Martin [this message]
2015-03-24 19:03 ` Ryan Barnett
2015-03-27 21:31 ` Arnout Vandecappelle
2015-03-22 15:21 ` [Buildroot] [PATCH 2/7 v3] package infra: do not check hashes when downloading from a repository Yann E. MORIN
2015-03-23 12:52 ` Samuel Martin
2015-03-22 15:21 ` [Buildroot] [PATCH 3/7 v3] support/download: add explicit no-hash support Yann E. MORIN
2015-03-22 16:05 ` Arnout Vandecappelle
2015-03-23 12:55 ` Samuel Martin
2015-03-22 15:21 ` [Buildroot] [PATCH 4/7 v3] support/download: return different exit codes for different failures Yann E. MORIN
2015-03-23 13:03 ` Samuel Martin
2015-03-23 18:37 ` Yann E. MORIN
2015-03-22 15:21 ` [Buildroot] [PATCH 5/7 v3] support/download: properly catch missing hashes Yann E. MORIN
2015-03-23 13:08 ` Samuel Martin
2015-03-22 15:21 ` [Buildroot] [PATCH 6/7 v3] support/download: always fail when there's no hash Yann E. MORIN
2015-03-22 15:21 ` [Buildroot] [PATCH 7/7 v3] support/download: warn when there's no .hash file Yann E. MORIN
2015-03-23 13:10 ` Samuel Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHXCMM+o9Sb2gW-62AU44tJ6E6hi_QXny9jXHmDv-tza+QpwMw@mail.gmail.com \
--to=s.martin49@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.