From: Samuel Martin <s.martin49@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] Convert gettext to autotargets
Date: Mon, 21 May 2012 09:52:05 +0200 [thread overview]
Message-ID: <CAHXCMMJi=GZpyk6Uzc2f=emzVGnRHOOuDo-Q6JQWWhvm9TAinw@mail.gmail.com> (raw)
In-Reply-To: <87k407lu8m.fsf@macbook.be.48ers.dk>
Hi,
2012/5/19 Peter Korsgaard <jacmet@uclibc.org>:
>>>>>> "Samuel" == Samuel Martin <s.martin49@gmail.com> writes:
>
> Hi,
>
> ?Samuel> From: Maxime Ripard <maxime.ripard@free-electrons.com>
> ?Samuel> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ?Samuel> Acked-by: Samuel Martin <s.martin49@gmail.com>
> ?Samuel> ---
>
> ?Samuel> -$(GETTEXT_DIR)/$(GETTEXT_BINARY): $(GETTEXT_DIR)/.configured
> ?Samuel> - ? ? ?$(MAKE) -C $(GETTEXT_DIR)
> ?Samuel> - ? ? ?touch -c $(GETTEXT_DIR)/$(GETTEXT_BINARY)
> ?Samuel> +define GETTEXT_REMOVE_BINARIES
> ?Samuel> + ? ? ?rm -f $(TARGET_DIR)/usr/bin/gettext
> ?Samuel> + ? ? ?rm -f $(TARGET_DIR)/usr/bin/gettext.sh
> ?Samuel> + ? ? ?rm -f $(TARGET_DIR)/usr/bin/gettextize
> ?Samuel> +endef
>
> ?Samuel> ?ifeq ($(BR2_PACKAGE_LIBINTL),y)
> ?Samuel> + ? ? ?GETTEXT_POST_INSTALL_TARGET_HOOKS += GETTEXT_REMOVE_BINARIES
> ?Samuel> ?endif
> ?Samuel> +
>
> This seems backwards. Wouldn't you want to keep the binaries if libintl
> is enabled?
Actually, do we really need to remove these binaries?
On an arm build, these 3 binaries take less than 80KB.
Cheers,
Sam
next prev parent reply other threads:[~2012-05-21 7:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 14:46 [Buildroot] [pull request] Pull request for branch for-2012.05/packages-updates Maxime Ripard
2012-04-04 14:46 ` [Buildroot] [PATCH 1/2] Convert gettext to autotargets Maxime Ripard
2012-04-04 14:56 ` Maxime Ripard
2012-05-08 11:19 ` [Buildroot] [PATCH 1/3] " Samuel Martin
2012-05-08 11:19 ` [Buildroot] [PATCH 2/3] gettext: Rename BR2_PACKAGE_LIBINTL to BR2_PACKAGE_GETTEXT_NEEDS_BINARIES Samuel Martin
2012-05-11 21:37 ` Arnout Vandecappelle
2012-05-11 22:45 ` Samuel Martin
2012-05-12 14:43 ` Arnout Vandecappelle
2012-05-08 11:19 ` [Buildroot] [PATCH 3/3] Cleanup gettext/libintl dependencies Samuel Martin
2012-05-19 21:46 ` [Buildroot] [PATCH 1/3] Convert gettext to autotargets Peter Korsgaard
2012-05-21 7:52 ` Samuel Martin [this message]
2012-05-21 8:02 ` Peter Korsgaard
2012-05-21 8:08 ` Will Newton
2012-05-21 8:12 ` Maxime Ripard
2012-05-21 8:12 ` Peter Korsgaard
2012-05-21 8:06 ` Maxime Ripard
2012-04-15 19:09 ` [Buildroot] [PATCH 1/1] " Samuel Martin
2012-04-04 14:46 ` [Buildroot] [PATCH 2/2] Bump systemd to version 44 Maxime Ripard
2012-04-05 11:16 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHXCMMJi=GZpyk6Uzc2f=emzVGnRHOOuDo-Q6JQWWhvm9TAinw@mail.gmail.com' \
--to=s.martin49@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.