From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760920Ab3EBRzS (ORCPT ); Thu, 2 May 2013 13:55:18 -0400 Received: from mail-ia0-f170.google.com ([209.85.210.170]:42524 "EHLO mail-ia0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751746Ab3EBRzQ convert rfc822-to-8bit (ORCPT ); Thu, 2 May 2013 13:55:16 -0400 MIME-Version: 1.0 In-Reply-To: <20130502.133947.387694205526879673.davem@davemloft.net> References: <20130501.164755.1859264969403837546.davem@davemloft.net> <1367512467.4000.7.camel@dcbw.foobar.com> <20130502.133947.387694205526879673.davem@davemloft.net> From: =?ISO-8859-2?Q?Micha=B3_Miros=B3aw?= Date: Thu, 2 May 2013 19:47:25 +0200 Message-ID: Subject: Re: [GIT] Networking To: David Miller Cc: dcbw@redhat.com, torvalds@linux-foundation.org, hayeswang@realtek.com, akpm@linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2013/5/2 David Miller : > From: Dan Williams > Date: Thu, 02 May 2013 11:34:27 -0500 > >> On Wed, 2013-05-01 at 18:28 -0700, Linus Torvalds wrote: >>> On Wed, May 1, 2013 at 1:47 PM, David Miller wrote: >>> > >>> > Highlights (1721 non-merge commits, this has to be a record of some >>> > sort): >>> >>> Lowlight: it completely breaks my machine with r8169 ethernet. In the >>> networkmanager applet, it claims no cable connection, which is a bit >>> odd, because (a) it works with an older kernel and (b) the kernel >>> messages actually say >>> >>> r8169 0000:01:00.0 eth0: link up >> >> NM calls ETHTOOL_GLINK and if that returns success, NM expects the >> driver to support carrier detection. NM then listens to netlink for >> device flags changes, and uses IFF_LOWER_UP to determine carrier on/off >> state. NM does not use NETIF_F_VLAN_CHALLENGED or any of the other >> ETHTOOL_GFEATURES flags yet, but will in the future. >> >> Is the link status accurately reflected by /sys/class/net/eth0/carrier ? > Something cares about the .../eth0/flags value because with the bit > ordering different for bits 10 and above things break. Are you sure it's "flags"? /sys/class/net/*/features were removed some time ago, and flags don't depend on NETIF_F_*. Best Regards, Michał Mirosław