From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-2?Q?Micha=B3_Miros=B3aw?= Subject: Re: [RFC, 1/2] ethtool: Implement private flags interface for ethtool application. Date: Fri, 2 Sep 2011 23:17:17 +0200 Message-ID: References: <1314996631-4773-1-git-send-email-carolyn.wyborny@intel.com> <20110902.165524.1076389492712310664.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: David Miller , "bhutchings@solarflare.com" , "netdev@vger.kernel.org" To: "Wyborny, Carolyn" Return-path: Received: from mail-iy0-f174.google.com ([209.85.210.174]:58637 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755927Ab1IBVRh convert rfc822-to-8bit (ORCPT ); Fri, 2 Sep 2011 17:17:37 -0400 Received: by iabu26 with SMTP id u26so3406212iab.19 for ; Fri, 02 Sep 2011 14:17:37 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: 2011/9/2 Wyborny, Carolyn : >>-----Original Message----- >>From: David Miller [mailto:davem@davemloft.net] >>Sent: Friday, September 02, 2011 1:55 PM >>To: Wyborny, Carolyn >>Cc: bhutchings@solarflare.com; netdev@vger.kernel.org >>Subject: Re: [RFC, 1/2] ethtool: Implement private flags interface fo= r >>ethtool application. >> >>From: Carolyn Wyborny >>Date: Fri, =A02 Sep 2011 13:50:30 -0700 >> >>> This patch completes the user space implementation of the private >>> flags inteface in ethtool. Using -b/-B options. >>> >>> Signed-off-by: Carolyn Wyborny >> >>The only use case you show here is something generic which other >>chips have, Energy Efficient Ethernet. >> >>Making an attribute private which is present widely amonst various >>networking chips makes no sense at all. >> >>It deserved a generic ethtool flag. > > Fair enough on this particular feature, but does that negate the impl= ementation suggestion altogether? =A0I can send an updated feature impl= ementation for the use case using DMA Coalescing if that will help. I would rather see this as an extension to ETHTOOL_[GS]FEATURES. Its semantics allow easy expanding to handle device-private flags without changing anything on userspace side. Best Regards, Micha=B3 Miros=B3aw