[PATCH v2] u-boot-fw-utils: Add capability of building from out-of-tree

[PATCH v2] u-boot-fw-utils: Add capability of building from out-of-tree

[Daisuke Yamane]

This patch also helps to build with EXTERNALSRC.

Signed-off-by: Daisuke Yamane <yamane07ynct@gmail.com>
---
 meta/recipes-bsp/u-boot/u-boot-fw-utils_2020.01.bb | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/meta/recipes-bsp/u-boot/u-boot-fw-utils_2020.01.bb b/meta/recipes-bsp/u-boot/u-boot-fw-utils_2020.01.bb
index 04321b7..7de91ff 100644
--- a/meta/recipes-bsp/u-boot/u-boot-fw-utils_2020.01.bb
+++ b/meta/recipes-bsp/u-boot/u-boot-fw-utils_2020.01.bb
@@ -12,22 +12,22 @@ EXTRA_OEMAKE_class-cross = 'HOSTCC="${CC} ${CFLAGS} ${LDFLAGS}" V=1'
 inherit uboot-config
 
 do_compile () {
-	oe_runmake ${UBOOT_MACHINE}
-	oe_runmake envtools
+	oe_runmake -C ${S} ${UBOOT_MACHINE} O=${B}
+	oe_runmake -C ${S} envtools         O=${B}
 }
 
 do_install () {
 	install -d ${D}${base_sbindir}
 	install -d ${D}${sysconfdir}
-	install -m 755 ${S}/tools/env/fw_printenv ${D}${base_sbindir}/fw_printenv
-	install -m 755 ${S}/tools/env/fw_printenv ${D}${base_sbindir}/fw_setenv
+	install -m 755 ${B}/tools/env/fw_printenv ${D}${base_sbindir}/fw_printenv
+	install -m 755 ${B}/tools/env/fw_printenv ${D}${base_sbindir}/fw_setenv
 	install -m 0644 ${S}/tools/env/fw_env.config ${D}${sysconfdir}/fw_env.config
 }
 
 do_install_class-cross () {
 	install -d ${D}${bindir_cross}
-	install -m 755 ${S}/tools/env/fw_printenv ${D}${bindir_cross}/fw_printenv
-	install -m 755 ${S}/tools/env/fw_printenv ${D}${bindir_cross}/fw_setenv
+	install -m 755 ${B}/tools/env/fw_printenv ${D}${bindir_cross}/fw_printenv
+	install -m 755 ${B}/tools/env/fw_printenv ${D}${bindir_cross}/fw_setenv
 }
 
 SYSROOT_DIRS_append_class-cross = " ${bindir_cross}"
-- 
2.7.4

Re: [PATCH v2] u-boot-fw-utils: Add capability of building from out-of-tree

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

On Fri, Dec 06, 2019 at 10:13:11AM +0000, Daisuke Yamane wrote:

> This patch also helps to build with EXTERNALSRC.
> 
> Signed-off-by: Daisuke Yamane <yamane07ynct@gmail.com>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 849 bytes --]

Re: [PATCH v2] u-boot-fw-utils: Add capability of building from out-of-tree

[Ross Burton]

On 06/12/2019 10:13, Daisuke Yamane wrote:
> This patch also helps to build with EXTERNALSRC.

As this doesn't actually set B, will you be sending a follow-up patch to 
set B so out-of-tree builds actually work?

Ross

Re: [PATCH v2] u-boot-fw-utils: Add capability of building from out-of-tree

[山根大典]

2019年12月9日(月) 19:43 Ross Burton <ross.burton@intel.com>:
>
> On 06/12/2019 10:13, Daisuke Yamane wrote:
> > This patch also helps to build with EXTERNALSRC.
>
> As this doesn't actually set B, will you be sending a follow-up patch to
> set B so out-of-tree builds actually work?
As there is EXTERNALSRC_BUILD in externalsrc.bbclass, I don't think
the follow-up patch is necessary.

>
> Ross
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH v2] u-boot-fw-utils: Add capability of building from out-of-tree

[Ross Burton]

On 10/12/2019 06:09, 山根大典 wrote:
> 2019年12月9日(月) 19:43 Ross Burton <ross.burton@intel.com>:
>>
>> On 06/12/2019 10:13, Daisuke Yamane wrote:
>>> This patch also helps to build with EXTERNALSRC.
>>
>> As this doesn't actually set B, will you be sending a follow-up patch to
>> set B so out-of-tree builds actually work?
> As there is EXTERNALSRC_BUILD in externalsrc.bbclass, I don't think
> the follow-up patch is necessary.

I mean in the general case, not specifically externalsrc.

Out-of-tree builds are fundamentally better than in-tree.

Ross

Re: [PATCH v2] u-boot-fw-utils: Add capability of building from out-of-tree

[Daisuke Yamane]

2019年12月10日(火) 19:39 Ross Burton <ross.burton@intel.com>:
>
> On 10/12/2019 06:09, 山根大典 wrote:
> > 2019年12月9日(月) 19:43 Ross Burton <ross.burton@intel.com>:
> >>
> >> On 06/12/2019 10:13, Daisuke Yamane wrote:
> >>> This patch also helps to build with EXTERNALSRC.
> >>
> >> As this doesn't actually set B, will you be sending a follow-up patch to
> >> set B so out-of-tree builds actually work?
> > As there is EXTERNALSRC_BUILD in externalsrc.bbclass, I don't think
> > the follow-up patch is necessary.
>
> I mean in the general case, not specifically externalsrc.
>
> Out-of-tree builds are fundamentally better than in-tree.
I got it what you mean!
OK, I'll send the patch.

Thank you for pointing it out.