From: Brian Bunker <brian@purestorage.com>
To: linux-scsi@vger.kernel.org
Cc: Martin Wilck <mwilck@suse.com>, Hannes Reinecke <hare@suse.com>
Subject: [PATCH] scsi: dm-mpath: do not fail paths when the target returns ALUA state transition
Date: Thu, 15 Jul 2021 09:57:07 -0700 [thread overview]
Message-ID: <CAHZQxyLY3vNeuNiEHC3SzWzBgUaN-ZPOYyZ3bA=Ah63WYwgdfw@mail.gmail.com> (raw)
When paths return an ALUA state transition, do not fail those paths.
The expectation is that the transition is short lived until the new
ALUA state is entered. There might not be other paths in an online
state to serve the request which can lead to an unexpected I/O error
on the multipath device.
Signed-off-by: Brian Bunker <brian@purestorage.com>
Acked-by: Krishna Kant <krishna.kant@purestorage.com>
Acked-by: Seamus Connor <sconnor@purestorage.com>
--
diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
index bced42f082b0..28948cc481f9 100644
--- a/drivers/md/dm-mpath.c
+++ b/drivers/md/dm-mpath.c
@@ -1652,12 +1652,12 @@ static int multipath_end_io(struct dm_target
*ti, struct request *clone,
if (error && blk_path_error(error)) {
struct multipath *m = ti->private;
- if (error == BLK_STS_RESOURCE)
+ if (error == BLK_STS_RESOURCE || error == BLK_STS_AGAIN)
r = DM_ENDIO_DELAY_REQUEUE;
else
r = DM_ENDIO_REQUEUE;
- if (pgpath)
+ if (pgpath && (error != BLK_STS_AGAIN))
fail_path(pgpath);
if (!atomic_read(&m->nr_valid_paths) &&
--
Thanks,
Brian
Brian Bunker
PURE Storage, Inc.
brian@purestorage.com
next reply other threads:[~2021-07-15 16:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 16:57 Brian Bunker [this message]
2021-07-15 17:01 ` [PATCH] scsi: dm-mpath: do not fail paths when the target returns ALUA state transition Martin Wilck
2021-07-16 6:27 ` Hannes Reinecke
2021-07-16 8:25 ` Martin Wilck
2021-07-16 18:39 ` Brian Bunker
2021-08-03 22:09 ` Brian Bunker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHZQxyLY3vNeuNiEHC3SzWzBgUaN-ZPOYyZ3bA=Ah63WYwgdfw@mail.gmail.com' \
--to=brian@purestorage.com \
--cc=hare@suse.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.