All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Mauricio Vásquez Bernal" <mauricio@kinvolk.io>
To: netdev@vger.kernel.org, bpf@vger.kernel.org
Cc: "Alexei Starovoitov" <ast@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Andrii Nakryiko" <andrii@kernel.org>,
	"Martin KaFai Lau" <kafai@fb.com>,
	"Song Liu" <songliubraving@fb.com>, "Yonghong Song" <yhs@fb.com>,
	"John Fastabend" <john.fastabend@gmail.com>,
	"KP Singh" <kpsingh@kernel.org>,
	"Mauricio Vásquez" <mauriciov@microsoft.com>
Subject: Re: [PATCH bpf-next] libbpf: remove unused variable
Date: Fri, 20 Aug 2021 13:06:04 -0500	[thread overview]
Message-ID: <CAHap4zvz5JW2paVnkYERq=L98pDBBk2mfkJrQ=pHAU3cfqMkAg@mail.gmail.com> (raw)
In-Reply-To: <20210820165511.72890-1-mauricio@kinvolk.io>

On Fri, Aug 20, 2021 at 11:55 AM Mauricio Vásquez <mauricio@kinvolk.io> wrote:
>
> From: Mauricio Vásquez <mauriciov@microsoft.com>
>
> Fixes: ddc7c3042614 ("libbpf: implement BPF CO-RE offset relocation algorithm")
>
> Signed-off-by: Mauricio Vásquez <mauriciov@microsoft.com>
> ---
>  tools/lib/bpf/relo_core.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git tools/lib/bpf/relo_core.c tools/lib/bpf/relo_core.c
> index 4016ed492d0c..52d8125b7cbe 100644
> --- tools/lib/bpf/relo_core.c
> +++ tools/lib/bpf/relo_core.c
> @@ -417,13 +417,6 @@ static int bpf_core_match_member(const struct btf *local_btf,
>                                 return found;
>                 } else if (strcmp(local_name, targ_name) == 0) {
>                         /* matching named field */
> -                       struct bpf_core_accessor *targ_acc;
> -
> -                       targ_acc = &spec->spec[spec->len++];
> -                       targ_acc->type_id = targ_id;
> -                       targ_acc->idx = i;
> -                       targ_acc->name = targ_name;
> -
>                         *next_targ_id = m->type;
>                         found = bpf_core_fields_are_compat(local_btf,
>                                                            local_member->type,
> --
> 2.25.1
>

Forget that, it's used indeed. Sorry for the noise.

      reply	other threads:[~2021-08-20 18:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-20 16:55 [PATCH bpf-next] libbpf: remove unused variable Mauricio Vásquez
2021-08-20 18:06 ` Mauricio Vásquez Bernal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHap4zvz5JW2paVnkYERq=L98pDBBk2mfkJrQ=pHAU3cfqMkAg@mail.gmail.com' \
    --to=mauricio@kinvolk.io \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=john.fastabend@gmail.com \
    --cc=kafai@fb.com \
    --cc=kpsingh@kernel.org \
    --cc=mauriciov@microsoft.com \
    --cc=netdev@vger.kernel.org \
    --cc=songliubraving@fb.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.