From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 4B8401C2071 for ; Fri, 23 Jan 2015 00:19:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 481708B059 for ; Fri, 23 Jan 2015 00:19:54 +0000 (UTC) Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cYplX_Jy05i4 for ; Fri, 23 Jan 2015 00:19:53 +0000 (UTC) Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 0F5578B04B for ; Fri, 23 Jan 2015 00:19:53 +0000 (UTC) Received: by mail-wi0-f172.google.com with SMTP id bs8so47435658wib.5 for ; Thu, 22 Jan 2015 16:19:51 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20150122101422.GK6456@mwanda> References: <20150122101422.GK6456@mwanda> Date: Fri, 23 Jan 2015 09:19:51 +0900 Message-ID: Subject: Re: staging/dgap/dgap.c:981: bad if test ? From: DaeSeok Youn List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Dan Carpenter Cc: "driverdev-devel@linuxdriverproject.org" , David Binderman Hi, 2015-01-22 19:14 GMT+09:00 Dan Carpenter : > > On Thu, Jan 22, 2015 at 10:05:53AM +0000, David Binderman wrote: >> Hello there, >> >> [linux-3.19-rc5/drivers/staging/dgap/dgap.c:981]: (warning) Logical disjunction always evaluates to true: conc_type != 65 || conc_type != 66. >> >> Source code is >> >> if (conc_type == 0 || conc_type != CX || >> conc_type != EPC) { >> >> Suggest code rework. > > Thanks. This bug was introduced in: Yes, right. I will fix this bug. The configuration file has a type of "concentrator" and that type has two different modules that are "ccon" and "epc". If configuration file has another type for "concentrator", returns "-1" but it always return an error. Thanks for reporting. regards, Daeseok Youn. > > commit f6aa0164cd3b1c5192e87f5651ec382c3bc3abac > Author: Daeseok Youn > Date: Sat Aug 9 14:38:41 2014 +0900 > > staging: dgap: Simplify to set a concentrator type > > It is same manner with setting a board type. > For example of config file for concentrator, > "conc ccon" or > "conc epcon" > > After allocating a type of "CNODE" then set a type of concentrator. > So remove cases in swith statement, just get a token from string > and set to "conc.type". And also it doesn't need to "conc.v_type". > > Signed-off-by: Daeseok Youn > Signed-off-by: Greg Kroah-Hartman > > Let's CC Daeseok. > > regards, > dan carpenter > _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel