From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754972AbbCEJgm (ORCPT ); Thu, 5 Mar 2015 04:36:42 -0500 Received: from mail-we0-f177.google.com ([74.125.82.177]:41563 "EHLO mail-we0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754806AbbCEJgk (ORCPT ); Thu, 5 Mar 2015 04:36:40 -0500 MIME-Version: 1.0 In-Reply-To: References: <20150227234840.GA12922@devel.8.8.4.4> <54F42797.1040908@nod.at> Date: Thu, 5 Mar 2015 18:36:39 +0900 Message-ID: Subject: Re: [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error From: DaeSeok Youn To: Andrew Morton Cc: mfasheh@suse.com, Richard Weinberger , Joel Becker , "ocfs2-devel@oss.oracle.com" , linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, How is this patch going on? please check for me. Thanks. Daeseok Youn. 2015-03-03 10:38 GMT+09:00 DaeSeok Youn : > Hi, all > > please, review this patch. > > thanks. > > regards, > Daeseok Youn. > > 2015-03-02 18:04 GMT+09:00 Richard Weinberger : >> Am 28.02.2015 um 00:48 schrieb Daeseok Youn: >>> The use of 'status' in __ocfs2_add_entry() can return wrong >>> status when some functions are failed. >>> >>> If ocfs2_journal_access_db() in __ocfs2_add_entry() is failed, >>> that status is saved to 'status' but return variable is 'retval' >>> which is saved 'success' status. In case of this, __ocfs2_add_entry() >>> is failed but can be returned as 'success'. >>> >>> So replace 'status' with 'retval'. >> >> As this patch is untested and the issue is theoretical I'm nervous. >> But the final decision is up to ocfs2 maintainers. >> >> Thanks, >> //richard From mboxrd@z Thu Jan 1 00:00:00 1970 From: DaeSeok Youn Date: Thu, 5 Mar 2015 18:36:39 +0900 Subject: [Ocfs2-devel] [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error In-Reply-To: References: <20150227234840.GA12922@devel.8.8.4.4> <54F42797.1040908@nod.at> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andrew Morton Cc: mfasheh@suse.com, Richard Weinberger , Joel Becker , "ocfs2-devel@oss.oracle.com" , linux-kernel Hi, How is this patch going on? please check for me. Thanks. Daeseok Youn. 2015-03-03 10:38 GMT+09:00 DaeSeok Youn : > Hi, all > > please, review this patch. > > thanks. > > regards, > Daeseok Youn. > > 2015-03-02 18:04 GMT+09:00 Richard Weinberger : >> Am 28.02.2015 um 00:48 schrieb Daeseok Youn: >>> The use of 'status' in __ocfs2_add_entry() can return wrong >>> status when some functions are failed. >>> >>> If ocfs2_journal_access_db() in __ocfs2_add_entry() is failed, >>> that status is saved to 'status' but return variable is 'retval' >>> which is saved 'success' status. In case of this, __ocfs2_add_entry() >>> is failed but can be returned as 'success'. >>> >>> So replace 'status' with 'retval'. >> >> As this patch is untested and the issue is theoretical I'm nervous. >> But the final decision is up to ocfs2 maintainers. >> >> Thanks, >> //richard