From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 816C2C47082 for ; Thu, 3 Jun 2021 22:09:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6985D613FA for ; Thu, 3 Jun 2021 22:09:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230407AbhFCWL0 (ORCPT ); Thu, 3 Jun 2021 18:11:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbhFCWLZ (ORCPT ); Thu, 3 Jun 2021 18:11:25 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07710C06174A for ; Thu, 3 Jun 2021 15:09:30 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id l1so11475484ejb.6 for ; Thu, 03 Jun 2021 15:09:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xzfzoB78UopFehP2rZuPNY6pMK6KSVtNl9pjPqUQdkg=; b=OXddwIVVqk7mMnbvUmy/B4vinnZoldRQPMmjX0oGBP4JWDb74m2zdXEvW/MiQqbJ5B MYfQ9M76M6Ih+vqYWZnBvTdP4DhooLQ8/v7XnkSBhUTlN7UKKw+0CKsr6tpqU2sAnYjV NCv2RRzp0+4h9cVbfCJkOS+NmFEHGftO/QWi/FKP/r6BPiuV7k2Z6PgUgZkj/4IHaRCc KDNjLToXSAjAkKIYnBO7YYgW9sYdKCncFIY6Hz0yWhdnDsh0fpT611aT58zYII6ArLUN hHpzUPg2uUHNwtm0UlhJXvZWjy3PFtyNUUBB688zGQ8EEtn4ZPSZrsaB+3HSUGZd7VC0 R9vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xzfzoB78UopFehP2rZuPNY6pMK6KSVtNl9pjPqUQdkg=; b=KCvK4g+QQdcHcMH/KqcVMxFEZoD0vameXnN1EBik06gvqIA/yL9n+jlpQowtu8Gc9Z Cucl2+Jtf4CxyVmVn5iqXhH+sQYXpKlDpHZTDBByy9CJsrOEqmJ/Bkk3UmGTjYq6/5Wd LxR1UQJT9KfrIbUKeEwlAnzSUuhvoU+NuCYGNnxGIX3Fj2paEGlEMFQg1I3GJgT2SoDa LKpIdjrqb/MYIZS9B+jpn7DJeDMZcWWCDn4YueB32ufuxeXbu6bZubbhDc6ylYZl/xyG IKCsO70GM9ni06qDXgE7btqpEVKksRRhVhXgNqnxtk2HejuFhLUdSv4wc35txiNjMN5U x2/g== X-Gm-Message-State: AOAM530DAUVSjtwU0dVguM/HNSRDkWvBYo5sBNRQalqj6pMEsZIRmeLg yFSW52k/onlOtaf23LNvVkseMZ20H1KdSExnNos= X-Google-Smtp-Source: ABdhPJw0W4kHchr2hzsUBmxSKzORn+tZaxPDtWRmhXgCiAZoFnWh2VecE/kBv9g50EPNCC4vXMEKsDkIjvsDoUfgf1Q= X-Received: by 2002:a17:906:3912:: with SMTP id f18mr1235862eje.161.1622758168683; Thu, 03 Jun 2021 15:09:28 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Yang Shi Date: Thu, 3 Jun 2021 15:09:17 -0700 Message-ID: Subject: Re: [PATCH 7/7] mm/thp: remap_page() is only needed on anonymous THP To: Hugh Dickins Cc: Andrew Morton , "Kirill A. Shutemov" , Wang Yugui , Matthew Wilcox , Naoya Horiguchi , Alistair Popple , Ralph Campbell , Zi Yan , Miaohe Lin , Minchan Kim , Jue Wang , Peter Xu , Jan Kara , Linux MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 1, 2021 at 2:17 PM Hugh Dickins wrote: > > THP splitting's unmap_page() only sets TTU_SPLIT_FREEZE when PageAnon, > and migration entries are only inserted when TTU_MIGRATION (unused here) > or TTU_SPLIT_FREEZE is set: so it's just a waste of time for remap_page() > to search for migration entries to remove when !PageAnon. > > Fixes: baa355fd3314 ("thp: file pages support for split_huge_page()") > Signed-off-by: Hugh Dickins Reviewed-by: Yang Shi > --- > mm/huge_memory.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 305f709a7aca..e4a83e310452 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -2354,6 +2354,7 @@ static void unmap_page(struct page *page) > > VM_BUG_ON_PAGE(!PageHead(page), page); > > + /* If TTU_SPLIT_FREEZE is ever extended to file, update remap_page() */ > if (PageAnon(page)) > ttu_flags |= TTU_SPLIT_FREEZE; > > @@ -2368,6 +2369,10 @@ static void unmap_page(struct page *page) > static void remap_page(struct page *page, unsigned int nr) > { > int i; > + > + /* If TTU_SPLIT_FREEZE is ever extended to file, remove this check */ > + if (!PageAnon(page)) > + return; > if (PageTransHuge(page)) { > remove_migration_ptes(page, page, true); > } else { > -- > 2.32.0.rc0.204.g9fa02ecfa5-goog > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D240EC47082 for ; Thu, 3 Jun 2021 22:09:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 73FCF613FA for ; Thu, 3 Jun 2021 22:09:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73FCF613FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0637C6B0036; Thu, 3 Jun 2021 18:09:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 013946B006C; Thu, 3 Jun 2021 18:09:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF6D56B006E; Thu, 3 Jun 2021 18:09:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0089.hostedemail.com [216.40.44.89]) by kanga.kvack.org (Postfix) with ESMTP id AF6546B0036 for ; Thu, 3 Jun 2021 18:09:38 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 36B89E0B4 for ; Thu, 3 Jun 2021 22:09:38 +0000 (UTC) X-FDA: 78213805236.36.D031CE7 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by imf07.hostedemail.com (Postfix) with ESMTP id 8CA43A000268 for ; Thu, 3 Jun 2021 22:09:20 +0000 (UTC) Received: by mail-ej1-f41.google.com with SMTP id a11so10764757ejf.3 for ; Thu, 03 Jun 2021 15:09:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xzfzoB78UopFehP2rZuPNY6pMK6KSVtNl9pjPqUQdkg=; b=OXddwIVVqk7mMnbvUmy/B4vinnZoldRQPMmjX0oGBP4JWDb74m2zdXEvW/MiQqbJ5B MYfQ9M76M6Ih+vqYWZnBvTdP4DhooLQ8/v7XnkSBhUTlN7UKKw+0CKsr6tpqU2sAnYjV NCv2RRzp0+4h9cVbfCJkOS+NmFEHGftO/QWi/FKP/r6BPiuV7k2Z6PgUgZkj/4IHaRCc KDNjLToXSAjAkKIYnBO7YYgW9sYdKCncFIY6Hz0yWhdnDsh0fpT611aT58zYII6ArLUN hHpzUPg2uUHNwtm0UlhJXvZWjy3PFtyNUUBB688zGQ8EEtn4ZPSZrsaB+3HSUGZd7VC0 R9vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xzfzoB78UopFehP2rZuPNY6pMK6KSVtNl9pjPqUQdkg=; b=jwhQLrIcwhjWKjVHaq6X+4nmjS+Gl3EB1YNlbarUldInpWqN3wvnNsgHq8yLTg+mqV K4Sh59d5Zp6LjakBE9Otymkv4ZVVKuC/yJaouvcBNWwe2Nz+7PIVFelHFdL7+ddY41fa sO+eu1HVUHxI4hB68Zab/yjhIMXjFtEa0sBzqqLuDvKGR0yU05U4Gm/ni2VS3WNuSvyU vARwpnJuvRM1ozEOquHk3QM5W81TZ3vIbPh33PGv86OeDG+ozqHG7hX9DnO2JTY/CdFC NJ0uKUG2pt9tqsIgfIiCMwcOzXGY60imTE3NxBK9m05oZR3zR/v21xCRmpRBFvNzvbrV 4JeQ== X-Gm-Message-State: AOAM532Ivfq77s2t4k/g6NJozQLo7Cyi7faUVkYun+4xa4by1QYSUmBr BGtOlEaLVv3yzpskPl5kRy9a12zAaarX6Ew/hGQ= X-Google-Smtp-Source: ABdhPJw0W4kHchr2hzsUBmxSKzORn+tZaxPDtWRmhXgCiAZoFnWh2VecE/kBv9g50EPNCC4vXMEKsDkIjvsDoUfgf1Q= X-Received: by 2002:a17:906:3912:: with SMTP id f18mr1235862eje.161.1622758168683; Thu, 03 Jun 2021 15:09:28 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Yang Shi Date: Thu, 3 Jun 2021 15:09:17 -0700 Message-ID: Subject: Re: [PATCH 7/7] mm/thp: remap_page() is only needed on anonymous THP To: Hugh Dickins Cc: Andrew Morton , "Kirill A. Shutemov" , Wang Yugui , Matthew Wilcox , Naoya Horiguchi , Alistair Popple , Ralph Campbell , Zi Yan , Miaohe Lin , Minchan Kim , Jue Wang , Peter Xu , Jan Kara , Linux MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=OXddwIVV; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of shy828301@gmail.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=shy828301@gmail.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 8CA43A000268 X-Stat-Signature: jy5kqgncy3n15k74qwgfetfti1be3z6g X-HE-Tag: 1622758160-806916 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 1, 2021 at 2:17 PM Hugh Dickins wrote: > > THP splitting's unmap_page() only sets TTU_SPLIT_FREEZE when PageAnon, > and migration entries are only inserted when TTU_MIGRATION (unused here) > or TTU_SPLIT_FREEZE is set: so it's just a waste of time for remap_page() > to search for migration entries to remove when !PageAnon. > > Fixes: baa355fd3314 ("thp: file pages support for split_huge_page()") > Signed-off-by: Hugh Dickins Reviewed-by: Yang Shi > --- > mm/huge_memory.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 305f709a7aca..e4a83e310452 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -2354,6 +2354,7 @@ static void unmap_page(struct page *page) > > VM_BUG_ON_PAGE(!PageHead(page), page); > > + /* If TTU_SPLIT_FREEZE is ever extended to file, update remap_page() */ > if (PageAnon(page)) > ttu_flags |= TTU_SPLIT_FREEZE; > > @@ -2368,6 +2369,10 @@ static void unmap_page(struct page *page) > static void remap_page(struct page *page, unsigned int nr) > { > int i; > + > + /* If TTU_SPLIT_FREEZE is ever extended to file, remove this check */ > + if (!PageAnon(page)) > + return; > if (PageTransHuge(page)) { > remove_migration_ptes(page, page, true); > } else { > -- > 2.32.0.rc0.204.g9fa02ecfa5-goog >