From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D386C433EF for ; Tue, 1 Mar 2022 21:49:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238395AbiCAVuT (ORCPT ); Tue, 1 Mar 2022 16:50:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230285AbiCAVuP (ORCPT ); Tue, 1 Mar 2022 16:50:15 -0500 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6751E344E6; Tue, 1 Mar 2022 13:49:33 -0800 (PST) Received: by mail-ej1-x62f.google.com with SMTP id p15so34211940ejc.7; Tue, 01 Mar 2022 13:49:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YdlzCwyPb0LKAsdsGZLfJlZjUMsAn2owiB/9oX5i75A=; b=qEuYBhepionLwIoGiaa9Ulp44ZeIAan84Vhc/O/Y6o6cp8Zgql95Q6rABAoxAdobZj qQeN/ZTM7qbSTofEST/YutPsc9WDpRLj3l84/yd+1p2JbiHxLjBXXniDthmBLrCExdN/ hLyJmEdmjaXGscNd1Yun2TtagX/rVn+g/uiAAbrE9f4X/zMR1s+JgnEowiKxNaqVn9PV Pek7b6OU1s1E2VhnRWYlLdkJ+FDcDWuF1T9WzLb3wqrEXeBR1s/7fkwoGz55JVYAAe8g gH+3LOX9BdkqcrCTiHU28TFZjXh6+mdZPvUcCYNG80jvbK1oujAWLrD6mUpvEC1I7DLR 2jNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YdlzCwyPb0LKAsdsGZLfJlZjUMsAn2owiB/9oX5i75A=; b=EkiQ5w5rz5aoXXKxu5fKXWmt35OL45G2JmV+OU2ZWTd+tIADIa1V2quEP1flkZnx/0 Uz690txdLA84VqSmsMP/TJHMhyWJVzO6b2qShVT95ZsgwkqYIMfGDyG8D/0hMWam3fNM HBj1mennTV9xoGZFhLsfN0yORTup4hYKi02ZHbMnGU3HZ13mQs6IFaAeHunp3VytLoyv l8fj/cGuquqhFcdCTz4ERQ9e4zOTQAnQqzgjXTXZD2f5iZQFxr5LpryCUirZC108k0om 4dousfUY1xb8kaO6ngvPo95++jCW1MzNw+ORbaOW0NAdswnPpXCsOEKmSyIbx/B2AWqr 8xoQ== X-Gm-Message-State: AOAM531TB96LNK3dOJkhK2GsN5al45NCWCXvQO0sSgRmqo1c7v80dGh4 sVhQV/LoSkNhF9Y60TRVPSZ6wVizVSDrsw51K8c= X-Google-Smtp-Source: ABdhPJwGpmDe1OSxAdDHA7AdYxADhyeiRyRx1A6rkz+OGFpxWqmchI7rXwhx1y2oXfad8rFcIase6SAsTWE4z2cHyOs= X-Received: by 2002:a17:907:6006:b0:6ce:46f:fe4b with SMTP id fs6-20020a170907600600b006ce046ffe4bmr19818724ejc.7.1646171371927; Tue, 01 Mar 2022 13:49:31 -0800 (PST) MIME-Version: 1.0 References: <20220228235741.102941-1-shy828301@gmail.com> <20220228235741.102941-2-shy828301@gmail.com> In-Reply-To: From: Yang Shi Date: Tue, 1 Mar 2022 13:49:19 -0800 Message-ID: Subject: Re: [PATCH 1/8] sched: coredump.h: clarify the use of MMF_VM_HUGEPAGE To: Miaohe Lin Cc: Linux MM , Linux FS-devel Mailing List , linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, Linux Kernel Mailing List , Vlastimil Babka , "Kirill A. Shutemov" , Song Liu , Rik van Riel , Matthew Wilcox , Zi Yan , Andrew Morton , "Theodore Ts'o" , Andreas Dilger , darrick.wong@oracle.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 1, 2022 at 12:45 AM Miaohe Lin wrote: > > On 2022/3/1 7:57, Yang Shi wrote: > > MMF_VM_HUGEPAGE is set as long as the mm is available for khugepaged by > > khugepaged_enter(), not only when VM_HUGEPAGE is set on vma. Correct > > the comment to avoid confusion. > > > > Signed-off-by: Yang Shi > > --- > > include/linux/sched/coredump.h | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/include/linux/sched/coredump.h b/include/linux/sched/coredump.h > > index 4d9e3a656875..4d0a5be28b70 100644 > > --- a/include/linux/sched/coredump.h > > +++ b/include/linux/sched/coredump.h > > @@ -57,7 +57,8 @@ static inline int get_dumpable(struct mm_struct *mm) > > #endif > > /* leave room for more dump flags */ > > #define MMF_VM_MERGEABLE 16 /* KSM may merge identical pages */ > > -#define MMF_VM_HUGEPAGE 17 /* set when VM_HUGEPAGE is set on vma */ > > +#define MMF_VM_HUGEPAGE 17 /* set when mm is available for > > + khugepaged */ > > I think this comment could be written in one line. Anyway, this patch looks good to me. > Thanks. Yes, as long as we don't care about the 80 characters limit. I know the limit was bumped to 100 by checkpatch, but I have seen 80 was still preferred by a lot of people. > > Reviewed-by: Miaohe Lin Thanks. > > > /* > > * This one-shot flag is dropped due to necessity of changing exe once again > > * on NFS restore > > >