From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 482BFC432BE for ; Thu, 5 Aug 2021 17:34:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2FB86610A2 for ; Thu, 5 Aug 2021 17:34:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239998AbhHERfL (ORCPT ); Thu, 5 Aug 2021 13:35:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231278AbhHERfJ (ORCPT ); Thu, 5 Aug 2021 13:35:09 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D0FFC061765 for ; Thu, 5 Aug 2021 10:34:55 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id y12so9492901edo.6 for ; Thu, 05 Aug 2021 10:34:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9kMAajMtAAkQ+B+kyhrLYpvECyySrIVX4pfb5IgDdJ4=; b=P5pTwd5Dc7XsWEoDMScfA5rcLY5hIs22eHaZzPfkT6+qKz66AeSNpFZdKpVMi0gQft 6r+XIHuyZ/Q9aIhWPyXK0h44Qzj0rZr+ROxIb9QsuIcBDi4rI0/0Xp5+9pIU/Bno4YuK sRKECaYco050svSwkio1vMKl1liCAbl7GeDQ1WR+sSd4YX2yq1rh2mQ1WSmNAMfE+YuA 4uZ95xOMbKZAlj6r1s/50Y4zpI31l/cvfEOydcp0wCGvIF6i9d2u57PfHIsESFPrkA2I rgVy+0X8EnI8OXHduu8Z61ON7l7UtAGHzGBjSm5rD288MZSIk8NkFpQP/cnzmFvfi8DK 4PZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9kMAajMtAAkQ+B+kyhrLYpvECyySrIVX4pfb5IgDdJ4=; b=YmII8SC+8Auc6b7aBlIMJeXj3hxWr5nfO2UUd9sFvMXmtDHQOnfys+9l5pBMUpE/nz x3IzHywJDAyzt+XX92HTMyS3jjAt7DZFI4xuLzcupONVjpdbBT10A0ekcMRKzduWi85e IqtFEmj8ToWTTrFF2e2rqmGQIvSg+XbdHSA115Bmxbwx6mYR31aRFP54sGfSAkthusAK 78kq1P6TZ/jSF8yrqcB2douy575/ZooJ2ryyVbnT2tDsIdZWZJYG30JcBt2FkM6cq50n nDn+p6wID/0i8vcvSlDvftfLgzxrR9U5vco9jLEgVFN1lgYWngr1F/T+5dmzknZm98vv GPRQ== X-Gm-Message-State: AOAM533YzcC9IT75JvDIKDYjKLMV97Zj1JtPFccOB+q3GgOUtp9T5b3j IslICKGIbem0HN5omnpserI10U5AiNjc3kKOu0M= X-Google-Smtp-Source: ABdhPJy/sJZYP3/YtPmXGxs/cjsuvNPnwb4N3jPPElnhzQF8nDpTkB+1lzk4cqmZyqs73qhbs+LyMtOr9nx6dh7fzIo= X-Received: by 2002:aa7:d899:: with SMTP id u25mr8031341edq.151.1628184893816; Thu, 05 Aug 2021 10:34:53 -0700 (PDT) MIME-Version: 1.0 References: <11d1f8fc954a83945930a5b11f47e00c063bdc1b.1628174413.git.baolin.wang@linux.alibaba.com> In-Reply-To: <11d1f8fc954a83945930a5b11f47e00c063bdc1b.1628174413.git.baolin.wang@linux.alibaba.com> From: Yang Shi Date: Thu, 5 Aug 2021 10:34:42 -0700 Message-ID: Subject: Re: [PATCH 4/5] mm: migrate: Change to use bool type for 'page_was_mapped' To: Baolin Wang Cc: Andrew Morton , Linux MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 5, 2021 at 8:06 AM Baolin Wang wrote: > > Change to use bool type for 'page_was_mapped' variable making it > more readable. Seems better to me. Reviewed-by: Yang Shi > > Signed-off-by: Baolin Wang > --- > mm/migrate.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 6f048a8..0ab364f 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -957,7 +957,7 @@ static int __unmap_and_move(struct page *page, struct page *newpage, > int force, enum migrate_mode mode) > { > int rc = -EAGAIN; > - int page_was_mapped = 0; > + bool page_was_mapped = false; > struct anon_vma *anon_vma = NULL; > bool is_lru = !__PageMovable(page); > > @@ -1060,7 +1060,7 @@ static int __unmap_and_move(struct page *page, struct page *newpage, > VM_BUG_ON_PAGE(PageAnon(page) && !PageKsm(page) && !anon_vma, > page); > try_to_migrate(page, 0); > - page_was_mapped = 1; > + page_was_mapped = true; > } > > if (!page_mapped(page)) > -- > 1.8.3.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C700EC4338F for ; Thu, 5 Aug 2021 17:34:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7AA5C61104 for ; Thu, 5 Aug 2021 17:34:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7AA5C61104 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id D2ED06B006C; Thu, 5 Aug 2021 13:34:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CDEE58D0003; Thu, 5 Aug 2021 13:34:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCE378D0002; Thu, 5 Aug 2021 13:34:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0174.hostedemail.com [216.40.44.174]) by kanga.kvack.org (Postfix) with ESMTP id A2A546B006C for ; Thu, 5 Aug 2021 13:34:55 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 33E2522029 for ; Thu, 5 Aug 2021 17:34:55 +0000 (UTC) X-FDA: 78441727350.27.9DD85C0 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by imf17.hostedemail.com (Postfix) with ESMTP id E5661F0011DE for ; Thu, 5 Aug 2021 17:34:54 +0000 (UTC) Received: by mail-ed1-f44.google.com with SMTP id g21so9524139edb.4 for ; Thu, 05 Aug 2021 10:34:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9kMAajMtAAkQ+B+kyhrLYpvECyySrIVX4pfb5IgDdJ4=; b=P5pTwd5Dc7XsWEoDMScfA5rcLY5hIs22eHaZzPfkT6+qKz66AeSNpFZdKpVMi0gQft 6r+XIHuyZ/Q9aIhWPyXK0h44Qzj0rZr+ROxIb9QsuIcBDi4rI0/0Xp5+9pIU/Bno4YuK sRKECaYco050svSwkio1vMKl1liCAbl7GeDQ1WR+sSd4YX2yq1rh2mQ1WSmNAMfE+YuA 4uZ95xOMbKZAlj6r1s/50Y4zpI31l/cvfEOydcp0wCGvIF6i9d2u57PfHIsESFPrkA2I rgVy+0X8EnI8OXHduu8Z61ON7l7UtAGHzGBjSm5rD288MZSIk8NkFpQP/cnzmFvfi8DK 4PZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9kMAajMtAAkQ+B+kyhrLYpvECyySrIVX4pfb5IgDdJ4=; b=YAQdILPRuo/Qc3BHUo8bMiUwPgGy+o/OQhKTgeNcSIvZevjNkGkkwao13ik29kbtLz t95/UKn3n+a5+s0jbHbaDdRkDMCb6IhhNCS6ly/VMGjCnzoyELeImlI5O1jykpxXbvl1 ELwnpiUxhv/0zPKH1UxBPuvT32MXcXrD+3EVRcaflC7GZMW6eP1a2iYBzpJeT7/vng8J tQCFkxY/GTQ93NuBWY2RH4asWVEH2ljoMbYGmnAD6YzNqm03BSZfSfzmipGUDiMGTZl8 IpnnCeN6fo+Y1mCCAqQqFfOEi5A/IE1/5/PVlm+T3Ey/gbT/3e8YXc2CwRwcwsG4t/bi RwSg== X-Gm-Message-State: AOAM533qVtiUvpK0zQ4KMpU1QuA1fnVzaES68IQrZQgUawidxro+m2g8 LFsY3MYUYKrR+YwHabEtNtN5hn17+8tNt6q7hDIXXGUD8uM= X-Google-Smtp-Source: ABdhPJy/sJZYP3/YtPmXGxs/cjsuvNPnwb4N3jPPElnhzQF8nDpTkB+1lzk4cqmZyqs73qhbs+LyMtOr9nx6dh7fzIo= X-Received: by 2002:aa7:d899:: with SMTP id u25mr8031341edq.151.1628184893816; Thu, 05 Aug 2021 10:34:53 -0700 (PDT) MIME-Version: 1.0 References: <11d1f8fc954a83945930a5b11f47e00c063bdc1b.1628174413.git.baolin.wang@linux.alibaba.com> In-Reply-To: <11d1f8fc954a83945930a5b11f47e00c063bdc1b.1628174413.git.baolin.wang@linux.alibaba.com> From: Yang Shi Date: Thu, 5 Aug 2021 10:34:42 -0700 Message-ID: Subject: Re: [PATCH 4/5] mm: migrate: Change to use bool type for 'page_was_mapped' To: Baolin Wang Cc: Andrew Morton , Linux MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E5661F0011DE Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=P5pTwd5D; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.44 as permitted sender) smtp.mailfrom=shy828301@gmail.com X-Stat-Signature: 6xqgxhy8q1pwmx1q7ix1wpt69krasagd X-HE-Tag: 1628184894-161984 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 5, 2021 at 8:06 AM Baolin Wang wrote: > > Change to use bool type for 'page_was_mapped' variable making it > more readable. Seems better to me. Reviewed-by: Yang Shi > > Signed-off-by: Baolin Wang > --- > mm/migrate.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 6f048a8..0ab364f 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -957,7 +957,7 @@ static int __unmap_and_move(struct page *page, struct page *newpage, > int force, enum migrate_mode mode) > { > int rc = -EAGAIN; > - int page_was_mapped = 0; > + bool page_was_mapped = false; > struct anon_vma *anon_vma = NULL; > bool is_lru = !__PageMovable(page); > > @@ -1060,7 +1060,7 @@ static int __unmap_and_move(struct page *page, struct page *newpage, > VM_BUG_ON_PAGE(PageAnon(page) && !PageKsm(page) && !anon_vma, > page); > try_to_migrate(page, 0); > - page_was_mapped = 1; > + page_was_mapped = true; > } > > if (!page_mapped(page)) > -- > 1.8.3.1 > >