From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E79AEC433B4 for ; Tue, 18 May 2021 20:35:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C491B611B0 for ; Tue, 18 May 2021 20:35:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352095AbhERUgc (ORCPT ); Tue, 18 May 2021 16:36:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236628AbhERUg2 (ORCPT ); Tue, 18 May 2021 16:36:28 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDE4DC061573 for ; Tue, 18 May 2021 13:35:08 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id l4so16596888ejc.10 for ; Tue, 18 May 2021 13:35:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=d+yPM+CpyV8Wh11cTJC3LS6+dkbEEXWG+p9UZNDPsAk=; b=l/azbJk3fat9D0FL0O6XKEvUeyA5tZs2XQoikedFbtKvJ8jTeX1DB8hZP8rzqRtKq4 X1wvvHxlgWhyR5BbfY0/dFH984efcfRxwEVHjXoIxkKUzKjckD2B0s+OZU1nKhm9Dthl DAnsZ8ife3AiZAOVgmAlRk0KTTLP87UnIPlYwUTY07JyJvdld7LFNZjkllBIzVeL3QJd 0phyC2eaA0eHNZTqQZZd5C1GmhWu1Snul/+EM9i0oZe2ICkZSZa3GbbG0K8agQIhkR35 3o9400/8DStKDotpco5ne8237WNQhhxvZoe+8fm2y0qqjIL0kAEVClGECmfwPCjyPxcl 6PCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d+yPM+CpyV8Wh11cTJC3LS6+dkbEEXWG+p9UZNDPsAk=; b=JJKjmnzZZceV4E4HLBg7q6BeC/TmjV1JjADWVe+Pe4NBgKGKU+4tzweXUuzo+cMfvE CadUOH8EJw7zgyOh/5AxxzqSkViIzjBnNTSXcaFCjIjLKgbTwprLYIMsvmwBUP8HI0ui 20NUmTM/XOObl4j+HBXtIA75FCRf+LHXH4C3c/DptpTftpod9Pf+yEHYF0Y8CvSSS0Qe B266WfMZ/licMtfVv7i6O9VR8ivz6GKV5MHWothsNXa5L+hah8rTQnz1pIEF9PgOIvCc n1vToOgdp8pknvpvmQOUHKEurTEhTj2zn1xUWJUVEcErCkCgxIA6g34/qe+DjHjBqB+6 f8aw== X-Gm-Message-State: AOAM533tEgW3U4AKrYwHHvoLTsgmaN4MmY/Ovws0eATkx9gsrZyAlBlQ OHZUXcZFbJtg+quXxK0u6ePGhuHK/fhjBoV/5Ic= X-Google-Smtp-Source: ABdhPJxtiC1TrMgg8FP975op27pt7l46d2euPAFUX3EXSZ3uUypUhsdti8PJxgghaGeWZmJjjsOvel9nRXUzFmxM+4o= X-Received: by 2002:a17:906:a51:: with SMTP id x17mr7997640ejf.25.1621370107556; Tue, 18 May 2021 13:35:07 -0700 (PDT) MIME-Version: 1.0 References: <20210518200927.69011-1-jrdr.linux@gmail.com> In-Reply-To: From: Yang Shi Date: Tue, 18 May 2021 13:34:55 -0700 Message-ID: Subject: Re: [PATCH] mm/huge_memory.c: Remove unused variable unmap_success To: Souptick Joarder Cc: Andrew Morton , Linux MM , Linux Kernel Mailing List , kernel test robot Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 18, 2021 at 1:19 PM Yang Shi wrote: > > On Tue, May 18, 2021 at 1:09 PM Souptick Joarder wrote: > > > > Kernel test robot throws below warning -> > > > > mm/huge_memory.c: In function 'unmap_page': > > >> mm/huge_memory.c:2345:7: warning: variable 'unmap_success' set but not used [-Wunused-but-set-variable] > > 2345 | bool unmap_success; > > | ^~~~~~~~~~~~~ > > > > Remove the unused variable unmap_success. > > > > Reported-by: kernel test robot > > Signed-off-by: Souptick Joarder > > Thanks for catching this. Reviewed-by: Yang Shi > > Just like https://lore.kernel.org/linux-mm/CAHbLzkonsd9f=48+cxKOJamNb9e8qpvWJCYDGFB_wNTdET2zmQ@mail.gmail.com/T/#t, > not sure why my compiler didn't catch such warning. I just found out my build has "-Wno-unused-but-set-variable". This explains why I didn't catch it. > > --- > > mm/huge_memory.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > > index 52ca04b905cf..ff79a12993c9 100644 > > --- a/mm/huge_memory.c > > +++ b/mm/huge_memory.c > > @@ -2342,14 +2342,13 @@ static void unmap_page(struct page *page) > > { > > enum ttu_flags ttu_flags = TTU_IGNORE_MLOCK | > > TTU_RMAP_LOCKED | TTU_SPLIT_HUGE_PMD; > > - bool unmap_success; > > > > VM_BUG_ON_PAGE(!PageHead(page), page); > > > > if (PageAnon(page)) > > ttu_flags |= TTU_SPLIT_FREEZE; > > > > - unmap_success = try_to_unmap(page, ttu_flags); > > + try_to_unmap(page, ttu_flags); > > } > > > > static void remap_page(struct page *page, unsigned int nr) > > -- > > 2.25.1 > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F155C433B4 for ; Tue, 18 May 2021 20:35:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A05276100A for ; Tue, 18 May 2021 20:35:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A05276100A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 102148E0052; Tue, 18 May 2021 16:35:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B22E8E002F; Tue, 18 May 2021 16:35:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EBC1A8E0052; Tue, 18 May 2021 16:35:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0132.hostedemail.com [216.40.44.132]) by kanga.kvack.org (Postfix) with ESMTP id BE4ED8E002F for ; Tue, 18 May 2021 16:35:10 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id CC418824999B for ; Tue, 18 May 2021 20:35:08 +0000 (UTC) X-FDA: 78155506296.07.0CD4392 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf02.hostedemail.com (Postfix) with ESMTP id 508D4407F8F8 for ; Tue, 18 May 2021 20:35:06 +0000 (UTC) Received: by mail-ej1-f54.google.com with SMTP id lg14so16613399ejb.9 for ; Tue, 18 May 2021 13:35:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=d+yPM+CpyV8Wh11cTJC3LS6+dkbEEXWG+p9UZNDPsAk=; b=l/azbJk3fat9D0FL0O6XKEvUeyA5tZs2XQoikedFbtKvJ8jTeX1DB8hZP8rzqRtKq4 X1wvvHxlgWhyR5BbfY0/dFH984efcfRxwEVHjXoIxkKUzKjckD2B0s+OZU1nKhm9Dthl DAnsZ8ife3AiZAOVgmAlRk0KTTLP87UnIPlYwUTY07JyJvdld7LFNZjkllBIzVeL3QJd 0phyC2eaA0eHNZTqQZZd5C1GmhWu1Snul/+EM9i0oZe2ICkZSZa3GbbG0K8agQIhkR35 3o9400/8DStKDotpco5ne8237WNQhhxvZoe+8fm2y0qqjIL0kAEVClGECmfwPCjyPxcl 6PCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d+yPM+CpyV8Wh11cTJC3LS6+dkbEEXWG+p9UZNDPsAk=; b=JOY86En2HKrIY2vYcTvSgg4OGanjnUNKIq0HFPJlXLfZIE88IKPH/adBYsn6gd7RW/ ZXAAH5H1QuG1C7A2swnYHxXJ78jou4Loz72BPeJbVLf3TMrtz7/7+8KbxzfEBDbJ/pLN KE0j9QteApwz4Ia0shSNsx9UUEpsorQD592RnxkPLLqBVSKVn2wtm72BmdBBviB5qOqC AJBCGwN3CQMynxzRBpgY5pepOjaf77BQHGQwnikwSg8qx6IQrud5bEVvvZ7pb+Cqwots aR3u4jAfgN0dPxnNd6JBjVmPdFaRw+OoXGzLyvuYFSx1+cyKtapKV5VGTsOPoHqux5lF EyPQ== X-Gm-Message-State: AOAM5317CYaOQffKcN+13D5YmXAc8fSn6HV7tHjVOM2HEq9RnSbD3vMI h+gLw3+hfr5zuWw7P7AdLY9mDq2hqbZBKrsD4VE= X-Google-Smtp-Source: ABdhPJxtiC1TrMgg8FP975op27pt7l46d2euPAFUX3EXSZ3uUypUhsdti8PJxgghaGeWZmJjjsOvel9nRXUzFmxM+4o= X-Received: by 2002:a17:906:a51:: with SMTP id x17mr7997640ejf.25.1621370107556; Tue, 18 May 2021 13:35:07 -0700 (PDT) MIME-Version: 1.0 References: <20210518200927.69011-1-jrdr.linux@gmail.com> In-Reply-To: From: Yang Shi Date: Tue, 18 May 2021 13:34:55 -0700 Message-ID: Subject: Re: [PATCH] mm/huge_memory.c: Remove unused variable unmap_success To: Souptick Joarder Cc: Andrew Morton , Linux MM , Linux Kernel Mailing List , kernel test robot Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b="l/azbJk3"; spf=pass (imf02.hostedemail.com: domain of shy828301@gmail.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 508D4407F8F8 X-Stat-Signature: p3xieds3yn4nxnxhekooh185z9f7w77m X-HE-Tag: 1621370106-582308 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 18, 2021 at 1:19 PM Yang Shi wrote: > > On Tue, May 18, 2021 at 1:09 PM Souptick Joarder wrote: > > > > Kernel test robot throws below warning -> > > > > mm/huge_memory.c: In function 'unmap_page': > > >> mm/huge_memory.c:2345:7: warning: variable 'unmap_success' set but not used [-Wunused-but-set-variable] > > 2345 | bool unmap_success; > > | ^~~~~~~~~~~~~ > > > > Remove the unused variable unmap_success. > > > > Reported-by: kernel test robot > > Signed-off-by: Souptick Joarder > > Thanks for catching this. Reviewed-by: Yang Shi > > Just like https://lore.kernel.org/linux-mm/CAHbLzkonsd9f=48+cxKOJamNb9e8qpvWJCYDGFB_wNTdET2zmQ@mail.gmail.com/T/#t, > not sure why my compiler didn't catch such warning. I just found out my build has "-Wno-unused-but-set-variable". This explains why I didn't catch it. > > --- > > mm/huge_memory.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > > index 52ca04b905cf..ff79a12993c9 100644 > > --- a/mm/huge_memory.c > > +++ b/mm/huge_memory.c > > @@ -2342,14 +2342,13 @@ static void unmap_page(struct page *page) > > { > > enum ttu_flags ttu_flags = TTU_IGNORE_MLOCK | > > TTU_RMAP_LOCKED | TTU_SPLIT_HUGE_PMD; > > - bool unmap_success; > > > > VM_BUG_ON_PAGE(!PageHead(page), page); > > > > if (PageAnon(page)) > > ttu_flags |= TTU_SPLIT_FREEZE; > > > > - unmap_success = try_to_unmap(page, ttu_flags); > > + try_to_unmap(page, ttu_flags); > > } > > > > static void remap_page(struct page *page, unsigned int nr) > > -- > > 2.25.1 > > > >