From: Yang Shi <shy828301@gmail.com>
To: Gautam Menghani <gautammenghani201@gmail.com>
Cc: akpm@linux-foundation.org, rostedt@goodmis.org,
mhiramat@kernel.org, zokeefe@google.com, david@redhat.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/khugepaged: Refactor mm_khugepaged_scan_file tracepoint to remove filename from function call
Date: Wed, 26 Oct 2022 11:10:58 -0700 [thread overview]
Message-ID: <CAHbLzkq_6tGYfmd-f8Gg-YSLoLXtdFmpxVCUof90B=YA4X7SAA@mail.gmail.com> (raw)
In-Reply-To: <20221026044524.54793-1-gautammenghani201@gmail.com>
On Tue, Oct 25, 2022 at 9:45 PM Gautam Menghani
<gautammenghani201@gmail.com> wrote:
>
> Refactor the mm_khugepaged_scan_file tracepoint to move filename
> dereference to the tracepoint definition, for maintaing consistency with
> other tracepoints[1].
>
> [1]:lore.kernel.org/lkml/20221024111621.3ba17e2c@gandalf.local.home/
>
> Signed-off-by: Gautam Menghani <gautammenghani201@gmail.com>
Reviewed-by: Yang Shi <shy828301@gmail.com>
> ---
> include/trace/events/huge_memory.h | 8 ++++----
> mm/khugepaged.c | 3 +--
> 2 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/include/trace/events/huge_memory.h b/include/trace/events/huge_memory.h
> index 935af4947917..760455dfa860 100644
> --- a/include/trace/events/huge_memory.h
> +++ b/include/trace/events/huge_memory.h
> @@ -171,15 +171,15 @@ TRACE_EVENT(mm_collapse_huge_page_swapin,
>
> TRACE_EVENT(mm_khugepaged_scan_file,
>
> - TP_PROTO(struct mm_struct *mm, struct page *page, const char *filename,
> + TP_PROTO(struct mm_struct *mm, struct page *page, struct file *file,
> int present, int swap, int result),
>
> - TP_ARGS(mm, page, filename, present, swap, result),
> + TP_ARGS(mm, page, file, present, swap, result),
>
> TP_STRUCT__entry(
> __field(struct mm_struct *, mm)
> __field(unsigned long, pfn)
> - __string(filename, filename)
> + __string(filename, file->f_path.dentry->d_iname)
> __field(int, present)
> __field(int, swap)
> __field(int, result)
> @@ -188,7 +188,7 @@ TRACE_EVENT(mm_khugepaged_scan_file,
> TP_fast_assign(
> __entry->mm = mm;
> __entry->pfn = page ? page_to_pfn(page) : -1;
> - __assign_str(filename, filename);
> + __assign_str(filename, file->f_path.dentry->d_iname);
> __entry->present = present;
> __entry->swap = swap;
> __entry->result = result;
> diff --git a/mm/khugepaged.c b/mm/khugepaged.c
> index 4734315f7940..9808a899f9f7 100644
> --- a/mm/khugepaged.c
> +++ b/mm/khugepaged.c
> @@ -2157,8 +2157,7 @@ static int hpage_collapse_scan_file(struct mm_struct *mm, unsigned long addr,
> }
> }
>
> - trace_mm_khugepaged_scan_file(mm, page, file->f_path.dentry->d_iname,
> - present, swap, result);
> + trace_mm_khugepaged_scan_file(mm, page, file, present, swap, result);
> return result;
> }
> #else
> --
> 2.34.1
>
next prev parent reply other threads:[~2022-10-26 18:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 4:45 [PATCH] mm/khugepaged: Refactor mm_khugepaged_scan_file tracepoint to remove filename from function call Gautam Menghani
2022-10-26 18:10 ` Yang Shi [this message]
2022-10-27 17:43 ` Zach O'Keefe
2022-11-14 15:24 ` Steven Rostedt
2022-11-16 22:35 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHbLzkq_6tGYfmd-f8Gg-YSLoLXtdFmpxVCUof90B=YA4X7SAA@mail.gmail.com' \
--to=shy828301@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=gautammenghani201@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=zokeefe@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.