From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 027D1C4320A for ; Wed, 1 Sep 2021 03:46:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D2FCE60EBB for ; Wed, 1 Sep 2021 03:46:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241840AbhIADrX (ORCPT ); Tue, 31 Aug 2021 23:47:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241754AbhIADrV (ORCPT ); Tue, 31 Aug 2021 23:47:21 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84D01C061575 for ; Tue, 31 Aug 2021 20:46:25 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id eb14so1702948edb.8 for ; Tue, 31 Aug 2021 20:46:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MbuNJ6AQL86qsQ1Xnhu/tEYDLNw3wqiKq1TKFtDIHSI=; b=V8+dKyDWIxJq3KqvBhqnqbWOUcoOIAMkmOAR9HytZqqlK/C9bxciBAsOOeQ7Bgyoyh jtQsc7rtiNzaRliiI3M3GSFW3JdcHFkG2RKGCDgp1f0SNHlZoDBceDDeulwneZYwMlak Ykct7OZadYrQgwOWGddzIa5MaM0ZcdxNhfNPgxbA5y16ReSo+UjegTI3iFx5X5/UCUvV tP8Q4Dnd1RGcoSsW7g08iLtU3IU/56QDzxoGMqPg8vIPIMuZ4EyMnz4N8XyXcrAf9ak/ 6qAnD6Mbv6tzrHzCdYacF5Utbga5owTJXjKdllt6ijDLKGXVcdp3NKvNgfUiVVtpty9d j+7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MbuNJ6AQL86qsQ1Xnhu/tEYDLNw3wqiKq1TKFtDIHSI=; b=QoYBWaPqsKRmH8HEoIuvPfBVbF7G1KZuOmwkh6GeJdeaDvhZlF99O26euaKtIA4GyV n9Ss85hK7B/MuqWt+VthNX5nht7kviSuN9OFudT5rvAOAsAIcuDnC+KygE8CnMFkdz4O TfKa5IAJJiLeloKx/OQQl5D/soup09fPA80iYtryIRxuKjsaiG8zZv/q/RW86nXFsAtH vCZ2V/H11B3REsbofP2USDWxJuj1PpIeTogJIGPd9dDr6+f+zVDR1Bv0F5QMk3nnLBYT gnAsKFwUcCGt3ySfZUwdZ75UOMrIMUTA4bN6ocfiL3lCluDi3cKTWmuwqiQAb5TM1lWE gOzw== X-Gm-Message-State: AOAM532sDZXqbe8wqyWYVWhE9EPQcECDXCs9ykceHoh99njOFmWf3AUq hbr80CU+U1pGRHkgdIP49Ugu++DYTtMJ/ysO0bI= X-Google-Smtp-Source: ABdhPJy9s+z+QUT6e6AwiRpwZUDZbAebS2l4PqraMxyCjwb+g0iO2x2R8F8cV79dQdDPVNcRmEYpJAup0Ee1IAnJOq0= X-Received: by 2002:a05:6402:2751:: with SMTP id z17mr32892978edd.290.1630467984022; Tue, 31 Aug 2021 20:46:24 -0700 (PDT) MIME-Version: 1.0 References: <20210817202146.3218-1-shy828301@gmail.com> <20210831233839.afaenhn32nx6m2fq@box.shutemov.name> In-Reply-To: <20210831233839.afaenhn32nx6m2fq@box.shutemov.name> From: Yang Shi Date: Tue, 31 Aug 2021 20:46:11 -0700 Message-ID: Subject: Re: [RFC PATCH] mm: khugepaged: don't carry huge page to the next loop for !CONFIG_NUMA To: "Kirill A. Shutemov" Cc: Hugh Dickins , "Kirill A. Shutemov" , Andrew Morton , Linux MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 31, 2021 at 4:38 PM Kirill A. Shutemov wrote: > > On Mon, Aug 30, 2021 at 11:49:43AM -0700, Yang Shi wrote: > > Gently ping... > > > > Does this patch make sense? BTW, I have a couple of other khugepaged > > related patches in my queue. I plan to send them with this patch > > together. It would be great to hear some feedback before resending > > this one. > > I don't really care for !NUMA optimization. I believe that most of setups > that benefit from THP has NUMA enabled compile time. Agreed. > > But if you wanna to go this path, make an effort to cleanup other > artifacts for the !NUMA optimization: the ifdef has to be gone and all > callers of these helpers has to be revisited. There's more opportunities to > cleanup. Like it is very odd that khugepaged_prealloc_page() frees the > page. Yes, they are gone in this patch. The only remaining for !NUMA is khugepaged_find_target_node() which just returns 0. > > > -- > Kirill A. Shutemov From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A60EC432BE for ; Wed, 1 Sep 2021 03:46:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AF51E601FF for ; Wed, 1 Sep 2021 03:46:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AF51E601FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 19CC08D0001; Tue, 31 Aug 2021 23:46:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 14D266B0073; Tue, 31 Aug 2021 23:46:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 013A68D0001; Tue, 31 Aug 2021 23:46:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0178.hostedemail.com [216.40.44.178]) by kanga.kvack.org (Postfix) with ESMTP id E277A6B0072 for ; Tue, 31 Aug 2021 23:46:25 -0400 (EDT) Received: from smtpin35.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9017D235C5 for ; Wed, 1 Sep 2021 03:46:25 +0000 (UTC) X-FDA: 78537617130.35.66CF341 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by imf06.hostedemail.com (Postfix) with ESMTP id 4CD87801A89C for ; Wed, 1 Sep 2021 03:46:25 +0000 (UTC) Received: by mail-ed1-f48.google.com with SMTP id r7so1726824edd.6 for ; Tue, 31 Aug 2021 20:46:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MbuNJ6AQL86qsQ1Xnhu/tEYDLNw3wqiKq1TKFtDIHSI=; b=V8+dKyDWIxJq3KqvBhqnqbWOUcoOIAMkmOAR9HytZqqlK/C9bxciBAsOOeQ7Bgyoyh jtQsc7rtiNzaRliiI3M3GSFW3JdcHFkG2RKGCDgp1f0SNHlZoDBceDDeulwneZYwMlak Ykct7OZadYrQgwOWGddzIa5MaM0ZcdxNhfNPgxbA5y16ReSo+UjegTI3iFx5X5/UCUvV tP8Q4Dnd1RGcoSsW7g08iLtU3IU/56QDzxoGMqPg8vIPIMuZ4EyMnz4N8XyXcrAf9ak/ 6qAnD6Mbv6tzrHzCdYacF5Utbga5owTJXjKdllt6ijDLKGXVcdp3NKvNgfUiVVtpty9d j+7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MbuNJ6AQL86qsQ1Xnhu/tEYDLNw3wqiKq1TKFtDIHSI=; b=M/EnDNurs9hFuvPmByhFEiFICNRzKdxX4ahROjm36rkDIvXeik14Q9ymWVX1g9Dl8T W27FhGsFedoiqjrxChk9DI73d2g5/AnixVgSrQfgI03S9EtDUHUsA7rWroke+cHh3C1H FGt4NcxL3UWy4T1wseIevmSv+NlirlX9CM5s4ABU+hb9l21GbOVWdNSoEt1MuLaYLLNA bjhSN7rdX+EWbAtBdQd3G1jYOAxdzqjGlMxMt3mX2oZcU9xi5bp0j0l1D24f+mS4M4JA XcsVE+5+JOPl4Yo9p2RvZtCPOvetwtfBegkcSFdo1Hf3SmA2UGrGU+3ztxbTThatbWGz y5/A== X-Gm-Message-State: AOAM530AN7AizYf0RCGI9B7Lwmq5m4trQRktnCLe+6K/a2sXAsgm4pvu 9LBKBQRpE7OIIIrOQD2/tAUmbUOEPvnVQkfW4GE= X-Google-Smtp-Source: ABdhPJy9s+z+QUT6e6AwiRpwZUDZbAebS2l4PqraMxyCjwb+g0iO2x2R8F8cV79dQdDPVNcRmEYpJAup0Ee1IAnJOq0= X-Received: by 2002:a05:6402:2751:: with SMTP id z17mr32892978edd.290.1630467984022; Tue, 31 Aug 2021 20:46:24 -0700 (PDT) MIME-Version: 1.0 References: <20210817202146.3218-1-shy828301@gmail.com> <20210831233839.afaenhn32nx6m2fq@box.shutemov.name> In-Reply-To: <20210831233839.afaenhn32nx6m2fq@box.shutemov.name> From: Yang Shi Date: Tue, 31 Aug 2021 20:46:11 -0700 Message-ID: Subject: Re: [RFC PATCH] mm: khugepaged: don't carry huge page to the next loop for !CONFIG_NUMA To: "Kirill A. Shutemov" Cc: Hugh Dickins , "Kirill A. Shutemov" , Andrew Morton , Linux MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=V8+dKyDW; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=shy828301@gmail.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 4CD87801A89C X-Stat-Signature: 9g3hwzk55f8ddktuapzfj5yoye619opf X-HE-Tag: 1630467985-25789 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 31, 2021 at 4:38 PM Kirill A. Shutemov wrote: > > On Mon, Aug 30, 2021 at 11:49:43AM -0700, Yang Shi wrote: > > Gently ping... > > > > Does this patch make sense? BTW, I have a couple of other khugepaged > > related patches in my queue. I plan to send them with this patch > > together. It would be great to hear some feedback before resending > > this one. > > I don't really care for !NUMA optimization. I believe that most of setups > that benefit from THP has NUMA enabled compile time. Agreed. > > But if you wanna to go this path, make an effort to cleanup other > artifacts for the !NUMA optimization: the ifdef has to be gone and all > callers of these helpers has to be revisited. There's more opportunities to > cleanup. Like it is very odd that khugepaged_prealloc_page() frees the > page. Yes, they are gone in this patch. The only remaining for !NUMA is khugepaged_find_target_node() which just returns 0. > > > -- > Kirill A. Shutemov