From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D5BEC4338F for ; Fri, 6 Aug 2021 20:37:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F12E161163 for ; Fri, 6 Aug 2021 20:37:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244996AbhHFUhw (ORCPT ); Fri, 6 Aug 2021 16:37:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231132AbhHFUhu (ORCPT ); Fri, 6 Aug 2021 16:37:50 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B8AEC0613CF for ; Fri, 6 Aug 2021 13:37:33 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id hw6so17051049ejc.10 for ; Fri, 06 Aug 2021 13:37:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rnRuiZF4wapvbgI++n47Sa9nKibpjHl8Lh0ADOaBeYg=; b=eEpzkK2dRVMf/opaWqwbLuvJtTGiaJXKGDN98t+EJ342zn+WVqt6eNMxsKTSZLbXm7 RVaORxR4atyRFqcAjJokFF4tnTXEsMZ/hu54tSlzvqlW9OCiTkFrW81yjfl6JTH50xL5 OUoJJD+Jc7YclzZH4YkXumgKS2LlDWJZC0axi3GJUADrtSZ/RoJy7EkzE03VnQU5HH3e KYRkP+LvLk2RBAJtnI1DIl439EdeHFz/ECDYsr+k4OVt1DGqCmwxRQAOOwSGTvdeftT4 WNE1l5+VWfm/ceS6Qni4vK4I/kxKoQkjGfPT2EB7brSanD8A5TnIZpNfDwoEKLOR1Kaq HpDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rnRuiZF4wapvbgI++n47Sa9nKibpjHl8Lh0ADOaBeYg=; b=qRucTkZ0DaE0mHoEUxtRuMpmlk7wEgpkkQUj+gsHIBYPTjafgme8MMrRuuqcdJbd9H OqLPh3Xkj9hJdSmvsM5eJ8BSXsKPf0FTCnoY7ZFdv9kekhPSkTywHTEwzo7LtvHzNZPB Dg0galB3BsOcODqJP6nHhTg79beCd+Q8Iu4K3b2gXxK+20p30khzn6QS/AdKPq1LbFJ0 WslEPfapwC/LP15PW9ia4hfiuWOD895qimo/J4wRq6yQ2uYI5JDnqdd8cFaMTBU6fWIo VrQM5raAGGOJbt+QGtmzpzCArU7gHzZ7OW1VdWP66okv5EqTqHYNK3aSi4ck/hM/wq1S F3Eg== X-Gm-Message-State: AOAM533nM1Jdp2bc0TUbLz2k/tmW4dyGzPbjZ9OGNMv1geqVpA8gWbUU S5xBOk2cdpGFzt0nlpY27bfAfVzA7PStoKQYvt4= X-Google-Smtp-Source: ABdhPJwCI64DMpKDOlHMB7D/lwU06tFEdyqcc6roHwThIvbe/hrLvCwmmHPtT48NkvvEdb/Ad/cTWgiGTrl10MaBlqs= X-Received: by 2002:a17:906:c182:: with SMTP id g2mr11279686ejz.507.1628282252280; Fri, 06 Aug 2021 13:37:32 -0700 (PDT) MIME-Version: 1.0 References: <20210723080000.93953-1-ying.huang@intel.com> <24187e5e-069-9f3f-cefe-39ac70783753@google.com> <8735rr54i9.fsf@yhuang6-desk2.ccr.corp.intel.com> <704d597-443b-32f-84eb-524a58dd8ef@google.com> In-Reply-To: From: Yang Shi Date: Fri, 6 Aug 2021 13:37:19 -0700 Message-ID: Subject: Re: [PATCH] mm,shmem: Fix a typo in shmem_swapin_page() To: Hugh Dickins Cc: Matthew Wilcox , "Huang, Ying" , Andrew Morton , David Hildenbrand , Linux MM , Linux Kernel Mailing List , Miaohe Lin , Johannes Weiner , Michal Hocko , Joonsoo Kim , Minchan Kim Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 5, 2021 at 11:01 PM Hugh Dickins wrote: > > On Thu, 5 Aug 2021, Yang Shi wrote: > > On Tue, Aug 3, 2021 at 10:34 PM Hugh Dickins wrote: > > > > > > I've never seen the swapoff race claimed by Miaohe, and don't expect to; > > > but he's probably right, given the current code. I just dislike adding > > > unnecessary complexity, and siting it in the wrong place (mm/shmem.c). > > > > > > Yang, is it possible that 5.1 commit 8fd2e0b505d1 ("mm: swap: check if > > > swap backing device is congested or not") was actually developed and > > > measured on 4.1 or earlier, which still had blk_set_queue_congested()? > > > > I forgot the exact version, but definitely not 4.1 or earlier. Maybe > > 4.19 or earlier. I'm not familiar with how block layer detect > > congestion, if the logic was changed, hence the optimization doesn't > > stand anymore nowadays, I'm totally fine to remove it. > > You drove me back to look more closely. blk_set_queue_congested() > vanished from include/linux/blkdev.h in 4.2, but blk_set_congested() > appeared then in block/blk-core.c to replace it. blk_set_congested() > vanished (along with all references to "congested" in blk-core.c) in > 5.0, then your commit (most probably tested on 4.19) went into 5.1 - > just after it had become redundant! > > Thanks, yes, let's revert that and Miaohe's and Huang's, later on. It should be easier to revert Huang Ying's , then Miaohe's, then mine. > > Hugh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1539C432BE for ; Fri, 6 Aug 2021 20:37:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2B8C861184 for ; Fri, 6 Aug 2021 20:37:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2B8C861184 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 8A5E38D0001; Fri, 6 Aug 2021 16:37:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 82E826B0071; Fri, 6 Aug 2021 16:37:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CF0C8D0001; Fri, 6 Aug 2021 16:37:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0249.hostedemail.com [216.40.44.249]) by kanga.kvack.org (Postfix) with ESMTP id 4F3576B006C for ; Fri, 6 Aug 2021 16:37:34 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id F2B368249980 for ; Fri, 6 Aug 2021 20:37:33 +0000 (UTC) X-FDA: 78445816428.03.17F4922 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by imf22.hostedemail.com (Postfix) with ESMTP id AC9A4B250 for ; Fri, 6 Aug 2021 20:37:33 +0000 (UTC) Received: by mail-ej1-f52.google.com with SMTP id h9so17073045ejs.4 for ; Fri, 06 Aug 2021 13:37:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rnRuiZF4wapvbgI++n47Sa9nKibpjHl8Lh0ADOaBeYg=; b=eEpzkK2dRVMf/opaWqwbLuvJtTGiaJXKGDN98t+EJ342zn+WVqt6eNMxsKTSZLbXm7 RVaORxR4atyRFqcAjJokFF4tnTXEsMZ/hu54tSlzvqlW9OCiTkFrW81yjfl6JTH50xL5 OUoJJD+Jc7YclzZH4YkXumgKS2LlDWJZC0axi3GJUADrtSZ/RoJy7EkzE03VnQU5HH3e KYRkP+LvLk2RBAJtnI1DIl439EdeHFz/ECDYsr+k4OVt1DGqCmwxRQAOOwSGTvdeftT4 WNE1l5+VWfm/ceS6Qni4vK4I/kxKoQkjGfPT2EB7brSanD8A5TnIZpNfDwoEKLOR1Kaq HpDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rnRuiZF4wapvbgI++n47Sa9nKibpjHl8Lh0ADOaBeYg=; b=Qc7CWkZ+GAX9A379HfdazXfCbegZ2Yl98osqgXjU1ZZqzfBhk9ZVqSEihk1xzq0la0 C5/BfPSmILnf1LRUpfP3MKdX2M0ZAgL8wV1oXjT9MPzdj0GcUcdikt85Qr4hpa8GZGD+ GZ+hzLqDtbDCbOlT8AI8B6+rUCTlp56Bdp0QJsWzsB52yJvbj/i3GZVuawgafEE6lqCc h8LjA2HUqphsliypqYXQFdRzYBMA5nDpeZjlFm363ewATA5Rp3jsmkBYpDaIxzBwA8Jj wjbuhTSK/4VIF3x34JoXHEAenCa5re+tqyEKY+SHNvUWebKIQnYGKfEmFrSzKE/IvZhV PZdg== X-Gm-Message-State: AOAM531dkVg7pecV+RMnwqv/9g3/wGTa5rtHFz+S30Sau4Yzky3uUdcm KdjPt498UH+ByGrUfMSjrKytN0JF/MLtc28J9gk= X-Google-Smtp-Source: ABdhPJwCI64DMpKDOlHMB7D/lwU06tFEdyqcc6roHwThIvbe/hrLvCwmmHPtT48NkvvEdb/Ad/cTWgiGTrl10MaBlqs= X-Received: by 2002:a17:906:c182:: with SMTP id g2mr11279686ejz.507.1628282252280; Fri, 06 Aug 2021 13:37:32 -0700 (PDT) MIME-Version: 1.0 References: <20210723080000.93953-1-ying.huang@intel.com> <24187e5e-069-9f3f-cefe-39ac70783753@google.com> <8735rr54i9.fsf@yhuang6-desk2.ccr.corp.intel.com> <704d597-443b-32f-84eb-524a58dd8ef@google.com> In-Reply-To: From: Yang Shi Date: Fri, 6 Aug 2021 13:37:19 -0700 Message-ID: Subject: Re: [PATCH] mm,shmem: Fix a typo in shmem_swapin_page() To: Hugh Dickins Cc: Matthew Wilcox , "Huang, Ying" , Andrew Morton , David Hildenbrand , Linux MM , Linux Kernel Mailing List , Miaohe Lin , Johannes Weiner , Michal Hocko , Joonsoo Kim , Minchan Kim Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=eEpzkK2d; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of shy828301@gmail.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=shy828301@gmail.com X-Stat-Signature: 1ei5x7oosjp5gp84za6115k7hoypyc7r X-Rspamd-Queue-Id: AC9A4B250 X-Rspamd-Server: rspam01 X-HE-Tag: 1628282253-24947 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 5, 2021 at 11:01 PM Hugh Dickins wrote: > > On Thu, 5 Aug 2021, Yang Shi wrote: > > On Tue, Aug 3, 2021 at 10:34 PM Hugh Dickins wrote: > > > > > > I've never seen the swapoff race claimed by Miaohe, and don't expect to; > > > but he's probably right, given the current code. I just dislike adding > > > unnecessary complexity, and siting it in the wrong place (mm/shmem.c). > > > > > > Yang, is it possible that 5.1 commit 8fd2e0b505d1 ("mm: swap: check if > > > swap backing device is congested or not") was actually developed and > > > measured on 4.1 or earlier, which still had blk_set_queue_congested()? > > > > I forgot the exact version, but definitely not 4.1 or earlier. Maybe > > 4.19 or earlier. I'm not familiar with how block layer detect > > congestion, if the logic was changed, hence the optimization doesn't > > stand anymore nowadays, I'm totally fine to remove it. > > You drove me back to look more closely. blk_set_queue_congested() > vanished from include/linux/blkdev.h in 4.2, but blk_set_congested() > appeared then in block/blk-core.c to replace it. blk_set_congested() > vanished (along with all references to "congested" in blk-core.c) in > 5.0, then your commit (most probably tested on 4.19) went into 5.1 - > just after it had become redundant! > > Thanks, yes, let's revert that and Miaohe's and Huang's, later on. It should be easier to revert Huang Ying's , then Miaohe's, then mine. > > Hugh