Re: [PATCH] drm/amdgpu: Remove one duplicated ef removal

From: Mike Lothian <mike@fireburn.co.uk>
To: xinhui pan <xinhui.pan@amd.com>
Cc: alexander.deucher@amd.com, Felix.Kuehling@amd.com,
	christian.koenig@amd.com, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: Remove one duplicated ef removal
Date: Tue, 19 Jul 2022 09:31:47 +0100	[thread overview]
Message-ID: <CAHbf0-Fo4qE1RCaH2uHHW1YTkHb-yFCMnix0rjsq+K1RCMQxSg@mail.gmail.com> (raw)
In-Reply-To: <20220708015346.3027-1-xinhui.pan@amd.com>

With this patch applied on Linus's tree 5.18-rc7 I get the following warning:

drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:1367:20: warning:
unused variable 'pd' [-Wunused-variable]
       struct amdgpu_bo *pd = vm->root.bo;
                         ^
1 warning generated.

It does fix the nullpointer though :D

On Fri, 8 Jul 2022 at 02:55, xinhui pan <xinhui.pan@amd.com> wrote:
>
> That has been done in BO release notify.
>
> Signed-off-by: xinhui pan <xinhui.pan@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> index 0f9811d02f61..49536fa8d269 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> @@ -1583,11 +1583,6 @@ void amdgpu_amdkfd_gpuvm_destroy_cb(struct amdgpu_device *adev,
>         if (!process_info)
>                 return;
>
> -       /* Release eviction fence from PD */
> -       amdgpu_bo_reserve(pd, false);
> -       amdgpu_bo_fence(pd, NULL, false);
> -       amdgpu_bo_unreserve(pd);
> -
>         /* Update process info */
>         mutex_lock(&process_info->lock);
>         process_info->n_vms--;
> --
> 2.34.1
>