From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9079C48BE8 for ; Wed, 16 Jun 2021 15:16:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 326C360FDB for ; Wed, 16 Jun 2021 15:16:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 326C360FDB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=fireburn.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2A183895E7; Wed, 16 Jun 2021 15:16:30 +0000 (UTC) Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 10F6289C29 for ; Wed, 16 Jun 2021 15:16:29 +0000 (UTC) Received: by mail-qk1-x72b.google.com with SMTP id 5so2964522qkc.8 for ; Wed, 16 Jun 2021 08:16:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fireburn-co-uk.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+nhKlZUvmaLvzRtebioASnVTBODgb1PiICRR5qFSU64=; b=F3S+cAhJVu3R7wHPGAV+lzkW559ATZ5NmtSDV08Utq+GVIbHhwKkqhUV1gzHD1N+3l hCj4APJEpLvwNfq1p9M8HtwSC4DivyUzJyXqoSn0qjA9iY4ShXE0JfZIWXY7GEsilrUt oNhwwcAuOrkZF/udSMP10+OwG0eqvQLN8O/01sn/tZKyZeFWFfpwxzEFwpDWzJMT1Wy8 XbtjtvbmGSyxKejUDwamDEupqQNjsjXfJQWxUn/pT1PmarDUUp9/SgzSTtj/gURc4Qb/ M52C/lPIupUftsfrZharTRhqKyavTIPZ1rK22kObNRMu70WUo74H5K0sEPOT6Esyzm1d ZIAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+nhKlZUvmaLvzRtebioASnVTBODgb1PiICRR5qFSU64=; b=Tt7HN7TSHvFOQBeMhi6c6pTfQbKvPTB0t3esGy82zcVXTBPlFAXi8G0KWK4Xx+SNWg xbNGyDHCOakvAF4SwxJTnl4d8gVqU/JB+Ntr/PCs3Q9XhrQ6ssLA/QXplYi4kJoHlac9 bP82bpG6D0WOaAtf+CYKqOvKdi0jsa80hzmBRRJHHG9eyHOsRL7U9PcPIciTxyVKGy7U aAfirzTPIhp8wI39oYhAPXPNhChFDmkh+n6rkzHcpzMPWkHUB7hxYiz+UeWqAPJT/Ohd 0+m3qUkhnq7qacEyacInUufLnxaZKTJgy9t5CE8jG8YO0N570qQXXiOT/nUVi09AYMvo lKEQ== X-Gm-Message-State: AOAM533O/HbxZtxRHGPNN48vudThAk8UHXoUmsbtVbBztDPvqrKthfVG 5Y/TssQuKLeVPQvJlruqRT4CYk2mXyEVoRUqB0lr1Sh0TqGZ0wfX X-Google-Smtp-Source: ABdhPJyLAVzG8VYbOVPOqAv1B8fdPgK4gHbuoEol8yn536Sb/mSUxp4SZ3moZt04n2ytoNtQfBYPbVuMf7xtoayXBW0= X-Received: by 2002:a37:b6c4:: with SMTP id g187mr515094qkf.491.1623856588081; Wed, 16 Jun 2021 08:16:28 -0700 (PDT) MIME-Version: 1.0 References: <20210616001302.84233-1-matthew.brost@intel.com> In-Reply-To: <20210616001302.84233-1-matthew.brost@intel.com> From: Mike Lothian Date: Wed, 16 Jun 2021 16:16:17 +0100 Message-ID: Subject: Re: [Intel-gfx] [PATCH 0/3] Update firmware to v62.0.0 To: Matthew Brost Content-Type: multipart/alternative; boundary="000000000000197ee605c4e3937d" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel Graphics Development , Maling list - DRI developers Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --000000000000197ee605c4e3937d Content-Type: text/plain; charset="UTF-8" Hi Is there a place where we can download these new firmware images? Cheers Mike On Wed, 16 Jun 2021 at 00:55, Matthew Brost wrote: > As part of enabling GuC submission [1] we need to update to the latest > and greatest firmware. This series does that. All backwards > compatibility breaking changes squashed into a single patch #2. Same > series sent to trybot [2] forcing GuC to be enabled to ensure we haven't > broke something. > > v2: Address comments, looking for remaning RBs so patches can be > squashed and sent for CI > v3: Delete a few unused defines, squash patches > v4: Add values back into kernel doc, fix docs warning > > Signed-off-by: Matthew Brost > > [1] https://patchwork.freedesktop.org/series/89844 > [2] https://patchwork.freedesktop.org/series/91341 > > Michal Wajdeczko (3): > drm/i915/guc: Introduce unified HXG messages > drm/i915/guc: Update firmware to v62.0.0 > drm/i915/doc: Include GuC ABI documentation > > Documentation/gpu/i915.rst | 8 + > .../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h | 107 ++++++ > .../gt/uc/abi/guc_communication_ctb_abi.h | 126 +++++-- > .../gt/uc/abi/guc_communication_mmio_abi.h | 65 ++-- > .../gpu/drm/i915/gt/uc/abi/guc_messages_abi.h | 213 +++++++++++ > drivers/gpu/drm/i915/gt/uc/intel_guc.c | 107 ++++-- > drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 45 +-- > drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 356 +++++++++--------- > drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h | 6 +- > drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h | 75 +--- > drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 29 +- > drivers/gpu/drm/i915/gt/uc/intel_guc_log.h | 6 +- > drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 26 +- > 13 files changed, 748 insertions(+), 421 deletions(-) > > -- > 2.28.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > --000000000000197ee605c4e3937d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

Is there a place where we can downlo= ad these new firmware images?

Cheers
Mike

On Wed, 16 Jun 2021 at 00:55, Matthew Brost <matthew.brost@intel.com> wrote= :
As part of ena= bling GuC submission [1] we need to update to the latest
and greatest firmware. This series does that. All backwards
compatibility breaking changes squashed into a single patch #2. Same
series sent to trybot [2] forcing GuC to be enabled to ensure we haven'= t
broke something.

v2: Address comments, looking for remaning RBs so patches can be
squashed and sent for CI
v3: Delete a few unused defines, squash patches
v4: Add values back into kernel doc, fix docs warning

Signed-off-by: Matthew Brost <matthew.brost@intel.com>

[1] https://patchwork.freedesktop.org/series/89844=
[2] https://patchwork.freedesktop.org/series/91341=

Michal Wajdeczko (3):
=C2=A0 drm/i915/guc: Introduce unified HXG messages
=C2=A0 drm/i915/guc: Update firmware to v62.0.0
=C2=A0 drm/i915/doc: Include GuC ABI documentation

=C2=A0Documentation/gpu/i915.rst=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A08 +
=C2=A0.../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h=C2=A0 | 107 ++++++
=C2=A0.../gt/uc/abi/guc_communication_ctb_abi.h=C2=A0 =C2=A0 =C2=A0| 126 ++= +++--
=C2=A0.../gt/uc/abi/guc_communication_mmio_abi.h=C2=A0 =C2=A0 |=C2=A0 65 ++= --
=C2=A0.../gpu/drm/i915/gt/uc/abi/guc_messages_abi.h | 213 +++++++++++
=C2=A0drivers/gpu/drm/i915/gt/uc/intel_guc.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 | 1= 07 ++++--
=C2=A0drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c=C2=A0 =C2=A0 |=C2=A0 45 +-= -
=C2=A0drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c=C2=A0 =C2=A0 =C2=A0| 356 ++= +++++++---------
=C2=A0drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h=C2=A0 =C2=A0 =C2=A0|=C2=A0 = =C2=A06 +-
=C2=A0drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h=C2=A0 =C2=A0|=C2=A0 75 +-= --
=C2=A0drivers/gpu/drm/i915/gt/uc/intel_guc_log.c=C2=A0 =C2=A0 |=C2=A0 29 +-=
=C2=A0drivers/gpu/drm/i915/gt/uc/intel_guc_log.h=C2=A0 =C2=A0 |=C2=A0 =C2= =A06 +-
=C2=A0drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c=C2=A0 =C2=A0 =C2=A0 |=C2=A0 = 26 +-
=C2=A013 files changed, 748 insertions(+), 421 deletions(-)

--
2.28.0

_______________________________________________
Intel-gfx mailing list
Intel-= gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listin= fo/intel-gfx
--000000000000197ee605c4e3937d-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB0FEC48BE5 for ; Wed, 16 Jun 2021 15:16:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18A7160FDB for ; Wed, 16 Jun 2021 15:16:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18A7160FDB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=fireburn.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B3E8589301; Wed, 16 Jun 2021 15:16:29 +0000 (UTC) Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2A1446E5CC for ; Wed, 16 Jun 2021 15:16:29 +0000 (UTC) Received: by mail-qk1-x731.google.com with SMTP id c138so2986177qkg.5 for ; Wed, 16 Jun 2021 08:16:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fireburn-co-uk.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+nhKlZUvmaLvzRtebioASnVTBODgb1PiICRR5qFSU64=; b=F3S+cAhJVu3R7wHPGAV+lzkW559ATZ5NmtSDV08Utq+GVIbHhwKkqhUV1gzHD1N+3l hCj4APJEpLvwNfq1p9M8HtwSC4DivyUzJyXqoSn0qjA9iY4ShXE0JfZIWXY7GEsilrUt oNhwwcAuOrkZF/udSMP10+OwG0eqvQLN8O/01sn/tZKyZeFWFfpwxzEFwpDWzJMT1Wy8 XbtjtvbmGSyxKejUDwamDEupqQNjsjXfJQWxUn/pT1PmarDUUp9/SgzSTtj/gURc4Qb/ M52C/lPIupUftsfrZharTRhqKyavTIPZ1rK22kObNRMu70WUo74H5K0sEPOT6Esyzm1d ZIAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+nhKlZUvmaLvzRtebioASnVTBODgb1PiICRR5qFSU64=; b=bqpZZX+h0Z6Hq8RSQlt7PXpodHVL0/03H4QP/yesBnfdT3Jj6U2S+B17sGa8J6I5iS SdcCdAqrwkWi5V1Sp3mBE4AAzVWSowq6UJT7J+8a3zxKnaFRTr7RD9H+fjeXxFBIBj8f G7wUjR+4ozN9mURLxqcfOrBm0CuBX3BlKJOcrvCnpa+S8Z+VmppbuPnnGs/60vBRv1NI zgVn6oIwl7MCVLYr80fkKtD+zvo2P3crOsEvcnJuYs2/RyEDI4xIbNQGLWvFr+OPnebt RgXVSWTtGDwbLv2j3yx7JI1Xx2SyKbWI5OsWhG2DV8vpn3z7xhOAkGcQHapOaR+w5Aij D0XA== X-Gm-Message-State: AOAM530CLcByRPdlIC4mK0C2Pb/Np3zuU2bJOrQD4rwRz3iWexE+KnaR pKcl00xk8fFwxykP1jeui/0B+zJk59cnA0/HqluU4Q== X-Google-Smtp-Source: ABdhPJyLAVzG8VYbOVPOqAv1B8fdPgK4gHbuoEol8yn536Sb/mSUxp4SZ3moZt04n2ytoNtQfBYPbVuMf7xtoayXBW0= X-Received: by 2002:a37:b6c4:: with SMTP id g187mr515094qkf.491.1623856588081; Wed, 16 Jun 2021 08:16:28 -0700 (PDT) MIME-Version: 1.0 References: <20210616001302.84233-1-matthew.brost@intel.com> In-Reply-To: <20210616001302.84233-1-matthew.brost@intel.com> From: Mike Lothian Date: Wed, 16 Jun 2021 16:16:17 +0100 Message-ID: To: Matthew Brost Subject: Re: [Intel-gfx] [PATCH 0/3] Update firmware to v62.0.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel Graphics Development , Maling list - DRI developers Content-Type: multipart/mixed; boundary="===============0675141556==" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" --===============0675141556== Content-Type: multipart/alternative; boundary="000000000000197ee605c4e3937d" --000000000000197ee605c4e3937d Content-Type: text/plain; charset="UTF-8" Hi Is there a place where we can download these new firmware images? Cheers Mike On Wed, 16 Jun 2021 at 00:55, Matthew Brost wrote: > As part of enabling GuC submission [1] we need to update to the latest > and greatest firmware. This series does that. All backwards > compatibility breaking changes squashed into a single patch #2. Same > series sent to trybot [2] forcing GuC to be enabled to ensure we haven't > broke something. > > v2: Address comments, looking for remaning RBs so patches can be > squashed and sent for CI > v3: Delete a few unused defines, squash patches > v4: Add values back into kernel doc, fix docs warning > > Signed-off-by: Matthew Brost > > [1] https://patchwork.freedesktop.org/series/89844 > [2] https://patchwork.freedesktop.org/series/91341 > > Michal Wajdeczko (3): > drm/i915/guc: Introduce unified HXG messages > drm/i915/guc: Update firmware to v62.0.0 > drm/i915/doc: Include GuC ABI documentation > > Documentation/gpu/i915.rst | 8 + > .../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h | 107 ++++++ > .../gt/uc/abi/guc_communication_ctb_abi.h | 126 +++++-- > .../gt/uc/abi/guc_communication_mmio_abi.h | 65 ++-- > .../gpu/drm/i915/gt/uc/abi/guc_messages_abi.h | 213 +++++++++++ > drivers/gpu/drm/i915/gt/uc/intel_guc.c | 107 ++++-- > drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 45 +-- > drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 356 +++++++++--------- > drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h | 6 +- > drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h | 75 +--- > drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 29 +- > drivers/gpu/drm/i915/gt/uc/intel_guc_log.h | 6 +- > drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 26 +- > 13 files changed, 748 insertions(+), 421 deletions(-) > > -- > 2.28.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > --000000000000197ee605c4e3937d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

Is there a place where we can downlo= ad these new firmware images?

Cheers
Mike

On Wed, 16 Jun 2021 at 00:55, Matthew Brost <matthew.brost@intel.com> wrote= :
As part of ena= bling GuC submission [1] we need to update to the latest
and greatest firmware. This series does that. All backwards
compatibility breaking changes squashed into a single patch #2. Same
series sent to trybot [2] forcing GuC to be enabled to ensure we haven'= t
broke something.

v2: Address comments, looking for remaning RBs so patches can be
squashed and sent for CI
v3: Delete a few unused defines, squash patches
v4: Add values back into kernel doc, fix docs warning

Signed-off-by: Matthew Brost <matthew.brost@intel.com>

[1] https://patchwork.freedesktop.org/series/89844=
[2] https://patchwork.freedesktop.org/series/91341=

Michal Wajdeczko (3):
=C2=A0 drm/i915/guc: Introduce unified HXG messages
=C2=A0 drm/i915/guc: Update firmware to v62.0.0
=C2=A0 drm/i915/doc: Include GuC ABI documentation

=C2=A0Documentation/gpu/i915.rst=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A08 +
=C2=A0.../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h=C2=A0 | 107 ++++++
=C2=A0.../gt/uc/abi/guc_communication_ctb_abi.h=C2=A0 =C2=A0 =C2=A0| 126 ++= +++--
=C2=A0.../gt/uc/abi/guc_communication_mmio_abi.h=C2=A0 =C2=A0 |=C2=A0 65 ++= --
=C2=A0.../gpu/drm/i915/gt/uc/abi/guc_messages_abi.h | 213 +++++++++++
=C2=A0drivers/gpu/drm/i915/gt/uc/intel_guc.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 | 1= 07 ++++--
=C2=A0drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c=C2=A0 =C2=A0 |=C2=A0 45 +-= -
=C2=A0drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c=C2=A0 =C2=A0 =C2=A0| 356 ++= +++++++---------
=C2=A0drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h=C2=A0 =C2=A0 =C2=A0|=C2=A0 = =C2=A06 +-
=C2=A0drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h=C2=A0 =C2=A0|=C2=A0 75 +-= --
=C2=A0drivers/gpu/drm/i915/gt/uc/intel_guc_log.c=C2=A0 =C2=A0 |=C2=A0 29 +-=
=C2=A0drivers/gpu/drm/i915/gt/uc/intel_guc_log.h=C2=A0 =C2=A0 |=C2=A0 =C2= =A06 +-
=C2=A0drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c=C2=A0 =C2=A0 =C2=A0 |=C2=A0 = 26 +-
=C2=A013 files changed, 748 insertions(+), 421 deletions(-)

--
2.28.0

_______________________________________________
Intel-gfx mailing list
Intel-= gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listin= fo/intel-gfx
--000000000000197ee605c4e3937d-- --===============0675141556== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0675141556==--