From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4D48C43603 for ; Wed, 18 Dec 2019 12:52:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 96703206D7 for ; Wed, 18 Dec 2019 12:52:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ALdVztwk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726932AbfLRMwH (ORCPT ); Wed, 18 Dec 2019 07:52:07 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:44001 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726707AbfLRMwG (ORCPT ); Wed, 18 Dec 2019 07:52:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576673525; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Fz1C4BpCn0XBwscKEK5CV3W7xgzsRCUzKeY/3qkO/Js=; b=ALdVztwkzkdXKEy3By+x7WHaqWnwgcik+LH4fVx8vFtgIJoI8CHWnwYouwFXRytxKvxs61 KA4Vyzy2krwQPUbHhcn3c3qZO3emYmYo0zKIw+c0JLN86STuCjqZ66tFchC/BWCO8sKCYB fd/ekT/mMJmf0koHarmiKWYJYCmRKno= Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-276-xY7yRlSGMNCn0yZuBunk-g-1; Wed, 18 Dec 2019 07:52:04 -0500 X-MC-Unique: xY7yRlSGMNCn0yZuBunk-g-1 Received: by mail-ot1-f72.google.com with SMTP id v4so1043771otp.21 for ; Wed, 18 Dec 2019 04:52:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Fz1C4BpCn0XBwscKEK5CV3W7xgzsRCUzKeY/3qkO/Js=; b=bi1TGZHkWOJe73MV3M9oVZDvdCUBwt8ByGFmOLVRoISMo7MgGJJjlNSlVxmErW2/ez 6+5MDj+UxiADJuQHIAWAiBwGzixIm40dNMJnqxk/DTNAM1H2o/S2fV6sF2IymhBM4T8V JcMcba30P7wLWUWswf5v00PayaiOwZKBdBR7t6vLN0kMB4CL+WhM/A1EyCiPZVytdMki 6Q0zBxVVpTB4mg3Bjrg1TBvdkve7j1GdBIM1qd1zCDZln+w7SHfQOeQjT+a6Cjzpn27n a2Ffywb+HGHAp/wZ/x7xTo4RCp/7laPBWoZhj1lowrksT80h+3e/OfAPFpAOv84KC62R Ly5g== X-Gm-Message-State: APjAAAXksxvThf0EhaaD+uCYepHnZd6Kfr+pq1e7nziwoR/txqeu80PH sSPd9N1TVo9Ol5d8fTcTAfPDjKo2jE9PLI/IoAbikhbxBdo+nodowGS9EwpbiBKbwer4so4/l+R J6XKcg5skVVcPqVFCmTB/d02ssLg7+33vnpm13X5ENA== X-Received: by 2002:aca:b50b:: with SMTP id e11mr235718oif.72.1576673523443; Wed, 18 Dec 2019 04:52:03 -0800 (PST) X-Google-Smtp-Source: APXvYqzNnW7+BNpz9v4T2rGe5JN9P0bnFFK+0053Y4EXekhxOjcVx8wn/QURXj7KOopsEFATg9yxdbSk8mvoMerik3c= X-Received: by 2002:aca:b50b:: with SMTP id e11mr235716oif.72.1576673523237; Wed, 18 Dec 2019 04:52:03 -0800 (PST) MIME-Version: 1.0 References: <20191106190239.20860-1-agruenba@redhat.com> <20191218124346.GC19387@quack2.suse.cz> In-Reply-To: <20191218124346.GC19387@quack2.suse.cz> From: Andreas Gruenbacher Date: Wed, 18 Dec 2019 13:51:52 +0100 Message-ID: Subject: Re: [PATCH] fs: Fix overflow in block_page_mkwrite To: Jan Kara Cc: Alexander Viro , linux-fsdevel , Christoph Hellwig Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Hi Jan, On Wed, Dec 18, 2019 at 1:43 PM Jan Kara wrote: > On Wed 06-11-19 20:02:39, Andreas Gruenbacher wrote: > > On architectures where ssize_t is wider than pgoff_t, the expression > > ((page->index + 1) << PAGE_SHIFT) can overflow. Rewrite to use the page > > offset, which we already compute here anyway. > > > > Signed-off-by: Andreas Gruenbacher > > This patch seems to have fallen through the cracks? Al? There's been a v2 of this patch [*] and I'm about to send out a v3, so please ignore this first version. Thanks, Andreas [*] https://lore.kernel.org/linux-fsdevel/20191129142045.7215-1-agruenba@redhat.com/