From: Andreas Gruenbacher <agruenba@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] gfs2: Add missing rcu locking for glock lookup
Date: Wed, 22 Feb 2017 16:34:26 +0100 [thread overview]
Message-ID: <CAHc6FU538htYk++DfR4rQvw9syq0kKHQLgsWp86cruqBvTh5rQ@mail.gmail.com> (raw)
In-Reply-To: <4e990a69-aed5-4272-cd29-e1ba1baae801@redhat.com>
On Wed, Feb 22, 2017 at 4:29 PM, Steven Whitehouse <swhiteho@redhat.com> wrote:
> There should be no need to retry at all. Either the new entry will be added
> to the hash table, or it will find an existing entry in the table. Is there
> really some way this can fail for some reason?
Yes, we may find an existing entry but by the time we try to get a
lockref, the entry may be dead. In that case, the right thing to do is
to retry the insert.
Andreas
next prev parent reply other threads:[~2017-02-22 15:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 15:09 [Cluster-devel] [PATCH] gfs2: Add missing rcu locking for glock lookup Andreas Gruenbacher
2017-02-22 15:13 ` Steven Whitehouse
2017-02-22 15:26 ` Andreas Gruenbacher
2017-02-22 15:28 ` Andreas Gruenbacher
2017-02-22 15:29 ` Steven Whitehouse
2017-02-22 15:34 ` Andreas Gruenbacher [this message]
2017-02-22 15:50 ` Steven Whitehouse
2017-02-22 15:18 ` Andrew Price
2017-02-22 19:19 ` Bob Peterson
2017-02-23 10:04 ` Andrew Price
2017-02-23 13:08 ` Bob Peterson
2017-02-23 14:32 ` Andrew Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHc6FU538htYk++DfR4rQvw9syq0kKHQLgsWp86cruqBvTh5rQ@mail.gmail.com \
--to=agruenba@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.