From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail-vk0-f42.google.com ([209.85.213.42]:35985 "EHLO
	mail-vk0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750747AbcD0RKM (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 27 Apr 2016 13:10:12 -0400
Received: by mail-vk0-f42.google.com with SMTP id o133so1541765vka.3
        for <linux-fsdevel@vger.kernel.org>; Wed, 27 Apr 2016 10:10:11 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <66afb02d-5dba-025a-a5a5-a4cc7510b153@oracle.com>
References: <1461329029-8751-1-git-send-email-agruenba@redhat.com>
	<66afb02d-5dba-025a-a5a5-a4cc7510b153@oracle.com>
Date: Wed, 27 Apr 2016 19:10:11 +0200
Message-ID: <CAHc6FU6WyLG2snePSKWfobnf82TPNN5sb21MoitOvr2739acew@mail.gmail.com>
Subject: Re: [PATCH 1/2] jfs: Clean up xattr name mapping
From: Andreas Gruenbacher <agruenba@redhat.com>
To: Dave Kleikamp <dave.kleikamp@oracle.com>
Cc: Dave Kleikamp <shaggy@kernel.org>,
	jfs-discussion@lists.sourceforge.net,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Wed, Apr 27, 2016 at 4:29 PM, Dave Kleikamp <dave.kleikamp@oracle.com> wrote:
> On 04/22/2016 07:43 AM, Andreas Gruenbacher wrote:
>> Instead of stripping "os2." prefixes in __jfs_setxattr, make callers
>> strip them, as __jfs_getxattr already does.  With that change, use the
>> same name mapping function in jfs_{get,set,remove}xattr.
>>
>> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
>> ---
>>  fs/jfs/xattr.c | 80 ++++++++++++++++++----------------------------------------
>>  1 file changed, 25 insertions(+), 55 deletions(-)
>>
>> diff --git a/fs/jfs/xattr.c b/fs/jfs/xattr.c
>> index 5becc6a..9cdf7dc 100644
>> --- a/fs/jfs/xattr.c
>> +++ b/fs/jfs/xattr.c
>
>  --- cut ---
>
>> @@ -946,18 +926,8 @@ ssize_t jfs_getxattr(struct dentry *dentry, struct inode *inode,
>>       if (!strncmp(name, XATTR_SYSTEM_PREFIX, XATTR_SYSTEM_PREFIX_LEN))
>>               return generic_getxattr(dentry, inode, name, data, buf_size);
>
> Am I missing a prerequisite patch? This patch doesn't apply because
> generic_getxattr() doesn't have  an inode parameter.

This is based on the work.xattr branch of
git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git, sorry. The
additional parameter is the only difference as far as jfs is
concerned.

Thanks,
Andreas