From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Gruenbacher Subject: Re: [PATCH v23 17/22] richacl: Automatic Inheritance Date: Tue, 12 Jul 2016 22:28:15 +0200 Message-ID: References: <1467294433-3222-1-git-send-email-agruenba@redhat.com> <1467294433-3222-18-git-send-email-agruenba@redhat.com> <1468324560.7798.14.camel@redhat.com> <20160712191142.GE449@fieldses.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Jeff Layton , Alexander Viro , Christoph Hellwig , "Theodore Ts'o" , Andreas Dilger , Trond Myklebust , Anna Schumaker , Dave Chinner , linux-ext4 , XFS Developers , LKML , linux-fsdevel , Linux NFS Mailing List , linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux API To: "J. Bruce Fields" Return-path: In-Reply-To: <20160712191142.GE449-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-cifs.vger.kernel.org On Tue, Jul 12, 2016 at 9:11 PM, J. Bruce Fields wrote: > On Tue, Jul 12, 2016 at 07:56:00AM -0400, Jeff Layton wrote: >> Barf. AI seems like a trainwreck waiting to happen. What are the >> chances that userland is going to get this right? > > This is just taken from Windows, so presumably Samba should do the right > thing (with one workaround required--see the discussion of PROTECTED in > the changelog). > >> Still, I do applaud the fact that you're just doing the bare minimum in >> kernel to support userland apps that want this. Thanks for not trying >> to push the propagation of the changed ACEs into the kernel. > > Agreed. But, again, this is just what Windows does. (I wonder whether > there's an OS that's actually tried do any sort of atomic propagation.) NetWare's NSS filesystem did have automatic propagation, but I think that was implemented by composing the permissions along the path to a file at access time. Andreas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751059AbcGLU2S (ORCPT ); Tue, 12 Jul 2016 16:28:18 -0400 Received: from mail-vk0-f49.google.com ([209.85.213.49]:33881 "EHLO mail-vk0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750829AbcGLU2Q (ORCPT ); Tue, 12 Jul 2016 16:28:16 -0400 MIME-Version: 1.0 In-Reply-To: <20160712191142.GE449@fieldses.org> References: <1467294433-3222-1-git-send-email-agruenba@redhat.com> <1467294433-3222-18-git-send-email-agruenba@redhat.com> <1468324560.7798.14.camel@redhat.com> <20160712191142.GE449@fieldses.org> From: Andreas Gruenbacher Date: Tue, 12 Jul 2016 22:28:15 +0200 Message-ID: Subject: Re: [PATCH v23 17/22] richacl: Automatic Inheritance To: "J. Bruce Fields" Cc: Jeff Layton , Alexander Viro , Christoph Hellwig , "Theodore Ts'o" , Andreas Dilger , Trond Myklebust , Anna Schumaker , Dave Chinner , linux-ext4 , XFS Developers , LKML , linux-fsdevel , Linux NFS Mailing List , linux-cifs@vger.kernel.org, Linux API Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 12, 2016 at 9:11 PM, J. Bruce Fields wrote: > On Tue, Jul 12, 2016 at 07:56:00AM -0400, Jeff Layton wrote: >> Barf. AI seems like a trainwreck waiting to happen. What are the >> chances that userland is going to get this right? > > This is just taken from Windows, so presumably Samba should do the right > thing (with one workaround required--see the discussion of PROTECTED in > the changelog). > >> Still, I do applaud the fact that you're just doing the bare minimum in >> kernel to support userland apps that want this. Thanks for not trying >> to push the propagation of the changed ACEs into the kernel. > > Agreed. But, again, this is just what Windows does. (I wonder whether > there's an OS that's actually tried do any sort of atomic propagation.) NetWare's NSS filesystem did have automatic propagation, but I think that was implemented by composing the permissions along the path to a file at access time. Andreas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 9D8587CA1 for ; Tue, 12 Jul 2016 15:28:21 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay3.corp.sgi.com (Postfix) with ESMTP id 17B33AC003 for ; Tue, 12 Jul 2016 13:28:18 -0700 (PDT) Received: from mail-vk0-f48.google.com (mail-vk0-f48.google.com [209.85.213.48]) by cuda.sgi.com with ESMTP id eCjJuSEXZxFUMCyB (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO) for ; Tue, 12 Jul 2016 13:28:16 -0700 (PDT) Received: by mail-vk0-f48.google.com with SMTP id v6so38445804vkb.2 for ; Tue, 12 Jul 2016 13:28:16 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20160712191142.GE449@fieldses.org> References: <1467294433-3222-1-git-send-email-agruenba@redhat.com> <1467294433-3222-18-git-send-email-agruenba@redhat.com> <1468324560.7798.14.camel@redhat.com> <20160712191142.GE449@fieldses.org> From: Andreas Gruenbacher Date: Tue, 12 Jul 2016 22:28:15 +0200 Message-ID: Subject: Re: [PATCH v23 17/22] richacl: Automatic Inheritance List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: "J. Bruce Fields" Cc: linux-cifs@vger.kernel.org, Linux NFS Mailing List , Theodore Ts'o , Jeff Layton , Linux API , Trond Myklebust , LKML , XFS Developers , Christoph Hellwig , Andreas Dilger , Alexander Viro , linux-fsdevel , linux-ext4 , Anna Schumaker On Tue, Jul 12, 2016 at 9:11 PM, J. Bruce Fields wrote: > On Tue, Jul 12, 2016 at 07:56:00AM -0400, Jeff Layton wrote: >> Barf. AI seems like a trainwreck waiting to happen. What are the >> chances that userland is going to get this right? > > This is just taken from Windows, so presumably Samba should do the right > thing (with one workaround required--see the discussion of PROTECTED in > the changelog). > >> Still, I do applaud the fact that you're just doing the bare minimum in >> kernel to support userland apps that want this. Thanks for not trying >> to push the propagation of the changed ACEs into the kernel. > > Agreed. But, again, this is just what Windows does. (I wonder whether > there's an OS that's actually tried do any sort of atomic propagation.) NetWare's NSS filesystem did have automatic propagation, but I think that was implemented by composing the permissions along the path to a file at access time. Andreas _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs