From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andreas Gruenbacher <agruenba@redhat.com>
Date: Wed, 8 Aug 2018 21:21:20 +0200
Subject: [Cluster-devel] [GFS2 PATCH] GFS2: Simplify iterative add loop
	in foreach_descriptor
In-Reply-To: <183182471.770089.1533754323408.JavaMail.zimbra@redhat.com>
References: <17883672.769837.1533754253446.JavaMail.zimbra@redhat.com>
	<183182471.770089.1533754323408.JavaMail.zimbra@redhat.com>
Message-ID: <CAHc6FU7FqkQ336iRaZ6B5yJ6H991GOciPbUnPfKZ-c+cC9xFPA@mail.gmail.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

On 8 August 2018 at 20:52, Bob Peterson <rpeterso@redhat.com> wrote:
> Hi,
>
> Before this patch, function foreach_descriptor repeatedly called
> function gfs2_replay_incr_blk which just incremented the value while
> decrementing another, and checked for wrap. This is a waste of time.
> This patch just adds the value and adjusts it if a wrap occurred.
>
> Signed-off-by: Bob Peterson <rpeterso@redhat.com>

Reviewed-by: Andreas Gruenbacher <agruenba@redhat.com>

> ---
>  fs/gfs2/recovery.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c
> index 0f501f938d1c..6c6b19263b82 100644
> --- a/fs/gfs2/recovery.c
> +++ b/fs/gfs2/recovery.c
> @@ -354,8 +354,9 @@ static int foreach_descriptor(struct gfs2_jdesc *jd, unsigned int start,
>                         return error;
>                 }
>
> -               while (length--)
> -                       gfs2_replay_incr_blk(jd, &start);
> +               start += length;
> +               if (start >= jd->jd_blocks)
> +                       start -= jd->jd_blocks;
>
>                 brelse(bh);
>         }
>