All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matheus Tavares Bernardino <matheus.bernardino@usp.br>
To: Shubham Verma <shubhunic@gmail.com>
Cc: git <git@vger.kernel.org>
Subject: Re: [GSOC] [PATCH] replace test -f with test_path_is_file
Date: Wed, 11 Mar 2020 16:29:22 -0300	[thread overview]
Message-ID: <CAHd-oW6K8Gh=un9znbNzm2rNvvL5s8j0uft8owNADkzjRL8jBg@mail.gmail.com> (raw)
In-Reply-To: <20200311180625.4643-1-shubhunic@gmail.com>

Hi, Shubham. Welcome to the community!

On Wed, Mar 11, 2020 at 3:06 PM Shubham Verma <shubhunic@gmail.com> wrote:
>
> Subject: [GSOC] [PATCH] replace test -f with test_path_is_file

It's common to prefix the patch title with "area: ", where "area"
corresponds to the codebase section which the patch is modifying. This
makes it easier to understand the scope of the change. You can check
what others have been using for this specific file with `git log
--no-merges t/t9801-git-p4-branch.sh`. In this case, I think a better
alternative would be: "t9801: replace test -f with test_path_is_file"

> Although `test -f` has the same functionality as test_path_is_file(), in the case where test_path_is_file() fails, we get much better
> debugging information.
>
> Replace `test -f` with test_path_is_file() so that future developers will have a better experience debugging these test cases.

It's also a good practice to wrap the commit body in 72 columns. This
will, for example, help viewing the message in most terminals. And,
please, add your Signed-off-by[1] in the footer of the message.

[1]: https://github.com/git/git/blob/master/Documentation/SubmittingPatches#L299

> ---
>  t/t9801-git-p4-branch.sh | 38 +++++++++++++++++++-------------------
>  1 file changed, 19 insertions(+), 19 deletions(-)

As for the changes, LGTM :)

      reply	other threads:[~2020-03-11 19:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-11 18:06 [GSOC] [PATCH] replace test -f with test_path_is_file Shubham Verma
2020-03-11 19:29 ` Matheus Tavares Bernardino [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHd-oW6K8Gh=un9znbNzm2rNvvL5s8j0uft8owNADkzjRL8jBg@mail.gmail.com' \
    --to=matheus.bernardino@usp.br \
    --cc=git@vger.kernel.org \
    --cc=shubhunic@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.