From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DB59C3F2D2 for ; Mon, 2 Mar 2020 10:07:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 047272086A for ; Mon, 2 Mar 2020 10:07:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cloud.ionos.com header.i=@cloud.ionos.com header.b="h5K926Fg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727205AbgCBKHt (ORCPT ); Mon, 2 Mar 2020 05:07:49 -0500 Received: from mail-il1-f195.google.com ([209.85.166.195]:42768 "EHLO mail-il1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726887AbgCBKHt (ORCPT ); Mon, 2 Mar 2020 05:07:49 -0500 Received: by mail-il1-f195.google.com with SMTP id x2so8794759ila.9 for ; Mon, 02 Mar 2020 02:07:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.ionos.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sEvmbBIx18PjlG+Fst7P3LZGNqRs/S/n3JaKm9gwzFs=; b=h5K926Fga7LyyArYo87OiT1vOtr93fYl1TTbrfmnU1lvRJcf80lWxzFrBU5FULGj2P TTMALctVEksH1GDYSx0hl+2NsyC68TkvIkrbUKDS/EKUocSv185fRIVb8f2zMN1vqOAf cqwq7YGLyhC118HHJPBTlZovmeuSeSLXsckSpnZxMItUJGyPcnxxTBfzpa4L9dFTga+1 k6ONTOdxPC4Xb97cM2ID1q7Ac3DckJZcx+xUYpGEnDvsZJg9Lm30XSgd4cW6U0uay5ME Xkn2ukesTqNsHgVbj1BjsKM3cWvypJhdV8Esq+FUTC4ffWSytCrYy/ZbmrgA+DcTyo15 yoRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sEvmbBIx18PjlG+Fst7P3LZGNqRs/S/n3JaKm9gwzFs=; b=duOuTniAkcB75kDmXAmeY2leLPzu4CF0rwNgAR3AIhRb3DQmuNk5akn2oitQFS6xii sBB2nuf41EL0vN5xIGqQjcIUG2QiaZOJfTPw0FXtJ3JLDzp04+HBO0lJ+0PblmVuJMyS UMjev/g18fiMlMyE2ZxLtoTzi6w8oUKiv/e6GAYoHPAPhywwG0ogPfNDFkklDNj4NsxB H1KtTXMsEC1ctkB8l72oWMmbOvhstzEj7CS6bhMfYLy4lo+LWsK6IUSfsGrTLQIk0/A9 yyxWbu73KtMPGFg/te5BHHgk0fq4JRwec1xfrWUxr+IdnB9Be+myPB1nVDx2w0Ld+0jc LsQA== X-Gm-Message-State: APjAAAXPzN++X8+zTxioArWbzl24Tp/zukn+Che4gE3Iqy7mZMeTQ70Z HESE6u3AdHaM/A8DCZruDNJWzVrMqP/TXSMMrFkB X-Google-Smtp-Source: APXvYqywElvcmmSxBEwDFPSsZbfOapZ6kkz+QSE41GtzDz5rb4WpCOKYr+hAvQK4RnF0UJ8Ea3J5NVVU2l1d6w+ih0w= X-Received: by 2002:a92:9f4e:: with SMTP id u75mr15300769ili.116.1583143667325; Mon, 02 Mar 2020 02:07:47 -0800 (PST) MIME-Version: 1.0 References: <20200221104721.350-1-jinpuwang@gmail.com> <20200221104721.350-20-jinpuwang@gmail.com> In-Reply-To: From: Danil Kipnis Date: Mon, 2 Mar 2020 11:07:36 +0100 Message-ID: Subject: Re: [PATCH v9 19/25] block/rnbd: server: private header with server structs and functions To: Bart Van Assche Cc: Jack Wang , linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, Jens Axboe , Christoph Hellwig , Sagi Grimberg , Leon Romanovsky , Doug Ledford , Jason Gunthorpe , Jack Wang , rpenyaev@suse.de, pankaj.gupta@cloud.ionos.com Content-Type: text/plain; charset="UTF-8" Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Sun, Mar 1, 2020 at 3:47 AM Bart Van Assche wrote: > > On 2020-02-21 02:47, Jack Wang wrote: > > +/* Structure which binds N devices and N sessions */ > > +struct rnbd_srv_sess_dev { > > + /* Entry inside rnbd_srv_dev struct */ > > + struct list_head dev_list; > > + /* Entry inside rnbd_srv_session struct */ > > + struct list_head sess_list; > > + struct rnbd_dev *rnbd_dev; > > + struct rnbd_srv_session *sess; > > + struct rnbd_srv_dev *dev; > > + struct kobject kobj; > > + struct completion *sysfs_release_compl; > > + u32 device_id; > > + fmode_t open_flags; > > + struct kref kref; > > + struct completion *destroy_comp; > > + char pathname[NAME_MAX]; > > + enum rnbd_access_mode access_mode; > > +}; > Please indent structure members consistently. Anyway: Will do. > Reviewed-by: Bart Van Assche Thank you!