* [PATCH -next] block/rnbd: server: fix error return code in rnbd_srv_create_dev_sysfs()
@ 2020-05-19 9:19 ` Wei Yongjun
0 siblings, 0 replies; 4+ messages in thread
From: Wei Yongjun @ 2020-05-19 9:19 UTC (permalink / raw)
To: Danil Kipnis, Jack Wang, Jens Axboe
Cc: Wei Yongjun, linux-block, kernel-janitors, Hulk Robot
Fix to return negative error code -ENOMEM from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: 8cee532f469b ("block/rnbd: server: sysfs interface functions")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/block/rnbd/rnbd-srv-sysfs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/block/rnbd/rnbd-srv-sysfs.c b/drivers/block/rnbd/rnbd-srv-sysfs.c
index 106775c074d1..5ba1a31ad626 100644
--- a/drivers/block/rnbd/rnbd-srv-sysfs.c
+++ b/drivers/block/rnbd/rnbd-srv-sysfs.c
@@ -52,8 +52,10 @@ int rnbd_srv_create_dev_sysfs(struct rnbd_srv_dev *dev,
dev->dev_sessions_kobj = kobject_create_and_add("sessions",
&dev->dev_kobj);
- if (!dev->dev_sessions_kobj)
+ if (!dev->dev_sessions_kobj) {
+ ret = -ENOMEM;
goto put_dev_kobj;
+ }
bdev_kobj = &disk_to_dev(bdev->bd_disk)->kobj;
ret = sysfs_create_link(&dev->dev_kobj, bdev_kobj, "block_dev");
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH -next] block/rnbd: server: fix error return code in rnbd_srv_create_dev_sysfs()
@ 2020-05-19 9:19 ` Wei Yongjun
0 siblings, 0 replies; 4+ messages in thread
From: Wei Yongjun @ 2020-05-19 9:19 UTC (permalink / raw)
To: Danil Kipnis, Jack Wang, Jens Axboe
Cc: Wei Yongjun, linux-block, kernel-janitors, Hulk Robot
Fix to return negative error code -ENOMEM from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: 8cee532f469b ("block/rnbd: server: sysfs interface functions")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/block/rnbd/rnbd-srv-sysfs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/block/rnbd/rnbd-srv-sysfs.c b/drivers/block/rnbd/rnbd-srv-sysfs.c
index 106775c074d1..5ba1a31ad626 100644
--- a/drivers/block/rnbd/rnbd-srv-sysfs.c
+++ b/drivers/block/rnbd/rnbd-srv-sysfs.c
@@ -52,8 +52,10 @@ int rnbd_srv_create_dev_sysfs(struct rnbd_srv_dev *dev,
dev->dev_sessions_kobj = kobject_create_and_add("sessions",
&dev->dev_kobj);
- if (!dev->dev_sessions_kobj)
+ if (!dev->dev_sessions_kobj) {
+ ret = -ENOMEM;
goto put_dev_kobj;
+ }
bdev_kobj = &disk_to_dev(bdev->bd_disk)->kobj;
ret = sysfs_create_link(&dev->dev_kobj, bdev_kobj, "block_dev");
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] block/rnbd: server: fix error return code in rnbd_srv_create_dev_sysfs()
2020-05-19 9:19 ` Wei Yongjun
@ 2020-05-19 9:37 ` Danil Kipnis
-1 siblings, 0 replies; 4+ messages in thread
From: Danil Kipnis @ 2020-05-19 9:37 UTC (permalink / raw)
To: Wei Yongjun
Cc: Jack Wang, Jens Axboe, linux-block, kernel-janitors, Hulk Robot
On Tue, May 19, 2020 at 11:16 AM Wei Yongjun <weiyongjun1@huawei.com> wrote:
>
> Fix to return negative error code -ENOMEM from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 8cee532f469b ("block/rnbd: server: sysfs interface functions")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/block/rnbd/rnbd-srv-sysfs.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/block/rnbd/rnbd-srv-sysfs.c b/drivers/block/rnbd/rnbd-srv-sysfs.c
> index 106775c074d1..5ba1a31ad626 100644
> --- a/drivers/block/rnbd/rnbd-srv-sysfs.c
> +++ b/drivers/block/rnbd/rnbd-srv-sysfs.c
> @@ -52,8 +52,10 @@ int rnbd_srv_create_dev_sysfs(struct rnbd_srv_dev *dev,
>
> dev->dev_sessions_kobj = kobject_create_and_add("sessions",
> &dev->dev_kobj);
> - if (!dev->dev_sessions_kobj)
> + if (!dev->dev_sessions_kobj) {
> + ret = -ENOMEM;
> goto put_dev_kobj;
> + }
>
> bdev_kobj = &disk_to_dev(bdev->bd_disk)->kobj;
> ret = sysfs_create_link(&dev->dev_kobj, bdev_kobj, "block_dev");
>
Right, thanks you.
Reviewed-by: Danil Kipnis <danil.kipnis@cloud.ionos.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] block/rnbd: server: fix error return code in rnbd_srv_create_dev_sysfs()
@ 2020-05-19 9:37 ` Danil Kipnis
0 siblings, 0 replies; 4+ messages in thread
From: Danil Kipnis @ 2020-05-19 9:37 UTC (permalink / raw)
To: Wei Yongjun
Cc: Jack Wang, Jens Axboe, linux-block, kernel-janitors, Hulk Robot
On Tue, May 19, 2020 at 11:16 AM Wei Yongjun <weiyongjun1@huawei.com> wrote:
>
> Fix to return negative error code -ENOMEM from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 8cee532f469b ("block/rnbd: server: sysfs interface functions")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/block/rnbd/rnbd-srv-sysfs.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/block/rnbd/rnbd-srv-sysfs.c b/drivers/block/rnbd/rnbd-srv-sysfs.c
> index 106775c074d1..5ba1a31ad626 100644
> --- a/drivers/block/rnbd/rnbd-srv-sysfs.c
> +++ b/drivers/block/rnbd/rnbd-srv-sysfs.c
> @@ -52,8 +52,10 @@ int rnbd_srv_create_dev_sysfs(struct rnbd_srv_dev *dev,
>
> dev->dev_sessions_kobj = kobject_create_and_add("sessions",
> &dev->dev_kobj);
> - if (!dev->dev_sessions_kobj)
> + if (!dev->dev_sessions_kobj) {
> + ret = -ENOMEM;
> goto put_dev_kobj;
> + }
>
> bdev_kobj = &disk_to_dev(bdev->bd_disk)->kobj;
> ret = sysfs_create_link(&dev->dev_kobj, bdev_kobj, "block_dev");
>
Right, thanks you.
Reviewed-by: Danil Kipnis <danil.kipnis@cloud.ionos.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-19 9:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-19 9:19 [PATCH -next] block/rnbd: server: fix error return code in rnbd_srv_create_dev_sysfs() Wei Yongjun
2020-05-19 9:19 ` Wei Yongjun
2020-05-19 9:37 ` Danil Kipnis
2020-05-19 9:37 ` Danil Kipnis
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.