From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91A9DC04EBF for ; Mon, 23 Sep 2019 15:19:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5CDB620820 for ; Mon, 23 Sep 2019 15:19:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cloud.ionos.com header.i=@cloud.ionos.com header.b="SkWWXJ+p" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727226AbfIWPTS (ORCPT ); Mon, 23 Sep 2019 11:19:18 -0400 Received: from mail-io1-f68.google.com ([209.85.166.68]:40377 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725922AbfIWPTR (ORCPT ); Mon, 23 Sep 2019 11:19:17 -0400 Received: by mail-io1-f68.google.com with SMTP id h144so34321830iof.7 for ; Mon, 23 Sep 2019 08:19:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.ionos.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8+1kZpfqKEs2jiXBSAS8QNOa5zMPnsbBRcDhDPWyUXc=; b=SkWWXJ+pqI98nTrghCUxXNUHb5AlQ7oSS9nZecXerAZQ5fxu4Dj4LgXCZGJb3N2bBc 4zh1HfEZpwdTjaQTsHESTHa8IWU7wwLFIM9ee4Ynf/faumGMuQkdZCuVvjHZ05I645qY axYFHoyleDBWVaTslYewklprMuDfrXgKrq+jBLiJEiudSw5HOcpeNlT3U3GD1C1lw+jd /6+qBPNacKq6X2ScqsEYCLNC1WjRAMLLXJZkt1YbwNHZhYQXzallilgO6F3ShqhHtSPM /9EYFSsiOI6jxdfwnGURWNw/RwbhQyl0riOaG4l5hda/qlq9iL27TIrZOW1vgvqFtbmp 2SeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8+1kZpfqKEs2jiXBSAS8QNOa5zMPnsbBRcDhDPWyUXc=; b=BR34KAbddgoLHGd7aJN89YxqEonEn7IS4aArZ798CdJ6Jm04ypSu7Cw3LkpaDT1lSh Yjy1OGVEBvSBzY457xvFsqcYVOlcRTDdtuC5dH/IDbhhLBz7IvX6KnGxkv3cJVs1G+Fl zSXo3RjGdYJsSdLv4YMh/Gh4kO0ZiFQx+hCX9jDuwLMXIa+NFpV4i0IxYu1W363NKkgM 9g0YF6/ySCZqQqZevF6xHr4Lbq3kmGM8CD+kHUq0V3TqrM4lgHtOBE2/s/APcW8/lMsu z1MVVEZCtw7W3yWENnEqThnMOgdCYtuP+5wRjvHfIr/gPWz+OMs3Xeb1Sh0fx0r/CrP/ BjJw== X-Gm-Message-State: APjAAAU+H5B3kpG7mpLANdf8+v9ALM73qXhGvkTwlW8flEcoKFIZIaKf MZH/JLYWPdJg29YwpJIpowyaC0VYgJdSmtQHCsjc X-Google-Smtp-Source: APXvYqyRcUljukWlH3ARxjgeiYMeDbRbbInXGrG2Zdb03PYP7jXQFVpe2Nvx3LYdc1/TteKNVk01jkFdkGG09aN/VZ4= X-Received: by 2002:a02:55c4:: with SMTP id e187mr37797099jab.32.1569251956707; Mon, 23 Sep 2019 08:19:16 -0700 (PDT) MIME-Version: 1.0 References: <20190620150337.7847-1-jinpuwang@gmail.com> <20190620150337.7847-21-jinpuwang@gmail.com> <5ceebb9c-b7ae-8e0c-6f07-d83e878e23d0@acm.org> In-Reply-To: From: Danil Kipnis Date: Mon, 23 Sep 2019 17:19:05 +0200 Message-ID: Subject: Re: [PATCH v4 20/25] ibnbd: server: main functionality To: Bart Van Assche Cc: Jack Wang , linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, Jens Axboe , Christoph Hellwig , Sagi Grimberg , Jason Gunthorpe , Doug Ledford , rpenyaev@suse.de, Roman Pen , Jack Wang Content-Type: text/plain; charset="UTF-8" Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Fri, Sep 20, 2019 at 5:42 PM Bart Van Assche wrote: > > On 9/20/19 12:36 AM, Danil Kipnis wrote: > > On Wed, Sep 18, 2019 at 7:41 PM Bart Van Assche wrote: > >> On 6/20/19 8:03 AM, Jack Wang wrote: > >>> +static int process_msg_sess_info(struct ibtrs_srv *ibtrs, > >>> + struct ibnbd_srv_session *srv_sess, > >>> + const void *msg, size_t len, > >>> + void *data, size_t datalen) > >>> +{ > >>> + const struct ibnbd_msg_sess_info *sess_info_msg = msg; > >>> + struct ibnbd_msg_sess_info_rsp *rsp = data; > >>> + > >>> + srv_sess->ver = min_t(u8, sess_info_msg->ver, IBNBD_PROTO_VER_MAJOR); > >>> + pr_debug("Session %s using protocol version %d (client version: %d," > >>> + " server version: %d)\n", srv_sess->sessname, > >>> + srv_sess->ver, sess_info_msg->ver, IBNBD_PROTO_VER_MAJOR); > >> > >> Has this patch been verified with checkpatch? I think checkpatch > >> recommends not to split literal strings. > > > > Yes it does complain about our splitted strings. But it's either > > splitted string or line over 80 chars or "Avoid line continuations in > > quoted strings" if we use backslash on previous line. I don't know how > > to avoid all three of them. > > Checkpatch shouldn't complain about constant strings that exceed 80 > columns. If it complains about such strings then that's a checkpatch bug. It doesn't in deed... Will concat those splitted quoted string, thank you.