From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34E3AC433DF for ; Tue, 19 May 2020 09:36:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C765207D3 for ; Tue, 19 May 2020 09:36:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cloud.ionos.com header.i=@cloud.ionos.com header.b="bm83j9J0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726505AbgESJge (ORCPT ); Tue, 19 May 2020 05:36:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726494AbgESJge (ORCPT ); Tue, 19 May 2020 05:36:34 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D32FCC05BD09 for ; Tue, 19 May 2020 02:36:33 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id z72so2700766wmc.2 for ; Tue, 19 May 2020 02:36:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.ionos.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bs6Izm0ww7RlGW+J1y4Tjy30dkTU2hAWy2o3D+sO2kk=; b=bm83j9J0GnUXS7tCrv2N6dvh4SZUNeMCSa8Lxkj7llo6KCKXT2sQ2/fOxuL8TTFy6h FfiPlLjzb3tXtCvFZCc5bZKjseYsggMG3ys7At+9Mz8S4l79AwbYLqJ9Yo62OmYxZ2W0 I6jorLj54njoJYTSYOtjxoh9DdXh5rhBrx2eF2Nim1xtw7hadnDTYqIxbulj4+XiGbMw 2qWzVzyGywOW1qOWYzSYJDie2cjd0SmekZwPUfmMrBGkvJnHry2mAiZ/8hGVlFQKtVGR WW4fxGVEyjrwP5riXs+Pqjq7YJSmLZ7SRgcxn+DqbL9DdjLJbaicfUc0wDhfrhHC8aId plfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bs6Izm0ww7RlGW+J1y4Tjy30dkTU2hAWy2o3D+sO2kk=; b=f0BRAcAtsPTv/1LIaG2JezimmfhTuSCmEuqD4mTwuMZKLn6Zvab8Xaox4O0ecVueDW sNIfm181vJa7xYJ8Vy6FHtcWtyDKDOCnaT6d6MMicUsExi1PokYdid1YWOQor5F/l2vj GIE7tx4Lz/l3y4yYX3UQjmHO/7f3wJRD7+ifDHnrHns1RybpG8v3CWJVVqqBZqllDDim VY/5Eu6bMS3hb0tjA9Nt49x81HT089jxzYfdw3F6hUx91KQz5YTUiPAEi37TkqXcYy39 wPEjCm6XDhjlB3ID1t8I2pnO5QvnY8qiyOF5lTSRlnwS8zx/90879PD79sb0gwoG4dy0 /Lsg== X-Gm-Message-State: AOAM532uDdDXbPV9pQYr7DO7YPwbgieJKV0njLSLa5mGzupnXm+pgU1T nB0i2pmmjYsLTjSnJIwFGuQHa2kFt+34PcgdZwX5 X-Google-Smtp-Source: ABdhPJx8KddI6xOBKAtBT3MNAvDPf8ZR1YV5tr6yRDmjr4W3Szf61rxuKncs8dvrdHZTra8UpszBnrvkpIJMQ9MF0Bo= X-Received: by 2002:a1c:a3c5:: with SMTP id m188mr4465160wme.160.1589880992394; Tue, 19 May 2020 02:36:32 -0700 (PDT) MIME-Version: 1.0 References: <20200519091912.134358-1-weiyongjun1@huawei.com> In-Reply-To: <20200519091912.134358-1-weiyongjun1@huawei.com> From: Danil Kipnis Date: Tue, 19 May 2020 11:36:21 +0200 Message-ID: Subject: Re: [PATCH -next] RDMA/rtrs: server: fix some error return code To: Wei Yongjun Cc: Jack Wang , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org, Hulk Robot Content-Type: text/plain; charset="UTF-8" Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Tue, May 19, 2020 at 11:16 AM Wei Yongjun wrote: > > Fix to return negative error code -ENOMEM from the some error handling > cases instead of 0, as done elsewhere in this function. > > Fixes: 9cb837480424 ("RDMA/rtrs: server: main functionality") > Fixes: 91b11610af8d ("RDMA/rtrs: server: sysfs interface functions") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- > drivers/infiniband/ulp/rtrs/rtrs-srv.c | 8 +++++--- > drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c | 1 + > 2 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv.c b/drivers/infiniband/ulp/rtrs/rtrs-srv.c > index ba8ab33b94a2..526433580b96 100644 > --- a/drivers/infiniband/ulp/rtrs/rtrs-srv.c > +++ b/drivers/infiniband/ulp/rtrs/rtrs-srv.c > @@ -660,8 +660,8 @@ static int map_cont_bufs(struct rtrs_srv_sess *sess) > GFP_KERNEL, sess->s.dev->ib_dev, > DMA_TO_DEVICE, rtrs_srv_rdma_done); > if (!srv_mr->iu) { > - rtrs_err(ss, "rtrs_iu_alloc(), err: %d\n", > - -ENOMEM); > + err = -ENOMEM; > + rtrs_err(ss, "rtrs_iu_alloc(), err: %d\n", err); > goto free_iu; > } > } > @@ -2150,8 +2150,10 @@ static int __init rtrs_server_init(void) > goto out_chunk_pool; > } > rtrs_wq = alloc_workqueue("rtrs_server_wq", WQ_MEM_RECLAIM, 0); > - if (!rtrs_wq) > + if (!rtrs_wq) { > + err = -ENOMEM; > goto out_dev_class; > + } > > return 0; > > diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c b/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c > index 0cf015634338..3d7877534bcc 100644 > --- a/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c > +++ b/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c > @@ -189,6 +189,7 @@ static int rtrs_srv_create_once_sysfs_root_folders(struct rtrs_srv_sess *sess) > } > srv->kobj_paths = kobject_create_and_add("paths", &srv->dev.kobj); > if (!srv->kobj_paths) { > + err = -ENOMEM; > pr_err("kobject_create_and_add(): %d\n", err); > device_unregister(&srv->dev); > goto unlock; > Thanks a lot Wei! Reviewed-by: Danil Kipnis From mboxrd@z Thu Jan 1 00:00:00 1970 From: Danil Kipnis Date: Tue, 19 May 2020 09:36:21 +0000 Subject: Re: [PATCH -next] RDMA/rtrs: server: fix some error return code Message-Id: List-Id: References: <20200519091912.134358-1-weiyongjun1@huawei.com> In-Reply-To: <20200519091912.134358-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Wei Yongjun Cc: Jack Wang , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org, Hulk Robot On Tue, May 19, 2020 at 11:16 AM Wei Yongjun wrote: > > Fix to return negative error code -ENOMEM from the some error handling > cases instead of 0, as done elsewhere in this function. > > Fixes: 9cb837480424 ("RDMA/rtrs: server: main functionality") > Fixes: 91b11610af8d ("RDMA/rtrs: server: sysfs interface functions") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- > drivers/infiniband/ulp/rtrs/rtrs-srv.c | 8 +++++--- > drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c | 1 + > 2 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv.c b/drivers/infiniband/ulp/rtrs/rtrs-srv.c > index ba8ab33b94a2..526433580b96 100644 > --- a/drivers/infiniband/ulp/rtrs/rtrs-srv.c > +++ b/drivers/infiniband/ulp/rtrs/rtrs-srv.c > @@ -660,8 +660,8 @@ static int map_cont_bufs(struct rtrs_srv_sess *sess) > GFP_KERNEL, sess->s.dev->ib_dev, > DMA_TO_DEVICE, rtrs_srv_rdma_done); > if (!srv_mr->iu) { > - rtrs_err(ss, "rtrs_iu_alloc(), err: %d\n", > - -ENOMEM); > + err = -ENOMEM; > + rtrs_err(ss, "rtrs_iu_alloc(), err: %d\n", err); > goto free_iu; > } > } > @@ -2150,8 +2150,10 @@ static int __init rtrs_server_init(void) > goto out_chunk_pool; > } > rtrs_wq = alloc_workqueue("rtrs_server_wq", WQ_MEM_RECLAIM, 0); > - if (!rtrs_wq) > + if (!rtrs_wq) { > + err = -ENOMEM; > goto out_dev_class; > + } > > return 0; > > diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c b/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c > index 0cf015634338..3d7877534bcc 100644 > --- a/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c > +++ b/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c > @@ -189,6 +189,7 @@ static int rtrs_srv_create_once_sysfs_root_folders(struct rtrs_srv_sess *sess) > } > srv->kobj_paths = kobject_create_and_add("paths", &srv->dev.kobj); > if (!srv->kobj_paths) { > + err = -ENOMEM; > pr_err("kobject_create_and_add(): %d\n", err); > device_unregister(&srv->dev); > goto unlock; > Thanks a lot Wei! Reviewed-by: Danil Kipnis