From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb0-f170.google.com (mail-yb0-f170.google.com [209.85.213.170]) by mail.openembedded.org (Postfix) with ESMTP id EB55B719C3 for ; Mon, 3 Apr 2017 11:47:14 +0000 (UTC) Received: by mail-yb0-f170.google.com with SMTP id f204so30925709ybc.2 for ; Mon, 03 Apr 2017 04:47:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=1aKgvmYUfHzNvwX19knyDdO++zEG/qyAEyJ9Ufhmv8Q=; b=lgHpYQHpV7nov4Cy2N6QUNWmHmmqh8/AMvo8zGppspgpuvetULD5niQmWhgmD4L5c+ RcTnIvwcTaxP9867QM9wnAyu/7ocV1izKyHjjadEiccF2BqJRW7nX7BSsCWt8o5yaxKa fyBpyLExs0pa2dOvCXKQ9oJ4sBHrQsiKDMLfd43H5qJ5z/quVefqbdFsP7WiNTW2wCDr CituuYnWkxazGIKSIfWp3EanPuZsB+yz8IVjrwofa8MgumnKj+U8OCkc9sad3jsGPCph Jv+LFb8/wA96/cIT5MeSp67gRZ+MqBAx//eMnJ2DyOBFESM4uKqSmBfe5RfD5l5Vouv9 Zi5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1aKgvmYUfHzNvwX19knyDdO++zEG/qyAEyJ9Ufhmv8Q=; b=Jzw7ipRG+huIHIQXCZ1WN0SteWmt3sDhOK41MJoVM3wV7sMCaxx/rhDiyRND4d4yxH r41Bku7yVOZaipCFVYWdFLeAMGA+1SP//OtTmO7ONGE7O1PCChTu6bUfORvcfPZVPStx sVnP9RtACe2ABCYhabVY27zWyhHm7BZNm1Ew9bZG1szG2SSLpRuP4wov1sEmm7Pu5ocv 6bauRyOn0bHhS9Lvz/N0DaprhBwkUY8NrY8w5fLRU6JFKeU/iQuScjWWKpoU5R8H+/em mOHVRL8qCWd2YZimcf97ssS/SPpJPmJkH8z1WtziiHQNAZ/uBfnrEZlNZTn4S2ir0bl3 RiRA== X-Gm-Message-State: AFeK/H2cQFWkQbqravCxhM2vqe85jfttL8hICScWIAb0dCzk/5mSEHGy6BXYj4/EAXomB3B7NXj9XsbrKPAjn0nd X-Received: by 10.129.197.74 with SMTP id o10mr12049964ywj.183.1491220035488; Mon, 03 Apr 2017 04:47:15 -0700 (PDT) MIME-Version: 1.0 Received: by 10.129.81.136 with HTTP; Mon, 3 Apr 2017 04:46:45 -0700 (PDT) In-Reply-To: References: <1491187907-5752-1-git-send-email-yin.thong.choong@intel.com> <1491187907-5752-5-git-send-email-yin.thong.choong@intel.com> From: Jussi Kukkonen Date: Mon, 3 Apr 2017 14:46:45 +0300 Message-ID: To: "Choong, Yin Thong" Cc: Patches and discussions about the oe-core layer Subject: Re: [PATCH 4/8] logrotate: replace fedorahosted.org SRC_URI with yoctoproject.org source X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Apr 2017 11:47:15 -0000 Content-Type: multipart/alternative; boundary=94eb2c1a54fa7f6134054c41b87c --94eb2c1a54fa7f6134054c41b87c Content-Type: text/plain; charset=UTF-8 On 3 April 2017 at 14:00, Choong, Yin Thong wrote: > > Hi, > Once I change to github.com below error pop out. Seem like it miss align with the patch compare with github.com logrotate source. Both package seem got miss align on the version. When I compare yoctoproject logrotate.c and github logrotate.c it has big different (as attached), there even got different parameter count on some API function Ross's suggestion of asking the maintainer is good but I'll note that there does not seem to be any difference in the actual source files: you're maybe looking at a different version. The patching error is a result of the top level source directory name changing. This could be worked around with S = "${WORKDIR}/logrotate-r3-9-1" Jussi --94eb2c1a54fa7f6134054c41b87c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On 3 April 2017 at 14:00, Choong, Yin Thong <yin.thong.choong@intel.com> wrot= e:
>
> Hi,
> Once I change to github.com below error pop out. Seem like it miss align with the pat= ch compare with github.com logrotate sour= ce. Both package seem got miss align on the version. When I compare yoctopr= oject logrotate.c and github logrotate.c it has big different (as attached)= , there even got different parameter count on some API function


= Ross's =C2=A0suggestion of asking the maintainer is good but I'll n= ote that there does not seem to be any difference in the actual source file= s: you're maybe looking at a different version.=C2=A0

The patching error is a result of the top level source directory name cha= nging. This could be worked around with
=C2=A0 S =3D "${WORKDIR}/lo= grotate-r3-9-1"

Jussi=C2=A0

--94eb2c1a54fa7f6134054c41b87c--