From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4466DC43331 for ; Wed, 25 Mar 2020 10:50:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E0EE206F6 for ; Wed, 25 Mar 2020 10:50:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N2YM+h1X" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E0EE206F6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34094 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jH3bn-0005W6-6i for qemu-devel@archiver.kernel.org; Wed, 25 Mar 2020 06:50:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35974) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jH3Wb-0006vT-00 for qemu-devel@nongnu.org; Wed, 25 Mar 2020 06:44:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jH3WZ-00047j-R2 for qemu-devel@nongnu.org; Wed, 25 Mar 2020 06:44:40 -0400 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:34195) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jH3WZ-000463-K1 for qemu-devel@nongnu.org; Wed, 25 Mar 2020 06:44:39 -0400 Received: by mail-wr1-x442.google.com with SMTP id 65so2387487wrl.1 for ; Wed, 25 Mar 2020 03:44:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Z5tudx4i8QBXAELJ6WYCq4bhA/K+X97tGUXk24U1ORk=; b=N2YM+h1Xu7wSkdHNymigCBlXMF9ES4fk7bTmHYA4PIrccLYBd5LHdHuBYWuz90ZvqM NerkJNnYq3c6ZNjiYeYYuqPYK11UyOb0be9R/UXulEUZV6KEMyJILMxtzGcOY6ArYcrC goz3hY18sU6VD3bVm9Y+Gurt1clE7lAXAnlfktUKxVBtUtRYK16cO8KF6F61LSv8lM9K 1k1Eq9WXhEuB3Z8kee2eyIRoGdHb2C+v/sKfHkp2GJ208AvHqerYXILhVyIlf8YqdqEr Vl+alA9FnehBFp+OzN4I1PIZ0JYoWsUI+vZ2e48a/x9EQV5O9HfbysIjaNIay/nYQTIO +OYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Z5tudx4i8QBXAELJ6WYCq4bhA/K+X97tGUXk24U1ORk=; b=tqgIncyWTbBNfp6wUAT/p5I0rHEEGG4zGhlRZ30I7fVZw2Gl94a/nrJB+i66OKbt1f i0c6MBDCdMdZS2qCu2FH7Sx6JB6reGByCD13V1ySob7FufAq4+lRaPqSkPorwjnnyId9 s5vBAwGAP8w9VYzN3f5Iu6H8QIW1KlyRO4xZaQlG427B1y55fv3VxRYshkmMvzuLsXc7 l7K75K+S1hg8xwRxw781piFo+ZWJyJaVKolxI2rhQJATRoRvt+GuKF7qZSus7Rh08B3D yR9FGOQ53igi9dWJWVnzGkKKUqXRNOrqmbcx69Y9DNqObG/DlXCeTuKT1tHn8OjVtFWC JBuA== X-Gm-Message-State: ANhLgQ0Ab00u7IwGXlKPdm6Rzqtq5n9j2uNJTAtf1JAFv0tST0GjX3GQ 8huxfW7mZJWXr+6Ym4GZ14Yjoo9RQz2dZT78fkE= X-Google-Smtp-Source: ADFU+vu8+JENtzGIyWC+WQy3rqxolPiz0zG9Cz0cWOgsJI5PoX8d9yKJka5AKssY+UbfMGekLSeW6CTSlbSQPYm6hj4= X-Received: by 2002:adf:f64a:: with SMTP id x10mr2669756wrp.402.1585133076421; Wed, 25 Mar 2020 03:44:36 -0700 (PDT) MIME-Version: 1.0 References: <20200324122212.11156-1-jiaxun.yang@flygoat.com> In-Reply-To: From: Aleksandar Markovic Date: Wed, 25 Mar 2020 12:44:16 +0200 Message-ID: Subject: Re: [PATCH for-5.0, v1] target/mips: Fix loongson multimedia condition instructions To: Richard Henderson Content-Type: multipart/alternative; boundary="000000000000f11f6005a1ab8d64" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::442 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: aurelien@aurel32.net, aleksandar.rikalo@rt-rk.com, QEMU Developers , Jiaxun Yang , Huacai Chen Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000f11f6005a1ab8d64 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable 16:59 Uto, 24.03.2020. Richard Henderson =D1= =98=D0=B5 =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BE/=D0=BB=D0=B0: > > On 3/24/20 5:22 AM, Jiaxun Yang wrote: > > Loongson multimedia condition instructions were previously implemented as > > write 0 to rd due to lack of documentation. So I just confirmed with Loongson > > about their encoding and implemented them correctly. > > > > Signed-off-by: Jiaxun Yang > > Acked-by: Huacai Chen > > --- > > v1: Use deposit opreations according to Richard's suggestion. > > --- > > target/mips/translate.c | 35 +++++++++++++++++++++++++++++++---- > > 1 file changed, 31 insertions(+), 4 deletions(-) > > Reviewed-by: Richard Henderson > I just have a couple of mon-essential suggestions wrt coding style, but since all that is really of very insignificant nauture, I wouldn't even mention them. Reviewed-by: Aleksandar Markovic May I ask you, Richard, to select this patch for your next TCG-for-5.0 queue, so that I don't go through a MIPS queue process for just a single patch? Thanks to all involved people! Aleksandar > > r~ --000000000000f11f6005a1ab8d64 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

16:59 Uto, 24.03.2020. Richard Henderson <richard.henderson@linaro.org> =D1= =98=D0=B5 =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BE/=D0=BB=D0=B0:
>
> On 3/24/20 5:22 AM, Jiaxun Yang wrote:
> > Loongson multimedia condition instructions were previously implem= ented as
> > write 0 to rd due to lack of documentation. So I just confirmed w= ith Loongson
> > about their encoding and implemented them correctly.
> >
> > Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> > Acked-by: Huacai Chen <ch= enhc@lemote.com>
> > ---
> > v1: Use deposit opreations according to Richard's suggestion.=
> > ---
> >=C2=A0 target/mips/translate.c | 35 ++++++++++++++++++++++++++++++= +----
> >=C2=A0 1 file changed, 31 insertions(+), 4 deletions(-)
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>

I just have a couple of mon-essential suggestions wrt coding= style, but since all that is really of very insignificant nauture, I would= n't even mention them.

Reviewed-by: Aleksandar Markovic <aleksandar.qemi.devel@gmail.com>

May I ask you, Richard, to select this patch for your next T= CG-for-5.0 queue, so that I don't go through a MIPS queue process for j= ust a single patch?

Thanks to all involved people!

Aleksandar

>
> r~

--000000000000f11f6005a1ab8d64--