From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8D26C433E1 for ; Fri, 29 May 2020 21:21:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 94D0420776 for ; Fri, 29 May 2020 21:21:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="EXsZLu+E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94D0420776 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 24CC68001A; Fri, 29 May 2020 17:21:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FC7B80010; Fri, 29 May 2020 17:21:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0EB638001A; Fri, 29 May 2020 17:21:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0230.hostedemail.com [216.40.44.230]) by kanga.kvack.org (Postfix) with ESMTP id E8BC780010 for ; Fri, 29 May 2020 17:21:18 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id A599B180AD820 for ; Fri, 29 May 2020 21:21:18 +0000 (UTC) X-FDA: 76871027436.24.woman47_287ddc274f644 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 872BB1A4A5 for ; Fri, 29 May 2020 21:21:18 +0000 (UTC) X-HE-Tag: woman47_287ddc274f644 X-Filterd-Recvd-Size: 4924 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Fri, 29 May 2020 21:21:18 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id s1so1026640ljo.0 for ; Fri, 29 May 2020 14:21:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9mrfYCP39HOo5QKzOva9+qo4gs3JX1Vw81a0NlLBaxU=; b=EXsZLu+E3UDSQoInrNltLhM1zMXWngPH5XCC6FwUcbfT3e63a22i6NHPKjPZjeLU7G kWF9hgMZzHVmBvEgR596sIl1NXeRIJxWL3M9FLgIWyOFeElFiFkeCV9nWeoDU+Oafuu5 UlloMFmPQzI7+PI5YoBzg79CJCdxARSCpO/lI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9mrfYCP39HOo5QKzOva9+qo4gs3JX1Vw81a0NlLBaxU=; b=oXRfgMMXnpvFnj87h/D5NbVjG9QRPiLtyUbwPGiXDYvwNVVdl0Xkzgrovuj1w+9eBf HICMqmMUadrL7Jo6T0K14sY6h8GzL+KxBSW35YRak9DZR7G7sbVC0PnV98qheyG2+yfO r0yfkC5aVDrHxdra0WbHVEu66jY7Q7zb4cEntCJ9KBILKAU8LT3eWYwqm2P9Eu9bJRil rbZaCN24YmKR1LgpIyVKv6/tCgrgO8M/2K4fWoWz9nN+exY4+ZX2iDgMERzNPnScnGhV JI26dyNu/vSs/XvW5fKYkwg/NUybV7wEB/8bNimbgP23h7JrlUOhzysnKMbkJrjHfJW3 3Qjg== X-Gm-Message-State: AOAM531f8EBGmPGyt6cKnq/ti/zFcrxoBCsK2BzcEaVghI01cCDJ3NV1 Lg4S5DI9XqIO06ALPmv7qFMpH4EehSE= X-Google-Smtp-Source: ABdhPJy9XHz/Ys7V/oL2S6U1hJEf2uX7DVT9+3N0cstNP6gnC9lFmsVBLCYXY+JyMbwPB8SxPOvVpg== X-Received: by 2002:a2e:980d:: with SMTP id a13mr5347368ljj.277.1590787276271; Fri, 29 May 2020 14:21:16 -0700 (PDT) Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com. [209.85.208.182]) by smtp.gmail.com with ESMTPSA id t27sm2208210ljo.114.2020.05.29.14.21.15 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 May 2020 14:21:15 -0700 (PDT) Received: by mail-lj1-f182.google.com with SMTP id c11so1012506ljn.2 for ; Fri, 29 May 2020 14:21:15 -0700 (PDT) X-Received: by 2002:a2e:b16e:: with SMTP id a14mr4688349ljm.70.1590787274892; Fri, 29 May 2020 14:21:14 -0700 (PDT) MIME-Version: 1.0 References: <20200527222015.62ba8592af63dae12ab58ffe@linux-foundation.org> <20200529133139.c606b0e34255336d97af2b30@linux-foundation.org> <20200529141234.a77cdb556ea55a9b2514ef90@linux-foundation.org> In-Reply-To: <20200529141234.a77cdb556ea55a9b2514ef90@linux-foundation.org> From: Linus Torvalds Date: Fri, 29 May 2020 14:20:59 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: incoming To: Andrew Morton Cc: mm-commits@vger.kernel.org, Linux-MM Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 872BB1A4A5 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 29, 2020 at 2:12 PM Andrew Morton wrote: > > Stupid diffstat. Means that basically all my diffstats are very wrong. I'm actually used to diffstats not matching 100%/ Usually it's not due to this issue - a "git diff --stat" *will* give the stat from the actual combined diff result - but with git diffstats the issue is that I might have gotten a patch from another source. So the diffstat I see after-the-merge is possibly different from the pre-merge diffstat simply due to merge issues. So then I usually take a look at "ok, why did that diffstat differ" and go "Ahh". In your case, when I looked at the diffstat, I couldn't for the life of me see how you would have gotten the diffstat you did, since I only saw a single patch with no merge issues. > Thanks for spotting it. > > I can fix that... I can also just live with it, knowing what your workflow is. The diffstat matching exactly just isn't that important - in fact, different versions of "diff" can give slightly different output anyway depending on diff algorithms even when they are looking at the exact same before/after state. There's not necessarily always only one way to generate a valid diff. So to me, the diffstat is more of a guide than a hard thing, and I want to see the rough outline, In fact, one reason I want to see it in pull requests is actually just that I want to get a feel for what changes even before I do the pull or merge, so it's not just a "match against what I get" thing. Linus