From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7ECBC433EF for ; Wed, 8 Sep 2021 18:38:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE12D61168 for ; Wed, 8 Sep 2021 18:38:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346764AbhIHSjZ (ORCPT ); Wed, 8 Sep 2021 14:39:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240231AbhIHSjY (ORCPT ); Wed, 8 Sep 2021 14:39:24 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27408C061575 for ; Wed, 8 Sep 2021 11:38:16 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id k13so6764687lfv.2 for ; Wed, 08 Sep 2021 11:38:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=40kX6ALi5H/i1jZ+0bBNutAUbv1GhtRu7nONMHCvjlE=; b=VHPuad7+1hEYlx53CSpOcq9QDjSGL2whUm3DSn5BWvDDQb3cz6F1yY3nYbscrroilN 2h4+d5l/jorNOjq66BOfFmpmCycAprLXtr5h+5Cl+yDd4ddafeIYJZmZc/Mu10P7a9Va I4l5UdYZen7/MMAwp1tjkarBS34zyjCJTUWlQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=40kX6ALi5H/i1jZ+0bBNutAUbv1GhtRu7nONMHCvjlE=; b=p0w2Jpgj4NkQqEzhHcognqFvSfMhL/DbikvzgO7Bi3LMrtaQbhk47RbSr6u/co4Ply MWkJncck3HKY7+Gw57fDDF5E5arraQdgSUQVqhLUiJALO/Hfv376RzTsJqWaQXL0U2SC NkoeU1Wsrf8AceTFqLnIJUFmcJK8zfOM11xLcwiG/PNzYlWX6YzICB7hX8siSp8J4E3b lN81wjliAjynj9XnNiZOi7jRTvHcRXI/pFvh1kQ5ApvdtHxnIhh2luOeLornCPU60K3y 9r8iDSkpwc2zdQ+twWqa64Nur/nvzz7apbo496Z8mFgb2c7VTHZFPxfAWU3FBWZCnuCy r1jw== X-Gm-Message-State: AOAM532sw7dGKGg/y5jmJ4k6FWGcEENbK7GIOiDry5Yii5I+shzuuWhG 7k/D+NTzYVta44aqQVmcsMTNy3mtawATPFiJVQA= X-Google-Smtp-Source: ABdhPJz9K33KDXq6pasLFKbteVt2mQu6/GIMahRaCZl8xlxcHDQWcTwUuCYvyGQL8OZ+5bUTAVZWaw== X-Received: by 2002:a05:6512:3a82:: with SMTP id q2mr3690616lfu.582.1631126293930; Wed, 08 Sep 2021 11:38:13 -0700 (PDT) Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com. [209.85.208.171]) by smtp.gmail.com with ESMTPSA id k16sm260545lfj.231.2021.09.08.11.38.11 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Sep 2021 11:38:12 -0700 (PDT) Received: by mail-lj1-f171.google.com with SMTP id m4so5066681ljq.8 for ; Wed, 08 Sep 2021 11:38:11 -0700 (PDT) X-Received: by 2002:a05:651c:158f:: with SMTP id h15mr4085392ljq.249.1631126290952; Wed, 08 Sep 2021 11:38:10 -0700 (PDT) MIME-Version: 1.0 References: <20210907195226.14b1d22a07c085b22968b933@linux-foundation.org> <20210908025901.gV9fu4cei%akpm@linux-foundation.org> In-Reply-To: <20210908025901.gV9fu4cei%akpm@linux-foundation.org> From: Linus Torvalds Date: Wed, 8 Sep 2021 11:37:54 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 108/147] bitops: move find_bit_*_le functions from le.h to find.h To: Andrew Morton Cc: aklimov@redhat.com, Alexander Lobakin , Andy Shevchenko , Dennis Zhou , Jiri Olsa , Linux-MM , mm-commits@vger.kernel.org, Ulf Hansson , Will Deacon , Wolfram Sang , Yury Norov Content-Type: text/plain; charset="UTF-8" Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org On Tue, Sep 7, 2021 at 7:59 PM Andrew Morton wrote: > > From: Yury Norov > Subject: bitops: move find_bit_*_le functions from le.h to find.h > > It's convenient to have all find_bit declarations in one place. What what what? The subject line says "move". The body of the commit message doesn't imply anything else. But the patch doesn't "move" anything at all: > include/asm-generic/bitops/find.h | 193 ---------------------------- > include/asm-generic/bitops/le.h | 64 --------- > 2 files changed, 257 deletions(-) What's going on? Dropped just because I refuse to have anything to do with patches that lie about what they are actually doing. Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B92D7C433F5 for ; Wed, 8 Sep 2021 18:38:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5631F61168 for ; Wed, 8 Sep 2021 18:38:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5631F61168 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id CBFF76B0071; Wed, 8 Sep 2021 14:38:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C6DE86B0072; Wed, 8 Sep 2021 14:38:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1016900002; Wed, 8 Sep 2021 14:38:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0211.hostedemail.com [216.40.44.211]) by kanga.kvack.org (Postfix) with ESMTP id 974E26B0071 for ; Wed, 8 Sep 2021 14:38:15 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 48BC431E76 for ; Wed, 8 Sep 2021 18:38:15 +0000 (UTC) X-FDA: 78565266150.19.B12E121 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by imf05.hostedemail.com (Postfix) with ESMTP id 13E7E5050592 for ; Wed, 8 Sep 2021 18:38:14 +0000 (UTC) Received: by mail-lj1-f178.google.com with SMTP id s12so5148585ljg.0 for ; Wed, 08 Sep 2021 11:38:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=40kX6ALi5H/i1jZ+0bBNutAUbv1GhtRu7nONMHCvjlE=; b=VHPuad7+1hEYlx53CSpOcq9QDjSGL2whUm3DSn5BWvDDQb3cz6F1yY3nYbscrroilN 2h4+d5l/jorNOjq66BOfFmpmCycAprLXtr5h+5Cl+yDd4ddafeIYJZmZc/Mu10P7a9Va I4l5UdYZen7/MMAwp1tjkarBS34zyjCJTUWlQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=40kX6ALi5H/i1jZ+0bBNutAUbv1GhtRu7nONMHCvjlE=; b=0cPXkyoTsbMChl8zjm+3gcxwectyzDdDVV4l5KHFy+TDtrbh0K5M0x56g0tWYMF81l npUtS82Ui08jg4WcbrqkNb0vAvBzybjCbdQ/xIwIC7T6w7bKJnOPpy7Wf+dPPkq/zq77 34I19Vw3ECse8zl0ZGP9XjXeXMUD4nTSHmaj5KQ226AjhztkSfc7hKdxVMbACBfNIbZB AWtOUE+Ox9t3YtZF3Ahm6AJXQaqMmQaMrO7+KNEo3djybLlXYFawXptuIKAOIEHMhfDB IFoeGCYDhPbjlMP6Ml0ehayfK9mAyrkwBA/zAKHS8J8K5pIwP/0jfP8/87Z+e+Imm+xT u0jg== X-Gm-Message-State: AOAM531SPt6KCTCsOxZ9GrVZqIvRsjNbYKHVe4D+ne8A13MYKXwvLNe4 BpeRosN0DVipLhnJNqKTZZ0nBeVCZWQ3ROe4LIU= X-Google-Smtp-Source: ABdhPJxvToRMdCtSJTlmKpagyD3OvAv9wX0a5iEg7oNKwea+hPY4E06NJdE5LIWuGkkexWI63RkLZQ== X-Received: by 2002:a2e:918e:: with SMTP id f14mr3868665ljg.357.1631126293520; Wed, 08 Sep 2021 11:38:13 -0700 (PDT) Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com. [209.85.208.179]) by smtp.gmail.com with ESMTPSA id u21sm261207lfs.111.2021.09.08.11.38.11 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Sep 2021 11:38:11 -0700 (PDT) Received: by mail-lj1-f179.google.com with SMTP id l18so5048300lji.12 for ; Wed, 08 Sep 2021 11:38:11 -0700 (PDT) X-Received: by 2002:a05:651c:158f:: with SMTP id h15mr4085392ljq.249.1631126290952; Wed, 08 Sep 2021 11:38:10 -0700 (PDT) MIME-Version: 1.0 References: <20210907195226.14b1d22a07c085b22968b933@linux-foundation.org> <20210908025901.gV9fu4cei%akpm@linux-foundation.org> In-Reply-To: <20210908025901.gV9fu4cei%akpm@linux-foundation.org> From: Linus Torvalds Date: Wed, 8 Sep 2021 11:37:54 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 108/147] bitops: move find_bit_*_le functions from le.h to find.h To: Andrew Morton Cc: aklimov@redhat.com, Alexander Lobakin , Andy Shevchenko , Dennis Zhou , Jiri Olsa , Linux-MM , mm-commits@vger.kernel.org, Ulf Hansson , Will Deacon , Wolfram Sang , Yury Norov Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=VHPuad7+; spf=pass (imf05.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.178 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 13E7E5050592 X-Stat-Signature: da3fr4sa6yfb55hrgskuhxdx4zxtfupd X-HE-Tag: 1631126294-12884 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 7, 2021 at 7:59 PM Andrew Morton wrote: > > From: Yury Norov > Subject: bitops: move find_bit_*_le functions from le.h to find.h > > It's convenient to have all find_bit declarations in one place. What what what? The subject line says "move". The body of the commit message doesn't imply anything else. But the patch doesn't "move" anything at all: > include/asm-generic/bitops/find.h | 193 ---------------------------- > include/asm-generic/bitops/le.h | 64 --------- > 2 files changed, 257 deletions(-) What's going on? Dropped just because I refuse to have anything to do with patches that lie about what they are actually doing. Linus